Re: ln -s A B fails if symlink B exists and its value is too long

2013-12-27 Thread Pádraig Brady
On 12/27/2013 03:47 AM, Ken Irving wrote: > I happened to run into a case were ln -s exited with a confusing message, > and reduced it to the following: > > ln -s $(printf '%0.sx' {1..256}) len256 > ln -s x len256 > > (where the printf is there just to create a value 256 bytes long). > Th

Re: ln -s A B fails if symlink B exists and its value is too long

2013-12-27 Thread Pádraig Brady
On 12/27/2013 12:31 PM, Pádraig Brady wrote: > This is a bug and happens when ln tries to determine of the last arg is a > directory. > It does a stat(2) which gives this error. ENOENT is specifically ignored, but > it > seems like others should be too. You can see the source of

Re: Shuf reservoir sampling

2013-12-29 Thread Pádraig Brady
On 12/28/2013 05:13 PM, Jyothis V wrote: > Hi, thanks for the reply. I understand why something like reservoir sampling > is needed. But in shuf.c, shuffling is done in two steps: 1) using reservoir > sampling, an array of length head_length is obtained. At this stage, the > array is not complet

Re: Wrong copyright in selinux.c and selinux.h

2014-01-02 Thread Pádraig Brady
On 01/02/2014 05:38 PM, Bernhard Voelker wrote: > Hi Daniel, > > a bad copyright line slipped into coreutils.git during the SELinux commits: > > $ make update-copyright > GEN update-copyright > src/selinux.c: warning: copyright statement not found > src/selinux.h: warning: copyrigh

Re: [PATCH] maint: update all copyright year number ranges

2014-01-02 Thread Pádraig Brady
On 01/02/2014 06:01 PM, Bernhard Voelker wrote: > Run "make update-copyright", but then also run this, > perl -pi -e 's/2\d\d\d-//' tests/sample-test > to make that one script use the single most recent year number. > --- > > The original and lengthy patch is attached. > Pushing soon. Please fi

Re: Wrong copyright in selinux.c and selinux.h

2014-01-02 Thread Pádraig Brady
On 01/02/2014 06:22 PM, Bernhard Voelker wrote: > On 01/02/2014 07:08 PM, Pádraig Brady wrote: >> On 01/02/2014 05:38 PM, Bernhard Voelker wrote: >>> - Copyright (C) 2012-2013 Red Hat, Inc. >>> + Copyright (C) 2012-2013 Free Software Foundation, Inc. >> >&g

Re: [PATCH] maint: update all copyright year number ranges

2014-01-03 Thread Pádraig Brady
On 01/02/2014 09:29 PM, Bernhard Voelker wrote: > On 01/02/2014 07:33 PM, Pádraig Brady wrote: >> Please first update the gnulib submodule too, >> to incorporate the corresponding change from there. > > Thanks! > > The first patch does the gnulib update: > >

[PATCH] copy: fix SELinux context preservation for existing directories

2014-01-05 Thread Pádraig Brady
* src/copy.c (copy_internal): Use the global process context to set the context of existing directories before they're populated. This is more consistent with the new directory case, and fixes a bug for existing directories where we erroneously set the context to the last copied descendent, rather

Re: [PATCH] tests: avoid FP failure when cp fails for /proc/cpuinfo

2014-01-08 Thread Pádraig Brady
On 01/08/2014 10:48 PM, Bernhard Voelker wrote: > On 01/08/2014 11:25 PM, Sergio Durigan Junior wrote: >> On Wednesday, January 08 2014, Bernhard Voelker wrote: >>> What does 'cp /proc/cpuinfo exp' produce? >> >> It produces "exp" with the contents of /proc/cpuinfo. > > Thanks again. > Okay, toget

Re: [PATCH] copy: fix SELinux context preservation for existing directories

2014-01-09 Thread Pádraig Brady
On 01/09/2014 01:43 AM, Bernhard Voelker wrote: > On 01/05/2014 04:00 PM, Pádraig Brady wrote: >> src/copy.c | 13 - > > ... > >> diff --git a/NEWS b/NEWS >> index 66884db..0d81f45 100644 >> --- a/NEWS >> +++ b/N

Re: [PATCH] copy: fix SELinux context preservation for existing directories

2014-01-09 Thread Pádraig Brady
On 01/09/2014 06:52 PM, Bernhard Voelker wrote: > On 01/05/2014 04:00 PM, Pádraig Brady wrote: > > Hi Padraig, > > I don't have a SELinux system here, so I can't add much to this, ... > >> diff --git a/tests/cp/cp-a-selinux.sh b/tests/cp/cp-a-selinux.sh >>

Re: [PATCH] tests: improve test for a working setfacl

2014-01-10 Thread Pádraig Brady
On 01/10/2014 04:04 PM, Bernhard Voelker wrote: > As a side note for work around needed for setfacl below, i.e., the odd > behavior of only invoking the syscall if there would be change, I want > to mention that this is another reason for chmod, chown, etc. to continue > doing the system call inste

Re: [PATCH] sort: fix two race conditions reported by valgrind.

2014-01-13 Thread Pádraig Brady
On 01/14/2014 12:22 AM, Shayan Pooya wrote: > Valgrind reported two race conditions when I ran sort on a small file. > Both of them seem to be legitimate. > --- > src/sort.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/sort.c b/src/sort.c > index 3380be6..e6658

Re: [PATCH] sort: fix two race conditions reported by valgrind.

2014-01-13 Thread Pádraig Brady
On 01/14/2014 12:49 AM, Shayan Pooya wrote: > > > > On Mon, Jan 13, 2014 at 7:31 PM, Pádraig Brady <mailto:p...@draigbrady.com>> wrote: > > On 01/14/2014 12:22 AM, Shayan Pooya wrote: > > Valgrind reported two race conditions when I ran sort on a smal

Re: [PATCH] sort: fix two race conditions reported by valgrind.

2014-01-13 Thread Pádraig Brady
On 01/14/2014 02:08 AM, Pádraig Brady wrote: > On 01/14/2014 12:49 AM, Shayan Pooya wrote: >> >> >> >> On Mon, Jan 13, 2014 at 7:31 PM, Pádraig Brady > <mailto:p...@draigbrady.com>> wrote: >> >> On 01/14/2014 12:22 AM, Shayan Pooya wrote: &g

Re: add --color option to md5sum and shaXsum

2014-01-14 Thread Pádraig Brady
On 12/25/2013 01:00 PM, Florent Monnier wrote: > 2013/12/24, Pádraig Brady wrote: >> On 12/24/2013 12:25 PM, Florent Monnier wrote: >>> Hello, >>> >>> This patch adds a --color option to the commands md5sum and shaXsum. >>> The goal is to make it

[PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-14 Thread Pádraig Brady
I noticed this uclibc build issue mentioned at: http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/73294 I sent a separate patch to gnulib to fix the direct issue there, however I was surprised that we were using the spawn-pipe module at all. It seems since coreutils 8.16 we've pulled in

Re: comm Command for Large File

2014-01-14 Thread Pádraig Brady
On 01/14/2014 10:15 PM, jayanthi radhakrishnan wrote: > Hi , > >We have a problem that our comm command in Solaris is not Large File aware > ( File size larger than 2 GB). > Does your comm command support Large File? > I mean whether it can compare 2 files which are larger than 2 GB in Size

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-15 Thread Pádraig Brady
On 01/14/2014 06:46 PM, Pádraig Brady wrote: > I noticed this uclibc build issue mentioned at: > http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/73294 > > I sent a separate patch to gnulib to fix the direct issue there, > however I was surprised that we were using the sp

Re: comm Command for Large File

2014-01-15 Thread Pádraig Brady
On 01/16/2014 12:17 AM, jayanthi radhakrishnan wrote: > Thanks Padraig. > Where can i find the source code for comm command? > Also , do you have any instructions on where to download the gcc and how to > install on windows / Solaris? For solaris you should be able to download the latest (8.22) c

Re: Why "id -Z" get the current process security context but says "of the current user" in help?

2014-01-15 Thread Pádraig Brady
On 01/16/2014 01:50 AM, Yang Chengwei wrote: > Hi List, > > I found that both id manpage and its help info says something about > security context like: > > -Z, --context print only the security context of the current user\n\ > > As it said, it gets the security context of *the current user*.

Re: [PATCH 6/6] doc: fix alignment

2014-01-16 Thread Pádraig Brady
On 01/16/2014 04:44 AM, Chengwei Yang wrote: > --- > doc/coreutils.texi |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/coreutils.texi b/doc/coreutils.texi > index e9cd55a..b823553 100644 > --- a/doc/coreutils.texi > +++ b/doc/coreutils.texi > @@ -189,7 +189,7 @@ F

Re: [PATCH 0/6] Doc: correct for commands which support SELinux and SMACK

2014-01-16 Thread Pádraig Brady
On 01/16/2014 04:44 AM, Chengwei Yang wrote: > This is a patchset, all about document of commands which support SELinux and > SMACK both. > > With an inspiration by "Why 'id -Z' says security context of the *current > process* rather than as its document says of the *current user*" > > Discussed

Re: Why "id -Z" get the current process security context but says "of the current user" in help?

2014-01-16 Thread Pádraig Brady
On 01/16/2014 06:24 AM, Jarkko Sakkinen wrote: > Hi > > On Thu, Jan 16, 2014 at 02:16:28AM +, Pádraig Brady wrote: >> So I suppose we might change the --help docs etc. to say >> _process_ rather than _user_. Is SMACK64EXEC a common >> label to have set on the id

Re: [PATCH 1/6] id: correct document about its security context option

2014-01-16 Thread Pádraig Brady
On 01/16/2014 04:44 AM, Chengwei Yang wrote: > In both SELinux and SMACK environment, 'id -Z' says about the security > context of the current process, the id process, rather than the security > context of the current user. > --- > doc/coreutils.texi |2 +- > src/id.c |2 +- > 2

Re: [PATCH 2/6] ls: correct document about its security context label

2014-01-16 Thread Pádraig Brady
On 01/16/2014 04:44 AM, Chengwei Yang wrote: > The implementation is, "." following the file permission mode bits > indicates both SELinux and SMACK access method, so fix the document. > > Also in its help info, so the manpage generated from help into. > --- a/src/ls.c > +++ b/src/ls.c > @@ -4886

Re: [PATCH 1/6] id: correct document about its security context option

2014-01-16 Thread Pádraig Brady
On 01/17/2014 12:12 AM, Yang Chengwei wrote: > On Thu, Jan 16, 2014 at 12:17:56PM +0000, Pádraig Brady wrote: >> On 01/16/2014 04:44 AM, Chengwei Yang wrote: >>> In both SELinux and SMACK environment, 'id -Z' says about the security >>> context of the current

Re: ln -s A B fails if symlink B exists and its value is too long

2014-01-16 Thread Pádraig Brady
On 12/27/2013 12:35 PM, Pádraig Brady wrote: > On 12/27/2013 12:31 PM, Pádraig Brady wrote: >> This is a bug and happens when ln tries to determine of the last arg is a >> directory. >> It does a stat(2) which gives this error. ENOENT is specifically ignored, >>

Re: Does sort -2,3n work properly?

2014-01-17 Thread Pádraig Brady
On 01/17/2014 10:37 AM, Bartosz Gołaszewski wrote: > Hi, > > for the following input: > 42 1 3 woot > 42 1 010 zoology > egg 1 2 papyrus > 7 3 42 soup > 999 3 0 algebra > > this is what debug-enabled sort in coreutil

Re: ln -s A B fails if symlink B exists and its value is too long

2014-01-17 Thread Pádraig Brady
On 01/17/2014 07:23 AM, Bernhard Voelker wrote: > On 01/17/2014 05:03 AM, Pádraig Brady wrote: >> I'll push the attached soon to fix this. > > Thanks. > >> From 672b0b5f1023f7f433973edec7376fce330cb2a2 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?P=C3=A1draig=2

Re: [PATCH 0/6] Doc: correct for commands which support SELinux and SMACK

2014-01-17 Thread Pádraig Brady
Pushed at http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=6fab28dc thanks, Pádraig.

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-17 Thread Pádraig Brady
pushed: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=f18999b4 thanks, Pádraig.

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-17 Thread Pádraig Brady
On 01/17/2014 04:44 PM, Pádraig Brady wrote: > pushed: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=f18999b4 Which wasn't complete so I followed up with: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=9a115f3e2 thanks, Pádraig.

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-19 Thread Pádraig Brady
On 01/19/2014 09:33 AM, Baruch Siach wrote: > I see this patch now in git. But this patch alone, even when combined with > the > following one (9a115f3e24), doesn't fix the build when applied on top of 8.21 > (the current Buildroot version). Is there anything missing? Should I rerun > ./bootstr

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-20 Thread Pádraig Brady
On 01/20/2014 08:53 AM, Baruch Siach wrote: > Hi Pádraig, > > On Sun, Jan 19, 2014 at 11:46:18AM +, Pádraig Brady wrote: >> On 01/19/2014 09:33 AM, Baruch Siach wrote: >>> I see this patch now in git. But this patch alone, even when combined with >>> t

Re: [PATCH] build: avoid unneeded spawn-pipe gnulib module

2014-01-20 Thread Pádraig Brady
On 01/20/2014 10:04 AM, Baruch Siach wrote: > Hi Pádraig, > On Mon, Jan 20, 2014 at 09:38:38AM +, Pádraig Brady wrote: >> On 01/20/2014 08:53 AM, Baruch Siach wrote: >>> On Sun, Jan 19, 2014 at 11:46:18AM +, Pádraig Brady wrote: >>>> On 01/19/2014 09:33 AM

Re: SELinux enabled despite --without-selinux?

2014-01-21 Thread Pádraig Brady
On 01/21/2014 09:24 AM, Bernhard Voelker wrote: > In a git working tree (v8.22-15-g9a115f3): > > $ git clean -xdfq > $ ./bootstrap > ... > $ ./configure --quiet --without-selinux > configure: WARNING: SELinux enabled, but matchpathcon_init_prefix not found > configure: WARNING: The ins

Re: [PATCH] sort: fix two race conditions reported by valgrind.

2014-01-22 Thread Pádraig Brady
On 01/14/2014 02:40 AM, Shayan Pooya wrote: >> valgrind is not flagging the above for me? > > valgrind 3.9 on Fedora 20 did not report this issues for me either. However, > the same version of valgrind reported this issue on a CentOS 6.5. > > >> I'm not sure how this deinit code might cause an

Re: making a file sparse - in-place?

2014-01-23 Thread Pádraig Brady
On 01/24/2014 12:47 AM, Bernhard Voelker wrote: > Inspired by a recent post on util-linux ML [1], talking about turning > a file into a sparse file in-place, i.e. not using a 2-step approach > like `cp --sparse file file2 && mv file2 file`), I thought, hey, don't > we have this in coreutils already

Re: sort/uniq/join: key-comparison code consolidation

2014-01-23 Thread Pádraig Brady
On 01/24/2014 12:50 AM, Assaf Gordon wrote: > Hello, > > If there is still interest, here's an updated patch, against the latest > version, of adding these features to join+uniq: > > http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html > > The patch has been re-created (not just re

Re: making a file sparse - in-place?

2014-01-23 Thread Pádraig Brady
On 01/24/2014 02:41 AM, Rodrigo Campos wrote: > On Fri, Jan 24, 2014 at 01:07:21AM +0000, Pádraig Brady wrote: >> On 01/24/2014 12:47 AM, Bernhard Voelker wrote: >>> Inspired by a recent post on util-linux ML [1], talking about turning >>> a file into a sparse file i

Re: making a file sparse - in-place?

2014-01-23 Thread Pádraig Brady
On 01/24/2014 03:12 AM, Rodrigo Campos wrote: > On Fri, Jan 24, 2014 at 02:59:41AM +0000, Pádraig Brady wrote: >> On 01/24/2014 02:41 AM, Rodrigo Campos wrote: >>> On Fri, Jan 24, 2014 at 01:07:21AM +0000, Pádraig Brady wrote: >>>> On 01/24/2014 12:47 AM, Bernhard Vo

Re: making a file sparse - in-place?

2014-01-24 Thread Pádraig Brady
On 01/24/2014 03:56 AM, Rodrigo Campos wrote: > On Fri, Jan 24, 2014 at 03:30:20AM +0000, Pádraig Brady wrote: >> On 01/24/2014 03:12 AM, Rodrigo Campos wrote: >>> On Fri, Jan 24, 2014 at 02:59:41AM +0000, Pádraig Brady wrote: >>>> On 01/24/2014 02:41 AM, Rodrigo Camp

Re: script suggestion: 'check_program' to easily run multiple tests

2014-01-24 Thread Pádraig Brady
On 01/24/2014 07:05 PM, Assaf Gordon wrote: > Hello, > > Attached is a small script I've been using. > It helps running multiple tests for a given program. > > example: > ./scripts/check_program sort > > Will find all sort-related tests (based on filename) and run them. > Adding "-e" or "-v" a

Re: du -s excluding size from directory entries?

2014-01-24 Thread Pádraig Brady
On 01/24/2014 08:41 PM, Aaron Davies wrote: > would people be interested in a patch implementing this? it's about a > dozen lines to add (~60 line patch). > > On Sat, Apr 13, 2013 at 2:15 AM, Pádraig Brady wrote: >> On 04/13/2013 08:22 AM, Aaron Davies wrote: >>>

Re: script suggestion: 'check_program' to easily run multiple tests

2014-01-24 Thread Pádraig Brady
On 01/24/2014 10:39 PM, Bernhard Voelker wrote: > On 01/24/2014 08:36 PM, Pádraig Brady wrote: >> The most common use I have for that is: ./make --test tests/misc/test-name.sh > > Hmm, I'd just run > make check TESTS=tests/misc/test-name.sh SUBDIRS=. > in that case. &

Re: du -s excluding size from directory entries?

2014-01-24 Thread Pádraig Brady
On 01/25/2014 04:25 AM, Aaron Davies wrote: >> On Jan 24, 2014, at 3:40 PM, Pádraig Brady wrote: >> >>> On 01/24/2014 08:41 PM, Aaron Davies wrote: >>> would people be interested in a patch implementing this? it's about a >>> dozen lines to add (~60 lin

[PATCH] head,tail: consistently diagnose write errors

2014-01-29 Thread Pádraig Brady
If we can't output more data, we should immediately diagnose the issue and exit rather than consuming all of input (in some cases). * src/tail.c (xwrite_stdout): Also diagnose the case where only some data is written. * src/head.c (xwrite_stdout): Copy this new function from tail, and use it to wr

Re: [PATCH] head,tail: consistently diagnose write errors

2014-01-29 Thread Pádraig Brady
On 01/29/2014 12:06 PM, Pádraig Brady wrote: > --- a/NEWS > +++ b/NEWS > + tail now diagnoses all failures when writing to stdout. Previously write > + errors could have been silently ignored if some data was output. > + [This bug was present in "the beginning".]

Re: [PATCH] head,tail: consistently diagnose write errors

2014-01-29 Thread Pádraig Brady
On 01/29/2014 11:12 PM, Bernhard Voelker wrote: > On 01/30/2014 12:02 AM, Bernhard Voelker wrote: >> On 01/29/2014 07:43 PM, Pádraig Brady wrote: >>> On 01/29/2014 12:06 PM, Pádraig Brady wrote: >>> >>>> --- a/NEWS >>>> +++ b/NEWS >>> &g

Re: dircolours: customise color of directory with full permissions

2014-01-30 Thread Pádraig Brady
On 01/30/2014 12:40 PM, Miguel Guedes wrote: > How can I configure the colour of a directory that has full permissions in > .dircolors? (777) I find a directory with full permissions very hard to read > in the terminal and would like to change its foreground or perhaps background > colour. > >

Re: Is --check-order the default of comm?

2014-02-01 Thread Pádraig Brady
On 02/01/2014 07:17 PM, Peng Yu wrote: > Hi, > > It seems that --check-order is the default of comm. But I don't find > this documented in man. Could anybody confirm whether this is the case > and help document it? Thanks. > The default operation is something different. From the info documentati

Re: [PATCH] ls: adding --zero/-z option, including tests

2014-02-03 Thread Pádraig Brady
On 02/03/2014 03:15 PM, Anthon van der Neut wrote: > | > A recent Q&A thread on unix.stackexchange.com on the reason why ls has no > option > like find to generate NUL separated output triggered the making of this patch. > ( http://unix.stackexchange.com/q/112125/33055 ). > > Quite often question

Re: [PATCH] head,tail: consistently diagnose write errors

2014-02-09 Thread Pádraig Brady
On 01/31/2014 12:30 AM, Bernhard Voelker wrote: > On 01/30/2014 01:23 AM, Pádraig Brady wrote: >>> Unfortunately, the atexit code now produces a second error diagnostic. >>> It doesn't hurt, but it looks a bit ugly. >> >> We discussed that foible previously,

Re: dd for failing discs?

2014-02-12 Thread Pádraig Brady
On 02/12/2014 08:08 AM, Bernhard Voelker wrote: > In various mailing list threads about failing discs like [1], > the advices for trying to rescue as much data as possible > always mention gnu_ddrescue, ddrescue or dd_rescue, and > often claim that plain dd is a bad choice (not in this > case). >

Re: Throttle option for GNU cp

2014-02-25 Thread Pádraig Brady
On 02/25/2014 11:39 AM, Chris Jack wrote: > I've been doing some large copies using cp and sometimes annoying the sys > admins around here by using large amounts of network bandwidth. nice does not > make any significant impact especially as I'm often running cp on a PC with > nothing much else

Re: feature enhancement for 'timeout'

2014-02-25 Thread Pádraig Brady
On 02/25/2014 04:10 PM, Thomas Sattler wrote: > Hi there ... > > How about exporting the DURATION > to the command's environment? So you mean for timeout(1) to inspect the env and honor a DURATION there? Generally we try to avoid having the environment as another configuration vector, especially

Re: feature enhancement for 'timeout'

2014-02-25 Thread Pádraig Brady
On 02/25/2014 04:57 PM, Thomas Sattler wrote: > Am 25.02.2014 17:30, schrieb Pádraig Brady: >> On 02/25/2014 04:10 PM, Thomas Sattler wrote: >>> How about exporting the DURATION to the command's environment? >> >> So you mean for timeout(1) to inspect the env and

Re: feature enhancement for 'timeout'

2014-02-25 Thread Pádraig Brady
On 02/25/2014 09:51 PM, Thomas Sattler wrote: > Am 25.02.2014 18:04, schrieb Pádraig Brady: >> On 02/25/2014 04:57 PM, Thomas Sattler wrote: >>> Am 25.02.2014 17:30, schrieb Pádraig Brady: >>>> On 02/25/2014 04:10 PM, Thomas Sattler wrote: >>>>> How

Re: dd for failing discs?

2014-02-25 Thread Pádraig Brady
On 02/25/2014 05:56 PM, Bernhard Voelker wrote: > re-adding the ML. > > On 02/18/2014 07:43 AM, Bernhard Voelker wrote: >> On 02/17/2014 01:46 PM, Pádraig Brady wrote: >>> On 02/14/2014 01:55 AM, Bernhard Voelker wrote: >>>> Can short read

Re: [PATCH] shuf: convert error diagnostic to lowercase

2014-02-26 Thread Pádraig Brady
On 02/26/2014 07:36 AM, Bernhard Voelker wrote: > * src/shuf.c (main): s/No/no/, introduced by commit g9f60f37. I adjusted the commit reference slightly, and also included an adjustment to NEWS to make it clear that this was not a regression. I'll push the attached if you're ok with it. thanks,

Re: chroot's userspec option

2014-02-27 Thread Pádraig Brady
On 02/27/2014 03:48 PM, Ken Werner wrote: > Hi, > > I noticed when using chroot's --userspec option the Gnulib's parse_user_spec > function gets called that leads the glibc to dlopen libnss_compat.so.2 > (probably getpwnam() that triggers the libc's NSS mechanism). Since > parse_user_spec is ca

Re: chroot's userspec option

2014-02-28 Thread Pádraig Brady
On 02/28/2014 10:34 AM, Ken Werner wrote: > On 02/27/2014 05:45 PM, Pádraig Brady wrote: >> On 02/27/2014 03:48 PM, Ken Werner wrote: >>> Hi, >>> >>> I noticed when using chroot's --userspec option the Gnulib's >>> parse_user_s

Re: chroot's userspec option

2014-03-01 Thread Pádraig Brady
On 03/01/2014 08:21 AM, Ken Werner wrote: > I would have thought in case numerid IDs are specified there's no need to > perform any outside nor inside lookup. > When prefixing the IDs using '+' the chroot utility just uses the provided > numbers for the setuid/setgid calls - that's fine as it is.

Re: uniq --check-fields=N

2014-03-03 Thread Pádraig Brady
On 03/03/2014 08:54 AM, Jonathan Sambrook wrote: > Hi, > > The 'uniq' command has: > > -f, --skip-fields=N avoid comparing the first N fields > -s, --skip-chars=Navoid comparing the first N characters > > and: > > -w, --check-chars=N compare no more than N characters in lines > >

coreutils release plans

2014-03-03 Thread Pádraig Brady
So coreutils-8.23 is shaping up to be a bug fix release which I hope could be released within 3-4 weeks. There are a few outstanding items including various df fixes and sort multithreaded fixups to include. We should concentrate on any of the outstanding non feature bugs in this time. After that

Re: coreutils release plans

2014-03-03 Thread Pádraig Brady
On 03/03/2014 09:55 AM, Ondrej Vasik wrote: > On Mon, 2014-03-03 at 09:11 +0000, Pádraig Brady wrote: >> So coreutils-8.23 is shaping up to be a bug fix release >> which I hope could be released within 3-4 weeks. >> There are a few outstanding items including various

Re: coreutils release plans

2014-03-03 Thread Pádraig Brady
On 03/03/2014 11:12 AM, Bernhard Voelker wrote: > On 03/03/2014 10:11 AM, Pádraig Brady wrote: >> So coreutils-8.23 is shaping up to be a bug fix release >> which I hope could be released within 3-4 weeks. >> There are a few outstanding items including various df fixes >

Re: Question on 'date' command: why UTC_sign_number_ is inverted?

2014-03-08 Thread Pádraig Brady
On 03/08/2014 08:49 AM, Masataro Asai wrote: > Hi, everyone. > > I'm confused by the behavior in the `date` command. > >> [guicho coreutils]$ TZ='Asia/Tokyo' src/date -R --date="2014/1/1" >> Wed, 01 Jan 2014 00:00:00 +0900 >> [guicho coreutils]$ TZ='UTC+9' src/date -R --date="2014/1/1" >> Wed, 01

Re: sync man page in coreutils and man-pages

2014-03-10 Thread Pádraig Brady
On 03/10/2014 12:10 PM, Christoph Hellwig wrote: > On Mon, Mar 10, 2014 at 01:03:41PM +0100, Michael Kerrisk (man-pages) wrote: >>The kernel keeps data in memory to avoid doing (relatively >>slow) disk reads and writes. This improves performance, but if >>the computer

Re: csplit feature request: allow a user to specify which pieces to output

2014-03-12 Thread Pádraig Brady
On 03/12/2014 04:26 AM, Hong Yang wrote: > If a user is splitting a large file into pieces only to use several of them, > it will be efficient to just specify the indexes of files to output. > > Take an extreme case for example. "a_large_file" has 12823371193 lines. > "csplit a_large_file 823371

[PATCH] chroot: always diagnose failure to set supplemental groups

2014-03-12 Thread Pádraig Brady
* src/chroot.c (setgroups): Change this replacement to fail when called so that platforms like Interix without support for supplemental groups don't silently ignore a --groups option. --- src/chroot.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/chroot.c b/src

Re: chroot's userspec option

2014-03-12 Thread Pádraig Brady
On 02/28/2014 01:27 PM, Pádraig Brady wrote: > On 02/28/2014 10:34 AM, Ken Werner wrote: >> On 02/27/2014 05:45 PM, Pádraig Brady wrote: >>> On 02/27/2014 03:48 PM, Ken Werner wrote: >>>> Hi, >>>> >>>> I noticed when using chroot's --users

Re: chroot's userspec option

2014-03-13 Thread Pádraig Brady
On 03/13/2014 07:37 AM, Bernhard Voelker wrote: > On 03/13/2014 02:47 AM, Pádraig Brady wrote: >> Proposed patch is attached. > > The patch looks good to me, but I think that whole "out-then-inside" > thing should be mentioned in the texinfo manual. > > Additio

Re: chroot's userspec option

2014-03-13 Thread Pádraig Brady
On 03/13/2014 01:15 PM, Bernhard Voelker wrote: > I'm no expert in this, but the different kind of uses of > of "lookup" vs. "look up" vs. "look-up" does not look consistent > (well, a "DNS lookup" and the lookup() function are fixed terms): > > $ grep 'look[- ]*up' doc/coreutils.texi \ >

Re: [PATCH] stat: port birthtime to Solaris 11

2014-03-18 Thread Pádraig Brady
I see you've pushed this already. The code looks good thanks. In future we might refactor to gnulib. Pádraig.

Re: [PATCH] chroot: always diagnose failure to set supplemental groups

2014-03-18 Thread Pádraig Brady
On 03/13/2014 01:47 AM, Pádraig Brady wrote: > * src/chroot.c (setgroups): Change this replacement to > fail when called so that platforms like Interix without support for > supplemental groups don't silently ignore a --groups option. > --- > src/chroot.c |7 +++ &

Re: Split Flushing to filter command

2014-03-20 Thread Pádraig Brady
On 03/20/2014 02:39 AM, Eldon wrote: > Hello all, > I am attempting the following in a bash shell on a 3.8.13 linux kernel: > sudo tcpdump -nn > |grep --line-buffered NTPv2 > |split -u --lines=10 --filter=date > > Clearly date would be replaced with some more useful script, but for the >

Re: [PATCH 00/33] [RFC] Non disruptive application core dump infrastructure

2014-03-20 Thread Pádraig Brady
On 03/20/2014 09:39 AM, Janani Venkataraman wrote: > Hi all, > > The following series implements an infrastructure for capturing the core of an > application without disrupting its process. > > Kernel Space Approach: > > 1) Posted an RFD to LKML explaining the various kernel-methods being analys

Re: Split Flushing to filter command

2014-03-21 Thread Pádraig Brady
On 03/20/2014 10:11 AM, Pádraig Brady wrote: > On 03/20/2014 02:39 AM, Eldon wrote: >> Hello all, >> I am attempting the following in a bash shell on a 3.8.13 linux kernel: >> sudo tcpdump -nn >> |grep --line-buffered NTPv2 >> |split -u --lines=10 --fil

Re: Split Flushing to filter command

2014-03-21 Thread Pádraig Brady
On 03/21/2014 03:13 PM, Bernhard Voelker wrote: > On 03/21/2014 01:49 PM, Pádraig Brady wrote: >> * src/split.c (lines_split): s/full_read/safe_read/. > > Interestingly, that bug has been introduced with commit > > http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=2

Re: Atomic update of destination in cp and install

2014-03-23 Thread Pádraig Brady
On 03/23/2014 10:47 AM, Markus Kuhn wrote: > It appears the coreutils "install" tool makes no effort to update > the destination file atomically. In other words, "install" is > currently not a safe tool to update an existing file if the > destination might be in use concurrently. > > A destination

Re: Using storage offloading capabilities

2014-03-25 Thread Pádraig Brady
On 03/24/2014 02:24 PM, Federico Simoncelli wrote: > Hi everyone, > I am evaluating the possibility to add some storage offloading > capabilities to existing utilities. > For example I'd be interested in leveraging WRITE SAME and EXTENDED > COPY scsi commands to initialize and copy data on iscsi/f

Re: [PATCH] basename: mention that the -s option implies -a in usage

2014-03-26 Thread Pádraig Brady
On 03/25/2014 10:41 PM, Bernhard Voelker wrote: > * src/basename.c (usage): Mention that -s implies -a. > (main): Add "fall through" comment to case 's'. > > Spotted by coverity: MISSING_BREAK. > --- > src/basename.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/

Re: [PATCH] ptx: avoid --format long option falling through into --help

2014-03-26 Thread Pádraig Brady
>>From dfa2279a955b9cdd6f941ae2eb05bd527081941f Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker > Date: Wed, 26 Mar 2014 09:01:36 +0100 > Subject: [PATCH] ptx: avoid --format long option falling through into --help > > * src/ptx.c (main): Add a 'break' after the --format handling case. > Otherw

bug#17103: regression: cp -al doesn't copy symlinks, but tries to link to them (fail)

2014-03-27 Thread Pádraig Brady
On 03/27/2014 02:10 PM, Linda Walsh wrote: > But those are separate for how cp should behave on filesystems with varying, > "assumed" capabilities...(i.e. failing because one can't link to a symlink > when linking to symlinks isn't a requirement for this to be allowed on > systems that don't suppor

Re: SCP Recursive Flag

2014-03-27 Thread Pádraig Brady
On 03/27/2014 02:24 PM, Colton Peltier wrote: > Hi, > > While working with some coworkers recently we noticed a strange inconsistency > between cp and scp, that caused us some confusion. For the cp tool a -r or -R > will do a recursive copy of directories, but for scp only -r will. The -R > fla

Re: New feature for 'wc': Filter lines by character count

2014-04-03 Thread Pádraig Brady
On 04/03/2014 03:29 PM, SAeeD wrote: > Hello, > > I was parsing a log file some days ago, and it had about 1,600,000 lines. All > lines in that log file were supposed to have a fix length of say, 140 > characters. Because of some noises on RS232 cable, some lines had fewer or > much characters

[PATCH] shred: overwrite inode storage used by some file systems

2014-04-04 Thread Pádraig Brady
Paul reminded me that for small files, their storage might be completely within an inode. Now that would not be cleared if one was writing a full block, which shred does by default. Now that full block write to clear the slack space at the end of a file is useful, especially is used in a consisten

Re: [PATCH] shred: overwrite inode storage used by some file systems

2014-04-04 Thread Pádraig Brady
On 04/04/2014 06:49 PM, Paul Eggert wrote: >> + else if (S_ISREG (st.st_mode)) >> +{ >> + off_t fsize = st.st_size; >> + if (fsize > 0 && fsize < ST_BLKSIZE (st) && size > fsize) >> +i_size = fsize; >> +} > > This can be simplified. There's no need to worry about checki

[PATCH] maint: various cleanups

2014-04-04 Thread Pádraig Brady
* tests/misc/numfmt.pl: Fix comment misspelling. * src/cut.c: Likewise. * src/tsort.c (detect_loop): Replace an fprintf() with error(). --- src/cut.c|2 +- src/tsort.c |3 +-- tests/misc/numfmt.pl |2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] maint: document timeout --preserve-status in v8.21 NEWS

2014-04-09 Thread Pádraig Brady
* NEWS: Add the omitted new feature. * cfk.mk (old_NEWS_hash): Adjust accordingly. --- NEWS |3 +++ cfg.mk |2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index 0a48456..1d3ecf1 100644 --- a/NEWS +++ b/NEWS @@ -230,6 +230,9 @@ GNU coreutils NEWS

[PATCH] maint: avoid static analysis warnings in ln.c

2014-04-10 Thread Pádraig Brady
* src/ln.c (do_link): It's not obvious that record_file() is a noop in the symlink case (in that case dest_set is NULL and so ignored). So to make it obvious, and to avoid false positives seen in coverity, add the explicit condition here. --- src/ln.c |3 ++- 1 files changed, 2 insertions(+),

Re: Strange hole creation behavior

2014-04-11 Thread Pádraig Brady
On 04/11/2014 09:43 PM, Brian Foster wrote: > On Fri, Apr 11, 2014 at 06:13:59PM +0100, Pádraig Brady wrote: >> So this coreutils test is failing on XFS: >> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=tests/dd/sparse.sh;h=06efc7017 >> Specifically the last

Re: wish: chmod -R to handle directories and files differently

2014-04-15 Thread Pádraig Brady
On 04/15/2014 12:43 PM, Richard Neill wrote: > Typical use-cases: > > (a) I have several nested directories of photos that originated from a > digital camera with a FAT filesystem. Therefore all the directories, > subdirectories and files are mode 777. I want to remove the executable > permiss

Re: [PATCH] df: use proper pointer size for xnrealloc

2014-04-16 Thread Pádraig Brady
On 04/15/2014 10:06 PM, Bernhard Voelker wrote: > * src/df.c (alloc_table_row): Use the size of char** to enlarge > the table. Spotted by Coverity. > --- > src/df.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/df.c b/src/df.c > index 3036c74..e763943 100644 > ---

[PATCH] doc: disambiguate chmod man page reference to (a) users

2014-04-16 Thread Pádraig Brady
* man/chmod.x: Don't rely on the bold markup for 'a' to distinguish it as that's not done in all cases. --- man/chmod.x |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/chmod.x b/man/chmod.x index 190191f..f26d763 100644 --- a/man/chmod.x +++ b/man/chmod.x @@ -28,7 +28

Re: [PATCH] dircolors: add hurd and mach-gnu-color terminal types

2014-04-17 Thread Pádraig Brady
On 04/17/2014 05:43 PM, David Michael wrote: > * src/dircolors.hin: Add hurd and mach-gnu-color. > --- > > Hi, > > Current Hurd-based systems use these two terminal types which are > capable of displaying color. Can they be added to dircolors? > > Thanks. > > David > > src/dircolors.hin | 2

Re: [PATCH] dircolors: add hurd and mach-gnu-color terminal types

2014-04-17 Thread Pádraig Brady
On 04/17/2014 07:57 PM, David Michael wrote: > My understanding is that mach-color was replaced by mach-gnu-color in > Hurd around two years ago.[1][2] > > I left the definition for compatibility, as I'm not aware of whether > any non-GNU Mach systems use TERM=mach-color, and corresponding > defin

Re: New option for md5sum

2014-04-18 Thread Pádraig Brady
On 04/19/2014 12:51 AM, djcj wrote: > Can you add an option to md5sum that allows one to output only the checksum? > Here's a code example: Thanks for the patch. However this is one of those marginal cases where it's probably not worth the extra option to do this simple adjustment. At the shell y

<    3   4   5   6   7   8   9   10   11   12   >