Re: Should Test2 maintain $! and $@?

2016-01-18 Thread Aristotle Pagaltzis
* Chad Granum [2016-01-18 06:55]: > Which behavior do you want, preserve one, preserve all, preserve what > is requested in arguments? I didn’t consider that. I was thinking ->release would take an optional bool flag and that’s all. But you’re right that this would not be enough and that providin

Re: Should Test2 maintain $! and $@?

2016-01-18 Thread Chad Granum
So, new problem I have found based on the change to restoring $@, $!, and $?. perl-bleads ext/XS-APItest/t/svpeek.t has 2 test failures. One tests $! and it *looks like* it assumes something recently looked at $! from a string context: like (DPeek ($!), qr'^PVMG\("', '$!'); I can fix the test

Re: Should Test2 maintain $! and $@?

2016-01-18 Thread Chad Granum
Been talking about this in #p5p, so far it seems the problem is the test is fragile, and patching the test is fine. On Mon, Jan 18, 2016 at 1:13 PM, Chad Granum wrote: > So, new problem I have found based on the change to restoring $@, $!, and > $?. > > perl-bleads ext/XS-APItest/t/svpeek.t has