Re: [Crash-utility] [PATCH] extensions: remove trace.c and point to the new repository

2021-03-29 Thread Bhupesh Sharma
On Sun, 28 Mar 2021 at 07:18, lijiang wrote: > > 在 2021年03月26日 16:51, HAGIO KAZUHITO(萩尾 一仁) 写道: > > -Original Message- > >> 在 2021年03月26日 12:33, HAGIO KAZUHITO(萩尾 一仁) 写道: > >>> The trace.c extension module moved to the separate repository: > >>> https://github.com/fujitsu/crash-trace >

Re: [Crash-utility] [PATCH 1/2] crash-utility/arm64: rename ARM64_PAGE_OFFSET_ACTUAL as ARM64_FLIP_PAGE_OFFSET_ACTUAL

2021-03-29 Thread Bhupesh Sharma
Hi Pingfan, On Thu, 25 Mar 2021 at 08:37, Pingfan Liu wrote: > > Renaming, so it is better to reflect the flip layout of kernel VA, which > is introduced by kernel commit 14c127c957c1 ("arm64: mm: Flip kernel VA > space") > > Signed-off-by: Pingfan Liu > Cc: HAGIO KAZUHITO > Cc: Lianbo Jiang

Re: [Crash-utility] [PATCHv2] crash-utility/arm64: store phy_offset and memstart_addr separately

2021-03-29 Thread Bhupesh Sharma
Hi Pingfan, Thanks for the patch. Some comments below: On Thu, 25 Mar 2021 at 09:07, piliu wrote: > > > In case of making mistake due to my limited knowledge on arm64, I also > CC this patch to some guys from arm team. If any comment, please also > kindly give them. > > Thanks, > Pingfan > >

Re: [Crash-utility] [PATCH] arm64: add tag_ignore machdep option

2021-03-26 Thread Bhupesh Sharma
Hi Vinayak, On Fri, 26 Mar 2021 at 11:56, vinayak menon wrote: > > Hi Bhupesh, > > On Thu, Mar 25, 2021 at 11:15 PM Bhupesh Sharma > wrote: > > > > Hi Vinayak, > > > > Thanks for the patch. > > Some queries below: > > > > On Thu, 25

Re: [Crash-utility] [PATCH] arm64: add tag_ignore machdep option

2021-03-25 Thread Bhupesh Sharma
Hi Vinayak, Thanks for the patch. Some queries below: On Thu, 25 Mar 2021 at 20:08, Vinayak Menon wrote: > > Raw ramdumps without vmcoreinfo does not work currently > with pointer authentication or memory tagging enabled. > The arm capability array can be queried but that creates > a dependency

[Crash-utility] [PATCH] Fix machdep->HZ calculation for kernel versions > 2.6.0

2021-01-11 Thread Bhupesh Sharma
LK_TCK) value instead of the hardcoded HZ values depending on kernel versions. Cc: k-hagio...@nec.com Cc: liji...@redhat.com Cc: bhupesh.li...@gmail.com Signed-off-by: Bhupesh Sharma --- arm.c| 2 +- arm64.c | 2 +- ppc.c| 5 + ppc64.c | 6 ++ x86.c| 5 + x86_64.c | 5 +-

Re: [Crash-utility] [PATCH] memory_driver: Fix memory driver module build with Linux 5.4 and later

2020-11-08 Thread Bhupesh Sharma
SUBDIRS=${PWD} modules > clean: > rm -f *.mod.c *.ko *.o Module.* LGTM, so: Acked-by: Bhupesh Sharma Thanks. -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility

Re: [Crash-utility] [PATCH v2 1/1] Support cross-compilation

2020-11-05 Thread Bhupesh Sharma
On Wed, Oct 28, 2020 at 11:56 PM Alexander Egorenkov wrote: > > Bhupesh Sharma writes: > > > > > ifneq ($(CROSS_COMPILE),) > > SUBARCH := $(shell echo $(CROSS_COMPILE) | cut -d- -f1 | sed 's:^.*/::g') > > else > > SUBARCH := $(shell uname -m) > >

Re: [Crash-utility] [PATCH] Fix memory driver module build with kernel 5.8+

2020-11-05 Thread Bhupesh Sharma
thought the commit log would be enough.. > > Do you think we should not merge this as is? No problem. I only had some nitpicks. We can go ahead and apply the same for now - maybe later on if someone finds more time we can clean this up further. Feel free to add: Acked-by: Bhupesh Sharma Th

Re: [Crash-utility] Update gdb to 10.1

2020-10-28 Thread Bhupesh Sharma
Hi Alexey, On Wed, Oct 28, 2020 at 11:31 AM Alexey Makhalov wrote: > > Hi all, > > I’m thinking to update gdb to recent version. > Are there any concerns? > What should I know? Any dependencies which force us to stick to 7.6? > > The features I’m aiming are: > 1) `offset` support in

Re: [Crash-utility] [PATCH v2 1/1] Support cross-compilation

2020-10-12 Thread Bhupesh Sharma
Hello Alexander, Thanks for working on this. I did some work earlier on this after discussion with Dave Anderson, but unfortunately I could never queue it up for upstream consideration, due to lack of time. I have some suggestions below: On Sat, Oct 10, 2020 at 7:42 PM Alexander Egorenkov

Re: [Crash-utility] [PATCH] Fix memory driver module build with kernel 5.8+

2020-09-10 Thread Bhupesh Sharma
tatic struct file_operations crash_fops > .owner = THIS_MODULE, > .llseek = crash_llseek, > .read = crash_read, > +#ifdef CAN_WRITE_KERNEL > .write = crash_write, > +#endif > .unlocked_ioctl = crash_ioctl, > .open = crash_open, &

Re: [Crash-utility] [PATCH] crash-extension/gcore: fix the failure of invalid structure member offset

2020-08-28 Thread Bhupesh Sharma
Hi Lianbo, Please note that we still need to formulate a way to maintain crash-extension outside a tarball. I am preparing a RFC proposal and will share it shortly. On Fri, Aug 28, 2020 at 9:34 AM Lianbo Jiang wrote: > > With kernel commit: <577d5cd7e585> ("x86/ioperm: Move iobitmap data into >

Re: [Crash-utility] [PATCH 1/2] Makefile: Mention arm and arm64 as supported targets

2020-07-22 Thread Bhupesh Sharma
Hi Kazu, On Wed, Jul 22, 2020 at 1:02 PM HAGIO KAZUHITO(萩尾 一仁) wrote: > > Hi Bhupesh, > > sorry for the late response. > > > -Original Message- > > Update the Makefile comments to note that arm and arm64 > > are also supported build targets. >

Re: [Crash-utility] [PATCH 2/2] arm64: Change tcr_el1_t1sz variable name to TCR_EL1_T1SZ

2020-07-22 Thread Bhupesh Sharma
_el1_t1sz > > vmcoreinfo variable has been changed to TCR_EL1_T1SZ. > > > > Make a similar change in crash-utility. > > > > Signed-off-by: Bhupesh Sharma > > Acked-by: Kazuhito Hagio > > Thanks for your effort at those kernel patches! > Kazu > > &g

[Crash-utility] [PATCH] extensions: Upload crash-trace-command-2.0.tar.gz to github as well

2020-07-22 Thread Bhupesh Sharma
Although we have trace.c uploaded to crash-extensions github currently, several users (like RHEL/SUSE rpm packagers), prefer using crash-trace-*.tar.gz directly for rpm packaging, lets upload the same to github extensions as well. Signed-off-by: Bhupesh Sharma --- crash-trace-command-2.0.tar.gz

[Crash-utility] [PATCH 2/2] arm64: Change tcr_el1_t1sz variable name to TCR_EL1_T1SZ

2020-07-13 Thread Bhupesh Sharma
Since linux kernel commit bbdbc11804ff ("arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo") [available in linux-next now], the name of tcr_el1_t1sz vmcoreinfo variable has been changed to TCR_EL1_T1SZ. Make a similar change in crash-utility. Signed-off-by: Bhupesh Sharma --- arm

[Crash-utility] [PATCH 1/2] Makefile: Mention arm and arm64 as supported targets

2020-07-13 Thread Bhupesh Sharma
Update the Makefile comments to note that arm and arm64 are also supported build targets. Signed-off-by: Bhupesh Sharma --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 745541012f43..7062139e68bc 100644 --- a/Makefile +++ b/Makefile

Re: [Crash-utility] crash fails to load on ARM64 live kernel

2020-07-02 Thread Bhupesh Sharma
Hi Vijay, On Thu, Jul 2, 2020 at 8:33 AM Vijay Balakrishna wrote: > > Hello, > > We are seeing crash (7.2.8) failing on ARM64 live kernel. After filing > https://github.com/crash-utility/crash/issues/54 I learned about crash > utility discussion list >

Re: [Crash-utility] EXT: Re: EXT: Re: crash start in CentOS 8

2020-06-15 Thread Bhupesh Sharma
Hello Kazu, On Mon, Jun 15, 2020 at 8:38 PM HAGIO KAZUHITO(萩尾 一仁) wrote: > > -Original Message- > > > [root@lxkmg-pag-ale test64]# /usr/bin/crash -d 15 > > > System.map-4.18.0-147.el8.x86_64 vmlinux.debuginfo vmcore > ... > > > > > > read_diskdump: PAGE_EXCLUDED: paddr/pfn:

Re: [Crash-utility] EXT: Re: crash start in CentOS 8

2020-06-15 Thread Bhupesh Sharma
Hi Patrick, On Mon, Jun 15, 2020 at 12:51 PM Agrain Patrick wrote: > -Message d'origine- > De : crash-utility-boun...@redhat.com > [mailto:crash-utility-boun...@redhat.com] De la part de Bhupesh Sharma > Envoyé : lundi 15 juin 2020 09:13 > À : Discussion list for cras

Re: [Crash-utility] crash start in CentOS 8

2020-06-15 Thread Bhupesh Sharma
Hello Patrick, On Mon, Jun 15, 2020 at 12:28 PM Agrain Patrick wrote: > > Hello, > > > > I tried to test the crash utility from CentOS 8 with following requirements: > > First machine (VMware) on which CentOS 8 is installed and on which I > performed a fake crash using SysRq. After reboot, The

Re: [Crash-utility] [ANNOUNCE] My retirement, and crash utility maintainership changes

2020-05-07 Thread Bhupesh Sharma
On Thu, May 7, 2020 at 8:34 PM HAGIO KAZUHITO(萩尾 一仁) wrote: > > > > Dave, > > > > > > > Initially Kazuhito will primarily be handling upstream github duties, > > > > while Lianbo and Bhupesh will be handling Fedora, CentOS stream, and > > > > RHEL maintenance. All three will be involved in the

Re: [Crash-utility] ramdump support for va_bits_actual

2020-04-17 Thread Bhupesh Sharma
Hi Vinayak, On Fri, Apr 17, 2020 at 8:34 PM vinayak menon wrote: > > Hi Dave, > > Noticed that raw ramdumps of 5.4 kernel aren't working with crash tip. > With the patches attached, I could get it working. Please take a look. Can you share some details/message-logs of the issue you are seeing?

Re: [Crash-utility] crash on arm64

2020-01-06 Thread Bhupesh Sharma
Hello Poonam, I see Dave is already helping you with the issue. I saw a couple of interesting things and have a suggestion regarding the same (see in-line): On Mon, Jan 6, 2020 at 6:45 PM Poonam Aggrwal wrote: > > Hello > > I am getting the following error when I use crash on arm64 platform

Re: [Crash-utility] [PATCH][v2] Remove __exception_text_start and __exception_text_end for ARM64

2019-12-30 Thread Bhupesh Sharma
Hi Prabhakar, On Mon, Dec 30, 2019 at 9:55 AM Prabhakar Kushwaha wrote: > > Dear Bhupesh, > > On Tue, Dec 24, 2019 at 9:39 AM Prabhakar Kushwaha > wrote: > > > > On Tue, Dec 24, 2019 at 1:09 AM Bhupesh Sharma wrote: > > > > > > On Mon, Dec 23, 20

Re: [Crash-utility] [PATCH][v2] Remove __exception_text_start and __exception_text_end for ARM64

2019-12-23 Thread Bhupesh Sharma
On Mon, Dec 23, 2019 at 7:49 PM Prabhakar Kushwaha wrote: > > On Mon, Dec 23, 2019 at 7:32 PM Dave Anderson wrote: > > > > > > > > - Original Message - > > > __exception_text_start and __exception_text_end is used to group functions > > > and place according to linker script in such a

[Crash-utility] [PATCH] crash/arm64: Determine vabits_actual value from 'TCR_EL1.T1SZ' value in vmcoreinfo

2019-11-19 Thread Bhupesh Sharma
for determining the vabits_actual value. [0].http://lists.infradead.org/pipermail/kexec/2019-November/023962.html Cc: Dave Anderson Cc: AKASHI Takahiro Cc: Prabhakar Kushwaha Cc: crash-utility@redhat.com Signed-off-by: Bhupesh Sharma --- arm64.c | 13 +++-- 1 file changed, 11 insertions(+), 2

Re: [Crash-utility] arm64: doesn't work for kernel v5.4?

2019-10-02 Thread Bhupesh Sharma
Hi Akashi, On Thu, Oct 3, 2019 at 10:49 AM AKASHI Takahiro wrote: > > Hi Dave, > > I tried to use crash v7.2.7 with kernel v5.4-rc1 on arm64. > > 1. VA_BITS_ACTUAL is missing in vmcoreinfo. >Does anyone work on fixing it on kernel side? >(just adding one or two lines though) I am

Re: [Crash-utility] [PATCH] filesys: Skip 'vmlinux.o' while searching for vmlinux in 'find_booted_kernel()'

2018-02-28 Thread Bhupesh Sharma
/4.14.0/build/vmlinux.o >> >find_booted_kernel: found: /lib/modules/4.14.0/build/vmlinux.o >> > >> > 5. Now the problem happens due to following check inside >> >'find_booted_kernel()' function: >> > >> > if (mount_point(kernel) || >

Re: [Crash-utility] [PATCH] filesys: Skip 'vmlinux.o' while searching for vmlinux in 'find_booted_kernel()'

2018-02-28 Thread Bhupesh Sharma
unt'able, so the check in point 5 fails and we incorrectly >> accept this as the kernel being boot'ed, even though >> there was a 'vmlinux' present inside >> '/lib/modules//build'. >> >> 7. Now, later when crash tries to access symbols (like _stext) >> using this kern

[Crash-utility] [PATCH] filesys: Skip 'vmlinux.o' while searching for vmlinux in 'find_booted_kernel()'

2018-02-27 Thread Bhupesh Sharma
s the kernel file. After this fix, crash no longer errors out and we can use full functionality on the crash prompt. Signed-off-by: Bhupesh Sharma <bhsha...@redhat.com> --- filesys.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/filesys.c b/filesys

Re: [Crash-utility] [PATCH] crash/symbols: Error out earlier in case _stext_vmlinux is NULL or UNINITIALIZED

2018-02-27 Thread Bhupesh Sharma
m, we should be finding the vmlinux at the standard >> location, otherwise we should do proper error handling. >> >> So this patch errors out earlier, if we don't find a valid value for >> '_stext_vmlinux' and prompts the user to refer to the 'usage' >> banner. >&