Re: [cross-project-issues-dev] Problems with Simrel contributionre: org.eclipse.e4.ui.model.workbench

2017-03-11 Thread Ed Willink
Hi Chaotic major versions seem undesirable, so since the major version has not yet made it to +4 on any milestone it seems appropriate to revert it; preferably for M6, but certainly for M7. We aggregate to find inconsistencies. We found one, the platform was wrong, the platform should correc

Re: [cross-project-issues-dev] Problems with Simrel contributionre: org.eclipse.e4.ui.model.workbench

2017-03-11 Thread Daniel Megert
Thanks Tom! That was my thinking too. So, that class should be marked as @noimplement in the model, because next time, PDE Tools will again ask the developer to increment the major version. Unfortunately, at this point, reverting the major version increase seems to do more harm than having a f

Re: [cross-project-issues-dev] Problems with Simrel contribution re: org.eclipse.e4.ui.model.workbench

2017-03-11 Thread Tom Schindl
Under NO cricumstance this API is/has/should be implemented by clients! IIRC it should be called at by none e4 internals. So this version increase is just plain wrong! Tom (guy who was in charge of the model) Von meinem iPhone gesendet > Am 11.03.2017 um 16:22 schrieb Daniel Megert : > > You'

Re: [cross-project-issues-dev] Problems with Simrel contribution re: org.eclipse.e4.ui.model.workbench

2017-03-11 Thread Daniel Megert
You're right Ed. At least in the SDK there's no re-export of that bundle. Dani From: Ed Willink To: cross-project-issues-dev@eclipse.org Date: 11.03.2017 11:01 Subject:Re: [cross-project-issues-dev] Problems with Simrel contribution Sent by:cross-project-issues-dev-bou

Re: [cross-project-issues-dev] Problems with Simrel contribution

2017-03-11 Thread Ed Willink
Hi Correction. I misread the icons in the Plugin dependency view. Nothing in my workspace re-exports org.eclipse.e4.ui.model.workbench, so a major version change should be a simple MANIFEST.MF update for consumers. Regards Ed Willink On 11/03/2017 08:58, Ed Willink wrote: Hi O

Re: [cross-project-issues-dev] Problems with Simrel contribution

2017-03-11 Thread Quentin Le Menez
Hi, As far as Papyrus is concerned I pushed a patch yesterday and it should be merged soon. I will test if there are further version issues today and amend the patch if necessary. As I understood it papyrus contribution was deactivated and therefore the simrel could go on and did not therefore

Re: [cross-project-issues-dev] Problems with Simrel contribution

2017-03-11 Thread Daniel Megert
Hi Eike The reason for the increase is the addition of MUiFactory.createImperativeExpression(). I'm not convinced though that MUiFactory is intended to be implemented by clients (only then the major version needs to be increased). An e4 expert has to comment on that. Unfortunately, this chang

Re: [cross-project-issues-dev] Problems with Simrel contribution

2017-03-11 Thread Ed Willink
Hi On the one hand, this looks like the normal excitement that occurs when a plugin has a major version increase; every consumer must follow suit on its dependency bounds. However it is surprising that no announcement has been made, particularly so close to M6. On the other hand, there are m

Re: [cross-project-issues-dev] Problems with Simrel contribution

2017-03-11 Thread Eike Stepper
Hi, It appears that https://git.eclipse.org/r/#/c/88492/ incremented the major version of the org.eclipse.e4.ui.model.workbench plugin. There are some other commits in the context of https://bugs.eclipse.org/bugs/show_bug.cgi?id=484398 but none of them seems to justify a major version increment