Re: [crossfire] [PATCH 0/2] Work on keys.c and the keybinding system

2013-11-03 Thread Kevin Zheng
On 11/02/2013 18:21, Arvid Brodin wrote: I think we should still remove the functionality that allows one to rebind the modifier keys, for two reasons: * It doesn't seem to work. Try it out on rev 19089 - the bind is successful (when you press the bound key the corresponding Run/ Shift

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Kevin Zheng
On 11/03/2013 08:50, Arvid Brodin wrote: I see what you mean - suddenly there's a lot of noise in the keybindings dialog. What I did was to remove all bindings that I don't use, and it feels OK now. Perhaps that'll work for you as well? If you try it and still hate it, tell me and I'll see

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
On 2013-11-03 18:15, Arvid Brodin wrote: On 2013-11-03 16:50, Kevin Zheng wrote: On 11/03/2013 08:50, Arvid Brodin wrote: [] - 3 bindings of 'a' to apply (to handle different shift state and modifier states). Replace with a single binding of 'a' with Any flag. In hindsight, there

Re: [crossfire] [RFC 2/3] Misc keybinding fixes and changes

2013-11-03 Thread Mark Wedel
On 11/ 2/13 08:14 PM, Kevin Zheng wrote: On 11/02/2013 11:04, Arvid Brodin wrote: I noticed the gtk client code is split between the folders common/ and gtk-v2/. I found references to something called the x11 client in the code, and I assumed that that was an old client that had since been

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-03 Thread Mark Wedel
On 11/ 2/13 04:31 PM, Arvid Brodin wrote: Today, keybindings are saved as ~/.crossfire/keys. That means you cannot have different key bindings for each character. This patch changes that so that keybindings are saved as ~/.crossfire/character-name.keys. So if your character is named Leopold,

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Mark Wedel
On 11/ 3/13 06:50 AM, Arvid Brodin wrote: snip - How often do we get new players who use Sun Type 4 Keyboards? Perhaps these could go? (17 bindings.) Some of those still can apply for later sun keyboards (using a type 7 here). Since later keyboards are USB, they work fine on PCs also.

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-03 Thread Arvid Brodin
On 2013-11-03 20:36, Mark Wedel wrote: On 11/ 2/13 04:31 PM, Arvid Brodin wrote: Today, keybindings are saved as ~/.crossfire/keys. That means you cannot have different key bindings for each character. This patch changes that so that keybindings are saved as ~/.crossfire/character-name.keys.

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-03 Thread Kevin Zheng
On 11/03/2013 13:36, Mark Wedel wrote: Just a question - is there any way to set up 'global' keybindings (eg, those that apply to all characters)? This does seem useful. One possible idea to throw around is to make the key bindings window tabbed, one for per-character and one for global. If