Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-14 Thread Arvid Brodin
On 2013-11-07 01:11, Kevin Zheng wrote: > On 11/03/2013 11:15, Arvid Brodin wrote: >> Anyway, this needs to be expressed with two keybindings in my code: one with >> no >> modifiers (called "None" in the keybindings dialog), and one with the "Run" >&g

[crossfire] [PATCH] Fix keybinding bug when connected to server-1.12

2013-11-04 Thread Arvid Brodin
rvid >From 72b2d4af20da13b00753119ada19016c9209f6fa Mon Sep 17 00:00:00 2001 From: Arvid Brodin Date: Tue, 5 Nov 2013 00:15:14 +0100 Subject: [PATCH] Fix keybinding bug when connected to server-1.12. Signed-off-by: Arvid Brodin --- gtk-v2/src/account.c | 6 +- gtk-v2/src/create_char.c | 6 +- gtk-v2/src/gtk2p

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-04 Thread Arvid Brodin
On 2013-11-04 07:38, Mark Wedel wrote: > On 11/ 3/13 03:03 PM, Kevin Zheng wrote: >> On 11/03/2013 13:36, Mark Wedel wrote: >>> Just a question - is there any way to set up 'global' keybindings (eg, >>> those that apply to all characters)? >> >> This does seem useful. One possible idea to throw a

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-03 Thread Arvid Brodin
On 2013-11-03 20:36, Mark Wedel wrote: > On 11/ 2/13 04:31 PM, Arvid Brodin wrote: >> Today, keybindings are saved as ~/.crossfire/keys. That means you >> cannot have different key bindings for each character. >> >> This patch changes that so that keybindings are saved a

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
On 2013-11-03 18:15, Arvid Brodin wrote: > On 2013-11-03 16:50, Kevin Zheng wrote: >> On 11/03/2013 08:50, Arvid Brodin wrote: > > [] > >>> - 3 bindings of 'a' to "apply" (to handle different shift state and >>> modifier >>>

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
On 2013-11-03 16:50, Kevin Zheng wrote: > On 11/03/2013 08:50, Arvid Brodin wrote: [] >> - 3 bindings of 'a' to "apply" (to handle different shift state and modifier >> states). Replace with a single binding of 'a' with "Any" flag. &g

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
k. > On 11/02/2013 18:24, Arvid Brodin wrote: >> * Show all keybindings (incl default ones) in both 'unbind' and the >> keybindings >> dialog. (Should reduce confusion for new users.) > > I almost want to say that I miss the old behavior. If feasible, I

[crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-02 Thread Arvid Brodin
17 00:00:00 2001 From: Arvid Brodin Date: Mon, 28 Oct 2013 02:04:20 +0100 Subject: [PATCH 2/4] Added player character specific keybinding files. Signed-off-by: Arvid Brodin --- common/client.h | 13 ++-- common/metaserver.c | 4 -- gtk-v2/src/account.c | 5 ++ gtk-v2/

[crossfire] [PATCH 0/2] Work on keys.c and the keybinding system

2013-11-02 Thread Arvid Brodin
I have generated a new set of patches without the removal of the functionality to re-bind key modifiers, and with some minor improvements. Otherwise, they are the same as before. These apply on top of current svn repository (rev 19089). I think we should still remove the functionality that all

Re: [crossfire] [RFC 2/3] Misc keybinding fixes and changes

2013-11-02 Thread Arvid Brodin
On 2013-11-01 04:54, David Hurst wrote: > I'd be of the view, if it isn't reducing a functionality but > re-implementing it in a more useful way (be it more flexible, faster, > or any other good reason) then it has my support. This could better be described as removing an arcane feature to simplif

Re: [crossfire] [RFC 2/3] Misc keybinding fixes and changes

2013-10-30 Thread Arvid Brodin
27;9') { -cpl.count = cpl.count*10 + (key - '0'); +cpl.count = cpl.count * 10 + (key - '0'); if (cpl.count > 10) { cpl.count %= 10; } It all looks good to me! Also, patch #3 applies with just some offset on top of t

Re: [crossfire] [RFC 0/3] Work on keys.c and the keybinding system

2013-10-28 Thread Arvid Brodin
get reviewed and ultimately accepted anyway. > On 10/28/2013 18:09, Arvid Brodin wrote: >> I'm thinking that perhaps I should also change the flags in the keys file so >> that they conform with the modifier keys? Originally they were: >> >> [A]ll, [N]ormal, [F]ire,

[crossfire] [RFC 3/3] character-specific keybinding files

2013-10-28 Thread Arvid Brodin
As the Subject says. Also removes the weird MULTKEYS definition... Signed-off-by: Arvid Brodin --- common/client.h | 13 ++-- common/metaserver.c | 4 -- gtk-v2/src/account.c | 5 ++ gtk-v2/src/create_char.c | 4 ++ gtk-v2/src/gtk2proto.h | 1 + gtk-v2/src/keys.c

[crossfire] [RFC 0/3] Work on keys.c and the keybinding system

2013-10-28 Thread Arvid Brodin
Hi, This patch series is meant to make keybinding usage a lot more obvious - to new users especially, but hopefully also for the more experienced ones. Hopefully it also makes the keys.c file a bit more maintainable. In detail: * Coding style fixes (so that it is at least consistent in the keys.

Re: [crossfire] Key repeat and keybindings

2013-10-27 Thread Arvid Brodin
On 2013-10-26 08:21, Mark Wedel wrote: > On 10/25/13 04:59 PM, Arvid Brodin wrote: >> On 2013-10-24 07:19, Mark Wedel wrote: >>> On 10/23/13 06:53 PM, David Hurst wrote: >>>> Hi Arvid, >> >> Hi! >> [] >> For auto-repeating keys though, there

Re: [crossfire] Key repeat and keybindings

2013-10-25 Thread Arvid Brodin
On 2013-10-24 07:19, Mark Wedel wrote: > On 10/23/13 06:53 PM, David Hurst wrote: >> Hi Arvid, Hi! [] > > A lot of this has to down how keys are handled, at least on > x-windows. > > If you could down the control, shift, or other modifier keys, a > single event is generated - that the key has b

[crossfire] Key repeat and keybindings

2013-10-23 Thread Arvid Brodin
I recently started playing Crossfire (on a private server, together with my girlfriend, if you can believe it! :). It's a surprisingly addictive game! And we're slowly finding nice features like auto-pickup and -mapscale. So thanks! :) There are a few things that we are both annoyed with thoug