Re: [crossfire] Crossfire Plugin System v2.0

2005-10-17 Thread Yann Chachkoff
Le Samedi 15 Octobre 2005 20:34, Nicolas Weeger a écrit : > While we're at it :) > * could we use names more explicit that EVENT_GDEATH and EVENT_GKILL? > I'd say EVENT_PLAYER_DEATH and EVENT_KILL, less confusing > Agree - changed in my code. > * EVENT_GKILL takes *two* parameters (what was killed

Re: [crossfire] Crossfire Plugin System v2.0

2005-10-15 Thread Nicolas Weeger
While we're at it :) * could we use names more explicit that EVENT_GDEATH and EVENT_GKILL? I'd say EVENT_PLAYER_DEATH and EVENT_KILL, less confusing * EVENT_GKILL takes *two* parameters (what was killed and by who), only one is used in plugin. And parameters should be inverted imo, first what was k

Re: [crossfire] Crossfire Plugin System v2.0

2005-10-15 Thread Nicolas Weeger
Yeah for the rewrite! I haven't checked everything, but I did see previews, so my opinion is to commit, and fix things as issues arise. *gets his char* to const char* spell ready* :) As for breaking compatibility, it isn't too bad imo. As you say, not *that* many player-owned items with scripts,

[crossfire] Crossfire Plugin System v2.0

2005-10-15 Thread Yann Chachkoff
The small rewrite of the Crossfire Plugin subsystem is nearing completion - finally. I think that a couple of explanations are necessary. Why ? - The main reason to answer the "why a rewrite" is that the older way of managing plugins was simply too complex and obscure. Using the CFParm struc