LGTM.
From: Wang, Shiliu
Sent: Friday, June 13, 2014 12:55 PM
To: Liu, Shouqun; Christiansen, Kenneth R; Balestrieri, Francesco;
'crosswalk-dev@lists.crosswalk-project.org'
Subject: RE: Intent to implement - Embedding API v2 Part1
Hi, All
This is the first step of the original Embedding API v2
Hi, All
This is the first step of the original Embedding API v2 Intent to implement.
It's for expose some existing APIs from internal classes (XWalkClient and
XWalkWebChromeClient) by moving them to XWalkUIClient/XWalkResourceClient.
Because they were neither implemented within crosswalk core no
Missing one API to add to XWalkResourceClient
public boolean shouldOverrideUrlLoading(XWalkView view, String url)
Thanks,
Shiliu
From: Wang, Shiliu
Sent: Wednesday, June 11, 2014 9:24 AM
To: Liu, Shouqun; Christiansen, Kenneth R; Balestrieri, Francesco;
'crosswalk-dev@lists.crosswalk-project.org
k-dev@lists.crosswalk-project.org'
Subject: Re: [Crosswalk-dev] Intent to implement - Embedding API v2 Part1
Description:
Before embedding API, we have XWalkClient and XWalkWebChromeClient to provide
callbacks/delegate for XWalkView.
In Embedding API v1, we hide both classes and create XWalkUI
Description:
Before embedding API, we have XWalkClient and XWalkWebChromeClient to provide
callbacks/delegate for XWalkView.
In Embedding API v1, we hide both classes and create XWalkUIClient and
XWalkResourceClient for the APIs we want to expose in embedding API.
However, there still exists s
, Francesco;
crosswalk-dev@lists.crosswalk-project.org
Subject: Re: [Crosswalk-dev] Intent to implement - Embedding API v2
I think that this intent covers too much.
Many of these changes could be separate and should come with an explanation to
why the change is for the better.
Until that, no LGTM
I think that this intent covers too much.
Many of these changes could be separate and should come with an explanation
to why the change is for the better.
Until that, no LGTM from me
Kenneth
On Tue, Jun 10, 2014 at 9:52 AM, Wang, Shiliu wrote:
> *Description:*
>
> Adjust Crosswalk Embedding
Description:
Adjust Crosswalk Embedding API for following requirement:
1. Customer requirement
2. Moving current hidden API in internal classes with empty implementation
(which will be meaningless if not exposed) out to embedding API.
3. Deprecate enum type in current Embedding
