Re: [Cryptodev-linux-devel] [PATCH 3/3] add support for composite aead keys

2014-08-18 Thread Cristian Stoica
Hi Nikos, On 19.08.2014 07:52, Nikos Mavrogiannopoulos wrote: > On Mon, 2014-08-11 at 10:09 +0300, Cristian Stoica wrote: > >> Yes, that kernel patch is used with COP_FLAG_AEAD_TLS_TYPE but there is >> a difference from the cryptodev implementation (which I used for >> inspiration) in that it reg

Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers

2014-08-18 Thread Nikos Mavrogiannopoulos
On Tue, 2014-08-19 at 00:43 +0200, Phil Sutter wrote: > > The patch doesn't show up on the git repository. Let me know if you've > > just missed the push or are still reviewing so I can help you with it. > > But it is there. Maybe you pull from Nikos' repository? The 'official' > upstream has mov

Re: [Cryptodev-linux-devel] [PATCH 3/3] add support for composite aead keys

2014-08-18 Thread Nikos Mavrogiannopoulos
On Mon, 2014-08-11 at 10:09 +0300, Cristian Stoica wrote: > >> I've tested this patch with AES-CBC-HMAC-SHA1 using the tls module that > >> I've sent recently on Linux mailing list. That module needs rework for > >> Lucky 13 and is a software alternative to the caam driver that does the > >> same

Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers

2014-08-18 Thread Phil Sutter
Hi Christian, On Mon, Aug 18, 2014 at 04:17:42PM +0300, Cristian Stoica wrote: > Hi Phil, > > On 05.08.2014 01:36, Phil Sutter wrote: > > On Thu, Jul 10, 2014 at 01:32:59PM +0300, Cristian Stoica wrote: > >> Calculate tag and destination buffer length in a single place to avoid > >> code duplicat

Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers

2014-08-18 Thread Cristian Stoica
Hi Phil, On 05.08.2014 01:36, Phil Sutter wrote: > On Thu, Jul 10, 2014 at 01:32:59PM +0300, Cristian Stoica wrote: >> Calculate tag and destination buffer length in a single place to avoid >> code duplication. The TLS case is fixed by rounding the destination >> length to cipher block size. > >