Re: [Cryptodev-linux-devel] [PATCH] fix ignored SIGALRM signals on some platforms

2016-11-28 Thread Phil Sutter
On Mon, Oct 31, 2016 at 11:03:45AM +0200, Cristian Stoica wrote: > Signed-off-by: Tudor Ambarus > Signed-off-by: Cristian Stoica Applied, but please try to be a little more verbose especially with non-obvious changes like this one. E.g. which platforms are affected? How did you reproduce the iss

Re: [Cryptodev-linux-devel] [PATCH 6/6] setting KERNEL_DIR is not necessary to build tests

2016-11-28 Thread Phil Sutter
On Wed, Oct 26, 2016 at 02:09:29PM +0300, Cristian Stoica wrote: > Signed-off-by: Cristian Stoica > --- > tests/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 49959de..2502f32 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -1

Re: [Cryptodev-linux-devel] [PATCH 5/6] fix issues with install target

2016-11-28 Thread Phil Sutter
On Wed, Oct 26, 2016 at 02:09:28PM +0300, Cristian Stoica wrote: > Aparently, on some setups, 'sudo make' will clear the $PWD variable > on the first Makefile expansion. This leads to failures of "sudo make > install" or other issues when trying to preserve the environment with > sudo -E. > > Ther

Re: [Cryptodev-linux-devel] [PATCH 4/6] do more strict code checking to avoid maintenance issues

2016-11-28 Thread Phil Sutter
On Wed, Oct 26, 2016 at 02:09:27PM +0300, Cristian Stoica wrote: > Signed-off-by: Cristian Stoica > --- > tests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 5e3111d..49959de 100644 > --- a/tests/Makefile > +++ b/tests/M

Re: [Cryptodev-linux-devel] [PATCH 3/6] remove not used local variables

2016-11-28 Thread Phil Sutter
On Wed, Oct 26, 2016 at 02:09:26PM +0300, Cristian Stoica wrote: > Signed-off-by: Cristian Stoica > --- > tests/async_hmac.c | 2 -- > tests/cipher_comp.c | 2 +- > tests/hash_comp.c | 5 ++--- > tests/hmac.c| 2 -- > tests/sha_speed.c | 1 - > tests/speed.c | 1 - > 6 files ch

Re: [Cryptodev-linux-devel] [PATCH 2/6] fix warnings of "implicit declaration of function" in async_speed

2016-11-28 Thread Phil Sutter
On Wed, Oct 26, 2016 at 02:09:25PM +0300, Cristian Stoica wrote: > Signed-off-by: Cristian Stoica > --- > tests/async_speed.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/async_speed.c b/tests/async_speed.c > index 1188599..dad5bc5 100644 > --- a/tests/async_speed.c > +++ b/t

Re: [Cryptodev-linux-devel] [PATCH 1/6] avoid implicit conversion between signed and unsigned char

2016-11-28 Thread Phil Sutter
Hi, On Wed, Oct 26, 2016 at 02:09:24PM +0300, Cristian Stoica wrote: > Signed-off-by: Cristian Stoica > --- > tests/async_cipher.c | 36 ++-- > tests/async_hmac.c | 8 +++ > tests/cipher-aead-srtp.c | 50 +++--- > tests/ciphe