Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2017-02-09 Thread Michael Weiser
Hi Phil, On Thu, Feb 09, 2017 at 11:35:17AM +0100, Phil Sutter wrote: > > Phil? > I intentionally left this out since (according to my INBOX) there are > open questions from Michael. Did you sort this out in private? Those were misunderstandings on my part anyways and have been all cleared up. -

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2017-02-09 Thread Phil Sutter
On Thu, Feb 09, 2017 at 11:47:16AM +, Horia Geantă wrote: > On 2/9/2017 12:35 PM, Phil Sutter wrote: > > Hi, > > > > On Wed, Feb 08, 2017 at 04:41:50PM +, Horia Geantă wrote: > >> Phil? > > > > I intentionally left this out since (according to my INBOX) there are > > open questions from M

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2017-02-09 Thread Horia Geantă
On 2/9/2017 12:35 PM, Phil Sutter wrote: > Hi, > > On Wed, Feb 08, 2017 at 04:41:50PM +, Horia Geantă wrote: >> Phil? > > I intentionally left this out since (according to my INBOX) there are > open questions from Michael. Did you sort this out in private? > It seems that somehow you've been

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2017-02-09 Thread Phil Sutter
Hi, On Wed, Feb 08, 2017 at 04:41:50PM +, Horia Geantă wrote: > Phil? I intentionally left this out since (according to my INBOX) there are open questions from Michael. Did you sort this out in private? Cheers, Phil ___ Cryptodev-linux-devel maili

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2017-02-08 Thread Horia Geantă
Phil? On 11/17/2016 10:58 AM, Horia Geanta Neag wrote: > Forgot to Cc Michael Weiser. > > On 11/17/2016 10:20 AM, Horia Geantă wrote: >> ablkcipher API is not completely removed from kernels <= v4.9. >> Thus it's still valid to use ablkcipher algorithms. >> >> Fix the case when implementers regis

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Michael Weiser
Hi Horia, On Thu, Nov 17, 2016 at 11:27:10AM +, Horia Geanta Neag wrote: > Yes, the intent is to replace (a)blkcipher with skcipher, however the > conversion is not over yet. > and a part 4 (converting existing drivers) will surely follow. > > So is your patch meant as a stop-gap measure fo

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geanta Neag
On 11/17/2016 12:01 PM, Michael Weiser wrote: > Hi Horia, > > On Thu, Nov 17, 2016 at 10:18:50AM +0200, Horia Geant?? wrote: > >> ablkcipher API is not completely removed from kernels <= v4.9. >> Thus it's still valid to use ablkcipher algorithms. > > I was under the impression that skcipher is

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Michael Weiser
Hi Horia, On Thu, Nov 17, 2016 at 10:18:50AM +0200, Horia Geant?? wrote: > ablkcipher API is not completely removed from kernels <= v4.9. > Thus it's still valid to use ablkcipher algorithms. I was under the impression that skcipher is just a unified API meant to give a common way of accessing s

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geanta Neag
Forgot to Cc Michael Weiser. On 11/17/2016 10:20 AM, Horia Geantă wrote: > ablkcipher API is not completely removed from kernels <= v4.9. > Thus it's still valid to use ablkcipher algorithms. > > Fix the case when implementers register ablkcipher algorithms > and cryptodev casts them to skcipher

[Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geantă
ablkcipher API is not completely removed from kernels <= v4.9. Thus it's still valid to use ablkcipher algorithms. Fix the case when implementers register ablkcipher algorithms and cryptodev casts them to skcipher without checking their type. Note: alg returned by crypto_ablkcipher_alg() is no lo