Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-22 Thread Cristian Stoica
Hi Phil, > I really have no idea where you're heading at with this. But without further > context, it doesn't make any sense to me. If you have a functional > enhancement up your sleeve, I suggest submitting that along with this > change so I get an idea of what this is all about. > Of course, t

Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-20 Thread Phil Sutter
Hi Cristian, On Wed, Jan 20, 2016 at 02:06:49PM +, Cristian Stoica wrote: > > I really have no idea where you're heading at with this. But without further > > context, it doesn't make any sense to me. If you have a functional > > enhancement up your sleeve, I suggest submitting that along with

Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-20 Thread Cristian Stoica
On 01/18/2016 11:04 PM, Phil Sutter wrote: > On Tue, Jan 12, 2016 at 12:08:02PM +0200, Cristian Stoica wrote: ... >> -*src_sg = NULL; /* default to no input */ >> -*dst_sg = NULL; /* default to ignore output */ >> - > > This does not look correct to me. The purpose of those is to ensure >

Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-20 Thread Cristian Stoica
On 01/18/2016 11:04 PM, Phil Sutter wrote: > On Tue, Jan 12, 2016 at 12:08:02PM +0200, Cristian Stoica wrote: ... >> -*src_sg = NULL; /* default to no input */ >> -*dst_sg = NULL; /* default to ignore output */ >> - > > This does not look correct to me. The purpose of those is to ensure

Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-19 Thread Phil Sutter
On Tue, Jan 19, 2016 at 01:38:53PM +, Cristian Stoica wrote: > > > On 01/18/2016 11:04 PM, Phil Sutter wrote: > > On Tue, Jan 12, 2016 at 12:08:02PM +0200, Cristian Stoica wrote: > ... > >> - *src_sg = NULL; /* default to no input */ > >> - *dst_sg = NULL; /* default to ignore output */ > >

Re: [Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-18 Thread Phil Sutter
Hi, On Tue, Jan 12, 2016 at 12:08:02PM +0200, Cristian Stoica wrote: > NULL input or output is a valid case and we should not attempt > to write default values to NULL input or output pointers. > > Signed-off-by: Cristian Stoica > --- > zc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff -

[Cryptodev-linux-devel] [PATCH] fix the NULL input or output case for get_userbuf

2016-01-12 Thread Cristian Stoica
NULL input or output is a valid case and we should not attempt to write default values to NULL input or output pointers. Signed-off-by: Cristian Stoica --- zc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/zc.c b/zc.c index 29b0501..d6adcc4 100644 --- a/zc.c +++ b/zc.c @@ -176,9 +176,6