Re: [Cryptodev-linux-devel] openssl patch state

2012-06-15 Thread Nikos Mavrogiannopoulos
On Fri, Jun 15, 2012 at 1:56 PM, Phil Sutter wrote: > I was rather referring to the #if 0 above, effectively deactivating the > whole set of *_HMAC digests. :) Ah, ok. I saw that the digest_init() function had: sess->mackey = state->dummy_mac_key; sess->mackeylen = digest_key_length(ctx->digest

Re: [Cryptodev-linux-devel] openssl patch state

2012-06-15 Thread Phil Sutter
Hey, On Fri, Jun 15, 2012 at 01:41:50PM +0200, Nikos Mavrogiannopoulos wrote: > On Fri, Jun 15, 2012 at 12:41 PM, Phil Sutter wrote: > > Hi, > > On Thu, Jun 14, 2012 at 04:38:03PM +0200, Nikos Mavrogiannopoulos wrote: > >>  Which changes do you refer to? If I remember well this file is based > >>

Re: [Cryptodev-linux-devel] openssl patch state

2012-06-15 Thread Nikos Mavrogiannopoulos
On Fri, Jun 15, 2012 at 12:41 PM, Phil Sutter wrote: > Hi, > On Thu, Jun 14, 2012 at 04:38:03PM +0200, Nikos Mavrogiannopoulos wrote: >>  Which changes do you refer to? If I remember well this file is based >> on the eng_cryptodev.c of 1.0.1. > Particularly those: > > |  } digests[] = { > | +#if 0

Re: [Cryptodev-linux-devel] openssl patch state

2012-06-15 Thread Phil Sutter
Hi, On Thu, Jun 14, 2012 at 04:38:03PM +0200, Nikos Mavrogiannopoulos wrote: > Which changes do you refer to? If I remember well this file is based > on the eng_cryptodev.c of 1.0.1. Particularly those: | } digests[] = { | +#if 0 | +/* HMAC is not supported */ | { CRYPTO_MD5_HM

Re: [Cryptodev-linux-devel] openssl patch state

2012-06-14 Thread Nikos Mavrogiannopoulos
On Thu, Jun 14, 2012 at 4:04 PM, Phil Sutter wrote: > Hi, > I am currently comparing eng_cryptodev.c in current cryptodev-linux git > with the same file in openssl-1.0.0c, wondering about the differences. > Why the commented out support for HMAC modes? I assume cryptodev-linux > should still serve

[Cryptodev-linux-devel] openssl patch state

2012-06-14 Thread Phil Sutter
Hi, I am currently comparing eng_cryptodev.c in current cryptodev-linux git with the same file in openssl-1.0.0c, wondering about the differences. Why the commented out support for HMAC modes? I assume cryptodev-linux should still serve as drop-in replacement to OCF, so we should really keep this