[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Matthew D. Fuller
On Mon, May 22, 2006 at 02:51:07AM +0200 I heard the voice of Richard Levitte - VMS Whacker, and lo! it spake thus: > > Well, just half true. There's an older version running there, Well, there may be a 'monotone' server, but there's no 'mtn' server ;) > My best guess is that you're upgraded a

[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Mon, 22 May 2006 02:51:07 +0200 (CEST), Richard Levitte - VMS Whacker <[EMAIL PROTECTED]> said: richard> I'm asking you to put it aside and start with a completely richard> new a fresh database. It dawned on me that I haven't explained why. The following sectio

[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 18:43:08 -0500, "Matthew D. Fuller" <[EMAIL PROTECTED]> said: fullermd> Well, I'm not sure where it got that server name. There's fullermd> no mtn server running on repository.lp.se; Well, just half true. There's an older version running there

[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Matthew D. Fuller
On Mon, May 22, 2006 at 01:28:42AM +0200 I heard the voice of Richard Levitte - VMS Whacker, and lo! it spake thus: > > The initial pull stored the server name and the branch pattern. Well, I'm not sure where it got that server name. There's no mtn server running on repository.lp.se; I pulled fr

[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 18:05:18 -0500, "Matthew D. Fuller" <[EMAIL PROTECTED]> said: fullermd> On Sat, May 20, 2006 at 12:48:45PM +0200 I heard the voice of fullermd> Richard Levitte - VMS Whacker, and lo! it spake thus: fullermd> > fullermd> > If you have any questio

[ctwm] Re: Will upgrade monotone some time next week

2006-05-21 Thread Matthew D. Fuller
On Sat, May 20, 2006 at 12:48:45PM +0200 I heard the voice of Richard Levitte - VMS Whacker, and lo! it spake thus: > > If you have any question, please ask and I'll help you as much as I > can. I took this as an opportunity to try this again; I've had horrible luck getting monotone to work at al

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> kovert> > Didn't it help enough to make tmp_win->HiliteImage NULL? > kovert> > kovert> no. It still ended up freeing memory that was already freed. > kovert> I'm not quite clear on where it got the value from to pass in > kovert> after setting it to NULL. > > Wait, so you're saying that

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 14:42:00 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> > Didn't it help enough to make tmp_win->HiliteImage NULL? kovert> kovert> no. It still ended up freeing memory that was already freed. kovert> I'm not quite clear on where it got th

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> OK, I've a question: why do you remove the code entirely? presumably this is supposed to get freed at some point, just not twice, so I left it in there for someone to try to dig into it (presumably the original commiter/patch provider). Near as I can tell, this code is the only code that ac

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> kovert> note that this is against the cvs repository, and 3.7 does not > kovert> suffer from this. > > Uhmm, are you aware that the CVS repository has been deprecated for a > while now? > > I guess it's time to turn it off entirely... sorry, s/cvs/monotone 0.26 server that you upgraded

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
OK, I've a question: why do you remove the code entirely? Didn't it help enough to make tmp_win->HiliteImage NULL? In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 13:20:07 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> --- add_window.cefc8288ef604525373100ce0eb1e04654bc7e6d4 kov

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 13:20:07 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> note that this is against the cvs repository, and 3.7 does not kovert> suffer from this. Uhmm, are you aware that the CVS repository has been deprecated for a while now? I guess it's

[ctwm] repository has a double-free() bug

2006-05-21 Thread Todd Kover
I'm working on getting changes to the virtual workspaces pushed up and I found a bug in the recent memory management cleanups where memory is being freed twice. The attached patch against cvs should comment out the code causing the issue, but I have yet to track down what the right answer is to fr