[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> kovert> > Didn't it help enough to make tmp_win->HiliteImage NULL? > kovert> > kovert> no. It still ended up freeing memory that was already freed. > kovert> I'm not quite clear on where it got the value from to pass in > kovert> after setting it to NULL. > > Wait, so you're saying that

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 14:42:00 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> > Didn't it help enough to make tmp_win->HiliteImage NULL? kovert> kovert> no. It still ended up freeing memory that was already freed. kovert> I'm not quite clear on where it got th

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> OK, I've a question: why do you remove the code entirely? presumably this is supposed to get freed at some point, just not twice, so I left it in there for someone to try to dig into it (presumably the original commiter/patch provider). Near as I can tell, this code is the only code that ac

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Todd Kover
> kovert> note that this is against the cvs repository, and 3.7 does not > kovert> suffer from this. > > Uhmm, are you aware that the CVS repository has been deprecated for a > while now? > > I guess it's time to turn it off entirely... sorry, s/cvs/monotone 0.26 server that you upgraded

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
OK, I've a question: why do you remove the code entirely? Didn't it help enough to make tmp_win->HiliteImage NULL? In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 13:20:07 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> --- add_window.cefc8288ef604525373100ce0eb1e04654bc7e6d4 kov

[ctwm] Re: repository has a double-free() bug

2006-05-21 Thread Richard Levitte - VMS Whacker
In message <[EMAIL PROTECTED]> on Sun, 21 May 2006 13:20:07 -0400, Todd Kover <[EMAIL PROTECTED]> said: kovert> note that this is against the cvs repository, and 3.7 does not kovert> suffer from this. Uhmm, are you aware that the CVS repository has been deprecated for a while now? I guess it's