RE: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-03 Thread Steve Holme
On Sun, 03 Nov 2013, Björn Stenberg wrote: > Actually, a separate fix to the "Whut?" bug was already posted > four days ago in (http://curl.haxx.se/mail/lib-2013-10/0268.html, > although for some reason the mail archive doesn't include the > attached patch). Sorry I missed your patch - At

Re: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-03 Thread Björn Stenberg
Steve Holme wrote: > a) Splitting your patches up a little - this one appears to address 2 or 3 > separate issues (the add of the delay, IP address ordering, failed connect > fix and tidy up) which would help with others reviewing them as well as > enabling the application of individual parts if ne

Re: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-03 Thread Kamil Dudka
On Sunday, November 03, 2013 14:38:56 Björn Stenberg wrote: > Steve Holme wrote: > > I saw that most of the auto builds have mostly come back to life overnight > > and as such noticed that some tests are showing the "Whut?" connection > > issue. > > > > As such I have pushed my take on the Curl_is

Re: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-03 Thread Björn Stenberg
Steve Holme wrote: > I saw that most of the auto builds have mostly come back to life overnight > and as such noticed that some tests are showing the "Whut?" connection > issue. > > As such I have pushed my take on the Curl_is_connected() fix part of the > above mentioned patch. Actually, a separ

RE: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-03 Thread Steve Holme
On Sat, 02 Nov 2013, Steve Holme wrote: > If I took my Proxy Server down whilst I was testing my base64 > work I received the following output from curl: > > * Rebuilt URL to: http://www.bing.com/ > * About to connect() to proxy 192.168.0.1 port 8080 (#0) > * Trying 192.168.0.1... > * Adding han

RE: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-02 Thread Steve Holme
On Thu, 30 Oct 2013, Björn Stenberg wrote: > Thank you for testing. My refactoring of the synchronous error > handling code was a smidge too aggressive. Here is an updated > patch. I briefly mentioned this in my base64 decode thread earlier today but I just wanted to post the more finer detail he

Re: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-11-01 Thread Björn Stenberg
Paul Marks wrote: > Note that I have not attempted to test crazy situations involving > multiple IPv4 and IPv6 addresses, with the families interleaved. I have tested with multiple IPv4 and IPv6 addresses for a name (such as bad12.haxx.se) but I don't know how to make my system return them in jum

Re: [PATCH v2] Add connection delay to Happy Eyeballs.

2013-10-31 Thread Paul Marks
On Thu, Oct 31, 2013 at 4:34 PM, Björn Stenberg wrote: > Paul Marks wrote: >> - Running on a network without IPv6: >> + Fetch ds.test-ipv6.com: >> - Success, using IPv4. >> + Fetch ipv6.test-ipv6.com: >> - Hangs for 5 minutes -- Regression! > > Thank you for testing. My refactoring of

[PATCH v2] Add connection delay to Happy Eyeballs.

2013-10-31 Thread Björn Stenberg
Paul Marks wrote: > - Running on a network without IPv6: > + Fetch ds.test-ipv6.com: > - Success, using IPv4. > + Fetch ipv6.test-ipv6.com: > - Hangs for 5 minutes -- Regression! Thank you for testing. My refactoring of the synchronous error handling code was a smidge too aggressive.