Re: Increase in CPU usage in 8.7.1 vs 8.6.0 for rate-limited downloads

2024-05-15 Thread Dmitry Karpov via curl-library
I just want to refresh that this commit helped to restore the precision of rate throttling. Before it, the speed deviations from the limit were more than 10% in certain cases. And depending on the network speed, they occurred on relatively big downloads (i.e. 5 MB) as well. I think that CPU

Re: Increase in CPU usage in 8.7.1 vs 8.6.0 for rate-limited downloads

2024-05-15 Thread David Pfitzner via curl-library
On Wed, May 15, 2024 at 5:31 PM Daniel Stenberg wrote: > On Wed, 15 May 2024, David Pfitzner via curl-library wrote: > > > From testing, this change appears to be due to this commit: > > > > > https://github.com/curl/curl/commit/db5c9f4f9e0779b49624752b135281a0717b277b > > So just reverting this

Re: Increase in CPU usage in 8.7.1 vs 8.6.0 for rate-limited downloads

2024-05-15 Thread Daniel Stenberg via curl-library
On Wed, 15 May 2024, David Pfitzner via curl-library wrote: From testing, this change appears to be due to this commit: https://github.com/curl/curl/commit/db5c9f4f9e0779b49624752b135281a0717b277b So just reverting this single commit makes it "good" again? Perhaps it would be useful for a

Re: Increase in CPU usage in 8.7.1 vs 8.6.0 for rate-limited downloads

2024-05-15 Thread Stefan Eissing via curl-library
> Am 15.05.2024 um 08:56 schrieb David Pfitzner via curl-library > : > > Hi, > > I've noticed that from curl 8.6.0 to 8.7.1, the CPU usage when doing > rate-limited downloads with libcurl has increased significantly. This is most > noticeable when making multiple (rate-limited) downloads

Increase in CPU usage in 8.7.1 vs 8.6.0 for rate-limited downloads

2024-05-15 Thread David Pfitzner via curl-library
Hi, I've noticed that from curl 8.6.0 to 8.7.1, the CPU usage when doing rate-limited downloads with libcurl has increased significantly. This is most noticeable when making multiple (rate-limited) downloads in parallel, for large files. (I've seen this in a custom application using libcurl, and