Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Daniel Stenberg via curl-library
On Mon, 3 Jun 2024, kartatz via curl-library wrote: I set a maximum number of host connections here (CURLMOPT_MAX_HOST_CONNECTIONS) because I don't want to cause overhead on the server. However, things get a little weird if I set a CURLOPT_DOH_URL on the main easy handle: Interesting case.

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Daniel Stenberg via curl-library
On Tue, 4 Jun 2024, Daniel Stenberg via curl-library wrote: Interesting case. I think we should make DoH requests exempt from that check/restriciton, as otherwise you can end up in this kind of catch-22 situation. kartatz, how about a patch like this? --- a/lib/url.c +++ b/lib/url.c @@ -3661

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Daniel Stenberg via curl-library
On Tue, 4 Jun 2024, Daniel Stenberg via curl-library wrote: kartatz, how about a patch like this? Submitted as a PR here: https://github.com/curl/curl/pull/13880 -- / daniel.haxx.se | Commercial curl support up to 24x7 is available! | Private help, bug fixes, support, ports, new features

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Timothe Litt via curl-library
This would seem to still leave the doh connections consuming data connections' cache quota. That is, doh can crowd out data connections, or at least makes the connection limit hard to explain or manage. The application has no control over how many DNS transactions it takes to resolve, e.g. a

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Daniel Stenberg via curl-library
On Tue, 4 Jun 2024, Timothe Litt via curl-library wrote: The application has no control over how many DNS transactions it takes to resolve, e.g. a redirect/cname chain.  So picking a limit would require guesswork. Correct. As a user you also cannot really know how many connections those DNS

Linking problem with libcurl 8.8.0

2024-06-04 Thread Aurélien Pierre via curl-library
Hi, Since MSYS2/Pacman on Windows updated libcurl from 8.7.x to 8.8.x last week, a project that built properly before now produces the error : C:\Windows\system32\cmd.exe /C "cd . && D:\a\_temp\msys64\ucrt64\bin\cc.exe -Wall -Wno-format -Wshadow -Wtype-limits -Wvla -Wold-style-declaration -W

Re: Linking problem with libcurl 8.8.0

2024-06-04 Thread Daniel Stenberg via curl-library
On Tue, 4 Jun 2024, Aurélien Pierre via curl-library wrote: D:/a/ansel/ansel/src/src/common/curl_tools.c:29:(.text+0xde): undefined reference to `__imp_curl_easy_reset' D:/a/_temp/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/14.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: D:/a/ansel/ansel/

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread kartatz via curl-library
 On Tue, 4 Jun 2024, Daniel Stenberg via curl-library wrote: > Interesting case. I think we should make DoH requests exempt from that > check/restriciton, as otherwise you can end up in this kind of catch-22 > situation. kartatz, how about a patch like this?  Thank you for the patch! I checked

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread Daniel Stenberg via curl-library
On Tue, 4 Jun 2024, kartatz wrote: Now the multi interface can resolve using DoH, but the program crashes as soon as it attempts to connect to the resolved address: I don't think my patch causes that. The PR ran 159 successful CI jobs. -- / daniel.haxx.se | Commercial curl support up to 24

Re: Weird behavior when using DoH with the multi interface

2024-06-04 Thread kartatz via curl-library
I don't think my patch causes that. The PR ran 159 successful CI jobs. Yes, you are right. It appears that something from my previous builds was messing with things. I deleted the build directory and did a clean build. This time, everything worked as expected. I apologize for not checking pr