Re: mail vs GitGub

2022-03-30 Thread Drew DeVault via curl-library
On Wed Mar 30, 2022 at 10:01 AM CEST, Daniel Stenberg wrote: > On Wed, 30 Mar 2022, Drew DeVault wrote: > > > https://drewdevault.com/2022/03/29/free-software-free-infrastructure.html > > The most important quote for me is from another one of your blog posts: > > "Disclaimer: I work for a GitHub

Re: mail vs GitGub

2022-03-30 Thread Drew DeVault via curl-library
On Wed Mar 30, 2022 at 9:53 AM CEST, Daniel Stenberg wrote: > Very true. But the infrasystemwork was mostly done already by others on the > other (website) side so we didn't have to do a lot of work to get CI jobs and > stuff to work on GitHub. It was thus also going with the least resistance. >

Re: mail vs GitGub

2022-03-30 Thread Drew DeVault via curl-library
I have never refused to browse GitHub, though I would empathise with someone who did not wish to. However, it is much more challenging to receive feedback on emailed patches via GitHub. Initially I did not understand that part of your feedback was in the form of amending my patch, so I didn't pick

Re: mail vs GitGub

2022-03-30 Thread Drew DeVault via curl-library
On Wed Mar 30, 2022 at 9:31 AM CEST, Gavin Henry wrote: > Nice one! Where about does it live? Would like to read the source :) It's part of dispatch.sr.ht: https://git.sr.ht/~sircmpwn/dispatch.sr.ht But I will probably rewrite it as a standalone tool soon. -- Unsubscribe: https://lists.haxx.se/

Re: mail vs GitGub

2022-03-30 Thread Drew DeVault via curl-library
On Wed Mar 30, 2022 at 9:23 AM CEST, Gavin Henry via curl-library wrote: > Having just packaged up OpenDHT for Alpine linux, I know they have a > mailbot that picks up git patches from the mailing list and does a merge > request into their gitlab. This then runs all their CI. But they do prefer > t

[PATCH v6] setopt: make curl_easy_vsetopt public

2022-03-29 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- v6 fixes copyright on headers. Sorry about that! docs/libcurl/Makefile.inc| 1 + docs/libcurl/curl_easy_vsetopt.3 | 63 +++

Re: [PATCH v4] setopt: make curl_easy_vsetopt public

2022-03-29 Thread Drew DeVault via curl-library
I don't think the curl mailing list is the right place to discuss this, but I will at least answer some of your questions. On Tue Mar 29, 2022 at 1:11 PM CEST, Timothe Litt via curl-library wrote: > There are better ways to make your point.  I've found that the best way > to contribute to a proje

[PATCH v5] setopt: make curl_easy_vsetopt public

2022-03-29 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- Fixes CI issue with the new test case. docs/libcurl/Makefile.inc| 1 + docs/libcurl/curl_easy_vsetopt.3 | 63 +++

Re: [PATCH v4] setopt: make curl_easy_vsetopt public

2022-03-29 Thread Drew DeVault via curl-library
On Tue Mar 29, 2022 at 9:32 AM CEST, Daniel Stenberg wrote: > I'm sorry, but whose job would you say it is to forward outputs from GitHub > CI > jobs from your patch to the mailing list because you won't go there and check > yourself? I would say it's the project's responsibility to make the co

[PATCH v4] setopt: make curl_easy_vsetopt public

2022-03-29 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- Incorporates feedback from GitHub, which ought to have been forwarded to the mailing list. docs/libcurl/Makefile.inc| 1 + docs/libcurl/curl_e

Re: [PATCH v3] setopt: make curl_easy_vsetopt public

2022-03-23 Thread Drew DeVault via curl-library
On Thu Mar 24, 2022 at 12:08 AM CET, Daniel Stenberg wrote: > Thanks, but you seem to not have used all the changes I added to your commit > in https://github.com/curl/curl/pull/8619 that running the CI jobs showed, > nor > is Dan's two remarks about the man page addressed? Sorry, I was expecti

[PATCH v3] setopt: make curl_easy_vsetopt public

2022-03-23 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- docs/libcurl/curl_easy_vsetopt.3 | 42 + include/curl/easy.h | 3 ++ lib/setopt.c | 14 +++ li

Re: [PATCH v2] setopt: make curl_easy_vsetopt public

2022-03-22 Thread Drew DeVault via curl-library
On Tue Mar 22, 2022 at 10:42 AM CET, Daniel Stenberg wrote: > I think we also need at least one test case for this new function. Are you sure? This function has been around forever and is well covered by testing on curl_easy_setopt, which is just a thin shim around it anyway. -- Unsubscribe: http

[PATCH v2] setopt: make curl_easy_vsetopt public

2022-03-22 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- v2 drops RFC and adds a man page. docs/libcurl/curl_easy_vsetopt.3 | 42 include/curl/easy.h | 3 +++ li

Re: [RFC PATCH] setopt: make curl_easy_vsetopt public

2022-03-22 Thread Drew DeVault via curl-library
On Mon Mar 21, 2022 at 11:31 PM CET, Daniel Stenberg wrote: > I'm casually positive. Looks like it could be useful. Great! > Please consider submitting it as a full PR on GitHub to make sure it gets > tested, checked and poked at proper. I would prefer not to contribute via GitHub. I will follo

[RFC PATCH] setopt: make curl_easy_vsetopt public

2022-03-21 Thread Drew DeVault via curl-library
This moves the internal Curl_vsetopt function into the public API so that users can set options with a va_list. Signed-off-by: Drew DeVault --- Sending RFC to see if people are generally cool with this. If so, will follow up with a man page as well. include/curl/easy.h| 3 +++ lib/seto