Re: HTTPS RR in curl

2025-05-08 Thread Daniel Stenberg via curl-library
On Thu, 8 May 2025, Niall O'Reilly via curl-library wrote: - https://github.com/niallor/curl/blob/DNS-enhancements/DNS-Issues.md Two more comments: 1) the remarks about CNAME are probably only relevant for DoH? Since when using c-ares or getaddrinfo we don't really know if CNAME is even used

Re: HTTPS RR in curl

2025-05-08 Thread Niall O'Reilly via curl-library
On 8 May 2025, at 18:12, Daniel Stenberg wrote: > Remember that we handle HTTPS-RR also without DoH now, so I would imagine > most of your changes would end up in httpsrr.c ... Thanks. I'll take a look there too, when I'm back in "curl-hacking mode". /Niall -- Unsubscribe: https://lists.haxx.s

Re: HTTPS RR in curl

2025-05-08 Thread Daniel Stenberg via curl-library
On Thu, 8 May 2025, Niall O'Reilly via curl-library wrote: - https://github.com/niallor/curl/blob/DNS-enhancements/lib/doh.c Remember that we handle HTTPS-RR also without DoH now, so I would imagine most of your changes would end up in httpsrr.c ... -- / daniel.haxx.se || https://rock-sol

HTTPS RR in curl

2025-05-08 Thread Niall O'Reilly via curl-library
I've just started a new branch of niallor/curl, to address some shortcomings in processing of DNS responses. I plan to work more on this following RIPE90 (which is next week). In case anyone is curious, these two files show my efforts so far: - https://github.com/niallor/curl/blob/DNS-enhancement

Re: HTTPS RR in curl

2025-04-25 Thread Stephen Farrell via curl-library
Hiya, On 18/04/2025 19:10, Dan Fandrich via curl-library wrote: On Fri, Apr 18, 2025 at 05:24:44PM +0100, Stephen Farrell via curl-library wrote: Would it make sense in the meantime as a stop-gap to add a test that checks whether ECH works with [1] and/or [2]? We can't add any tests that ac

Re: HTTPS RR in curl

2025-04-24 Thread Daniel Stenberg via curl-library
On Thu, 24 Apr 2025, Niall O'Reilly via curl-library wrote: I've just built from 29e0a8a09, and can confirm that ECH now works in the cases where I reported it didn't. Excellent. Thanks for fixing and confirming! -- / daniel.haxx.se || https://rock-solid.curl.dev -- Unsubscribe: https://lis

Re: HTTPS RR in curl

2025-04-24 Thread Niall O'Reilly via curl-library
On 17 Apr 2025, at 16:08, Niall O'Reilly wrote: > I've just built from the master branch of the curl/curl repo, > and had some surprises with ECH functioning (or not). I've just built from 29e0a8a09, and can confirm that ECH now works in the cases where I reported it didn't. /Niall -- Unsubscri

Re: HTTPS RR in curl

2025-04-18 Thread Daniel Stenberg via curl-library
On Fri, 18 Apr 2025, Stephen Farrell via curl-library wrote: I just posted a PR [1] that seems to fix this. Probably good to get @niallor to confirm that it works in his setup too before merging. It was such an obvious fix of a mistake I merged it at once! :-) -- / daniel.haxx.se || https:/

Re: HTTPS RR in curl

2025-04-18 Thread Stephen Farrell via curl-library
On 18/04/2025 19:10, Dan Fandrich via curl-library wrote: On Fri, Apr 18, 2025 at 05:24:44PM +0100, Stephen Farrell via curl-library wrote: Would it make sense in the meantime as a stop-gap to add a test that checks whether ECH works with [1] and/or [2]? We can't add any tests that access r

Re: HTTPS RR in curl

2025-04-18 Thread Dan Fandrich via curl-library
On Fri, Apr 18, 2025 at 05:24:44PM +0100, Stephen Farrell via curl-library wrote: > Would it make sense in the meantime as a stop-gap to add a test > that checks whether ECH works with [1] and/or [2]? We can't add any tests that access remote servers; the test suite must be usable without any out

Re: HTTPS RR in curl

2025-04-18 Thread Stephen Farrell via curl-library
Hiya, On 17/04/2025 22:06, Daniel Stenberg via curl-library wrote: We have no ECH tests in the test suite so it is not unthinkable that we have broken it when we changed the HTTPS-RR logic recently. Apologies again for not having gotten around to adding ECH tests to the curl test harness. (

Re: HTTPS RR in curl

2025-04-18 Thread Stephen Farrell via curl-library
Hi all, On 18/04/2025 13:51, Stephen Farrell via curl-library wrote: On 17/04/2025 16:08, Niall O'Reilly via curl-library wrote: With DoH, and with `--ech true`, my resolver logs an request for the HTTPS RR, but curl gives the message `ECH: requested but no ECHConfig available`. Just to co

Re: HTTPS RR in curl

2025-04-18 Thread Stephen Farrell via curl-library
On 17/04/2025 16:08, Niall O'Reilly via curl-library wrote: With DoH, and with `--ech true`, my resolver logs an request for the HTTPS RR, but curl gives the message `ECH: requested but no ECHConfig available`. Just to confirm - I also see the above. Will check later to see if some tweak fixe

Re: HTTPS RR in curl

2025-04-18 Thread Niall O'Reilly via curl-library
On 17 Apr 2025, at 22:06, Daniel Stenberg wrote: > The HTTPS-RR support itself also probably has a few rough edges left that we > need to polish. There are some quite significant ones. The symptoms I described seem to be due to gaps in the HTTPS-RR support, rather than in the ECH support. > So

Re: HTTPS RR in curl

2025-04-17 Thread Daniel Stenberg via curl-library
On Thu, 17 Apr 2025, Niall O'Reilly via curl-library wrote: Have I made some silly mistake, or should I open an issue or two? We have no ECH tests in the test suite so it is not unthinkable that we have broken it when we changed the HTTPS-RR logic recently. The HTTPS-RR support itself also

Re: HTTPS RR in curl

2025-04-17 Thread Niall O'Reilly via curl-library
Hey, On 31 Mar 2025, at 8:43, Daniel Stenberg via curl-library wrote: > Hey, > > I wrote a short blog post about HTTPS RR in curl: Nice blog post! I've just built from the master branch of the [curl/curl][] repo, and had some surprises with ECH functioning (or not). I'

HTTPS RR in curl

2025-03-31 Thread Daniel Stenberg via curl-library
Hey, I wrote a short blog post about HTTPS RR in curl: https://daniel.haxx.se/blog/2025/03/31/https-rr-in-curl/ -- / daniel.haxx.se || https://rock-solid.curl.dev -- Unsubscribe: https://lists.haxx.se/mailman/listinfo/curl-library Etiquette: https://curl.se/mail/etiquette.html