Updating src tree:
P src/lib/libcurses/setterm.c
P src/sys/dev/hyperv/hvs.c
P src/tests/lib/libcurses/director/director.c
Updating xsrc tree:
Killing core files:
Updating file list:
-rw-rw-r-- 1 srcmastr netbsd 41350317 Jun 11 03:03 ls-lRA.gz
On Thu, Jun 10, 2021 at 11:10:23AM +0200, Frank Kardel wrote:
>
> I meant the section in ststart1 where error is set to zero followed by goto
> out inf the fixed blocksize part.
>
Sorry, yes you are correct. I ignored that because I am using variable
blocks...oops.
--
Brett Lymn
--
Sent from
On Thu, Jun 10, 2021 at 05:38:34PM +0200, Michael van Elst wrote:
>
> Sorry, it doesn't fix the EOM handling, just the biodone.
>
mea culpa... I should take more time before replying...
> I still have to understand the EOM logic :)
>
I will post up a diff later that appears to work for me. F
On Thu, Jun 10, 2021 at 04:57:21PM +0200, Frank Kardel wrote:
> Hi !
>
> I assumed Michael was proposing a solution for the missing biodone() in the
> fixed block path (though that part was missing in the patch).
Yes, biodone needs to be called without the lock being held, so not
in ststart1().
On Thu, Jun 10, 2021 at 11:22:45PM +0930, Brett Lymn wrote:
> On Thu, Jun 10, 2021 at 12:13:22PM +0200, Michael van Elst wrote:
> > On Thu, Jun 10, 2021 at 12:02:19PM +0200, Michael van Elst wrote:
> >
> > > If you don't like the fake errno, the function needs to return
> > > two values, the error
Hi !
I assumed Michael was proposing a solution for the missing biodone() in
the fixed block path (though that part was missing in the patch).
We should try to fix both issues (write return code and missing biodone)
with hopefully minimal changes without sacrificing clarity and abstraction.
On Thu, Jun 10, 2021 at 12:13:22PM +0200, Michael van Elst wrote:
> On Thu, Jun 10, 2021 at 12:02:19PM +0200, Michael van Elst wrote:
>
> > If you don't like the fake errno, the function needs to return
> > two values, the error value and a boolean to finish the
> > unqueued request. Cleaner, but
On Thu, Jun 10, 2021 at 12:02:19PM +0200, Michael van Elst wrote:
> If you don't like the fake errno, the function needs to return
> two values, the error value and a boolean to finish the
> unqueued request. Cleaner, but more changes.
E.g. (not even compile-tested):
Index: st.c
On Thu, Jun 10, 2021 at 11:10:23AM +0200, Frank Kardel wrote:
> Hi Brett,
>
> I meant the section in ststart1 where error is set to zero followed by goto
> out inf the fixed blocksize part.
The biodone is missing, but also other parts.
We have 5 cases.
- I/O request is queued, error == 0. ->
Hi Brett,
I meant the section in ststart1 where error is set to zero followed by
goto out inf the fixed blocksize part.
on that path the biodone() would be missing - just something I noticed
when looking at the code.
/*
* only FIXEDBLOCK devices have pending I/O or space op
Hi Frank,
On Thu, Jun 10, 2021 at 07:45:25AM +0200, Frank Kardel wrote:
>
> Could you check whether my suspicion that biodone() may be missing the
> ststart1 function in the
>
It is missing there but is called in ststart if the error is != 0 after
the ststart1 call. I was going to update the
11 matches
Mail list logo
