Re: bmake inefficiencies

2021-02-05 Thread Mateusz Guzik
On 2/5/21, Simon J. Gerraty wrote: > Mateusz Guzik wrote: >> >> is the signal stuff really necessary? >> > >> > It avoids the need to loop dealing with interupts. >> > The name seems missleading should be block not lock. >> > >> >>

Re: bmake inefficiencies

2021-02-05 Thread Mateusz Guzik
On 2/5/21, Simon J. Gerraty wrote: > Mateusz Guzik wrote: > >> [External Email. Be cautious of content] >> >> >> Responding to the original mail due to several follow ups. >> >> Thanks for fixups so far. >> >> Another note rel

Re: bmake inefficiencies

2021-02-05 Thread Mateusz Guzik
d unlink the result. This would shorten this callsite to roughly: char buf[MAXPATHLATEN]; ... tfd = mkTempFile(TMPPAT, buf, sizeof buf, !DEBUG(SCRIPT)); which will also save on memory alloc and string coying as the target routine calls bmake_strdup to accomodate the request. On 1/26/21, Mateusz Guzik

bmake inefficiencies

2021-01-26 Thread Mateusz Guzik
nc__); + *out_run = FALSE; + return; + } + printf("%s: created!\n", __func__); + } + JobSigLock(&mask); tfd = mkTempFile(TMPPAT, &tfile); if (!DEBUG(SCRIPT)) - -- Mateusz Guzik

Re: Increases in build system time

2019-11-15 Thread Mateusz Guzik
On 11/15/19, Andreas Gustafsson wrote: > Mateusz Guzik wrote: >> Can you get a kernel-side flamegraph? > > Done, using sources from 2019.11.14.13.58.22: > > http://www.gson.org/netbsd/bugs/system-time/fg.svg > Thanks. First thing which jumps at me is DIAGNOSTIC

Re: Increases in build system time

2019-11-14 Thread Mateusz Guzik
h.pl > fg.svg See https://github.com/brendangregg/FlameGraph.git I know it used to work fine, but tried it few months back in a vm and profile- probes were not there. I don't know if it was a local wart. -- Mateusz Guzik

Re: time(1) reporting corrupted system time

2019-10-30 Thread Mateusz Guzik
of days of bisection run time. Hi, I failed to find a follow up to this. I see someone gave the you the fix for corrupted time accounting. Did you get around to finding the offending commit? -- Mateusz Guzik