Hi,
Testing ohci recently, I came across a problem where our audio stack doesn't
handle removing an audio device whilst it's open. I connected a uaudio
device (dmesg below), ran mplayer:
:; mplayer -ao oss:device=/dev/audio1 track.ogg
and removed the uaudio device in the middle of the track.
Hello,
At Thu, 10 Dec 2020 08:10:42 +0100,
Julian Coleman wrote:
> and removed the uaudio device in the middle of the track. This resulted in
> an endless stream (roughly once every 5 seconds) of:
>
> audio1: audio_unlink: cv_timedwait_sig failed 35
>
> and no USB device was recognised on tha
Hello,
> I have just fixed it in -current (I will pullup to -9 later).
> Thank you for reporting.
Thank you for the fast fix! I verified that this works for me.
I ran into a problem with uaudio, but I'll have a look at uaudio_detach().
Regards,
Julian
Hello,
> I ran into a problem with uaudio, but I'll have a look at uaudio_detach().
With a hint from skrll@, I looked at uaudio_detach(). We already have
code in uaudio_halt_out_dma() and uaudio_halt_in_dma() to stop any playback
or recording, so it looks like we can reuse these when detaching.
nice. LGTM.
.mrg.
Hello,
> With a hint from skrll@, I looked at uaudio_detach(). We already have
> code in uaudio_halt_out_dma() and uaudio_halt_in_dma() to stop any playback
> or recording, so it looks like we can reuse these when detaching. With the
> attached patch, I no longer see the panics when removing a u
