Re: cvs commit: ports/security/sshguard Makefile ports/security/sshguard/files pkg-message.in sshguard.in

2012-06-27 Thread Andrey Chernov
On Wed, Jun 27, 2012 at 12:48:46PM -0700, Xin Li wrote: > Thanks for your comments, I'll address them in a revised version. Thanks. I have yet one idea: to add /var/log/xferlog to sshguard_watch_logs by default since sshguard understand FreeBSD ftpd log format: FreeBSD ftpddefault FT

Re: cvs commit: ports/security/sshguard Makefile ports/security/sshguard/files pkg-message.in sshguard.in

2012-06-27 Thread Andrey Chernov
On Wed, Jun 27, 2012 at 12:22:55AM +, Xin LI wrote: > delphij 2012-06-27 00:22:55 UTC > > FreeBSD ports repository > > Modified files: > security/sshguardMakefile > security/sshguard/files pkg-message.in > Added files: > security/sshguard/files sshguard.in > Log

Re: cvs commit: ports/lang/php5 Makefile distinfo ports/lang/php5/files patch-ext-pcre-php_pcre.c patch-sapi_apache2filter_config.m4

2012-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2012 at 03:06:53PM +, Alex Dupre wrote: > ale 2012-04-30 15:06:53 UTC > > FreeBSD ports repository > > Modified files: > lang/php5Makefile distinfo > Removed files: > lang/php5/files patch-ext-pcre-php_pcre.c >

Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c

2011-10-10 Thread Andrey Chernov
On Mon, Oct 10, 2011 at 10:10:01PM -0400, Eitan Adler wrote: > > Note: this is true for old FreeBSD versions without /dev/pts, i.e. for > > FreeBSD < 8. Since old versions will die soon, perhaps choosen default > > isn't so bad. > > The default was chosen before I joined x11@ and I have not review

Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c

2011-10-10 Thread Andrey Chernov
On Tue, Oct 11, 2011 at 05:06:45AM +0400, Andrey Chernov wrote: > On Mon, Oct 10, 2011 at 08:26:08PM -0400, Sahil Tandon wrote: > > > It happens only if builded luit port have WITH_SETUID_LUIT set, otherwise > > > you don't notice the bug. > > > > Ah, so i

Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c

2011-10-10 Thread Andrey Chernov
On Mon, Oct 10, 2011 at 08:26:08PM -0400, Sahil Tandon wrote: > > It happens only if builded luit port have WITH_SETUID_LUIT set, otherwise > > you don't notice the bug. > > Ah, so it does not actually affect the default packages as built by the > clusters? Yes, default packages are not affected

Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c

2011-10-10 Thread Andrey Chernov
On Mon, Oct 10, 2011 at 05:35:11PM -0400, Eitan Adler wrote: > On Mon, Oct 10, 2011 at 3:43 PM, Andrey Chernov wrote: > > I report already that it needs -DBSD. > > Since you don't add -DBSD, it immediatelly exits with the following error: > > "Couldn't drop

Re: cvs commit: ports/x11/luit Makefile distinfo ports/x11/luit/files patch-luit.c

2011-10-10 Thread Andrey Chernov
On Mon, Oct 10, 2011 at 05:38:17PM +, Eitan Adler wrote: > eadler 2011-10-10 17:38:17 UTC > > FreeBSD ports repository > > Modified files: > x11/luit Makefile distinfo > Removed files: > x11/luit/files patch-luit.c > Log: > - remove upstreamed patch

Re: cvs commit: ports/net/p5-Geo-IP Makefile distinfo

2011-09-26 Thread Andrey Chernov
On Tue, Sep 27, 2011 at 02:04:04AM +, Cheng-Lung Sung wrote: > clsung 2011-09-27 02:04:04 UTC > > FreeBSD ports repository > > Modified files: > net/p5-Geo-IPMakefile distinfo > Log: > - Update to 1.40 Could you pick two other changes from PR 160724, please? -- ht

Re: cvs commit: ports/security/vuxml vuln.xml

2011-09-01 Thread Andrey Chernov
On Thu, Sep 01, 2011 at 07:06:27PM +, Chris Rees wrote: > crees 2011-09-01 19:06:27 UTC > > FreeBSD ports repository > > Modified files: > security/vuxml vuln.xml > Log: > Correct range for apache22, 2.2.20 is fixed and 1.3 wasn't affected. > According to http://c

Re: cvs commit: ports/mail/milter-greylist-devel Makefile

2011-08-30 Thread Andrey Chernov
On Tue, Aug 30, 2011 at 10:43:18PM +0400, Mikhail Tsatsenko wrote: > 30.08.2011 22:28 пользователь "Andrey Chernov" написал: > > BTW, it isn't my port really. My e-mail address was committed in > > MAINTAINER field by pgollu...@freebsd.org apparently by mistake at

Re: cvs commit: ports/mail/milter-greylist-devel Makefile

2011-08-30 Thread Andrey Chernov
On Tue, Aug 30, 2011 at 07:53:21AM +, Andrey A. Chernov wrote: > ache2011-08-30 07:53:21 UTC > > FreeBSD ports repository > > Modified files: > mail/milter-greylist-devel Makefile > Log: > Remove myself from MAINTAINER > > Revision ChangesPath > 1.18 +1 -

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo

2011-08-23 Thread Andrey Chernov
On Mon, Aug 22, 2011 at 11:56:16PM -0700, Stanislav Sedov wrote: > I'm not entirely sure, but this might happen because of exception > being delivered from File.realpath. Thanx. After all your patches up to current moment it works for me. -- http://ache.vniz.net/ pgpnNADCUR2SL.pgp Description:

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo

2011-08-22 Thread Andrey Chernov
On Tue, Aug 23, 2011 at 03:25:44AM +, Stanislav Sedov wrote: > stas2011-08-23 03:25:44 UTC > > FreeBSD ports repository > > Modified files: > ports-mgmt/portupgrade Makefile distinfo > Log: > - Update to 2.4.9.2. > This version is a bugfix release. It still rebuilds

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo ports/ports-mgmt/portupgrade/files patch-bin-Makefile

2011-08-21 Thread Andrey Chernov
On Mon, Aug 22, 2011 at 07:47:06AM +0400, Andrey Chernov wrote: > Thanx, it seems that two mentioned problems are gone, but I found 3rd one: > pkg_deinstall always aborts with error wich causing base rebuilding every > time: > > # pkg_deinstall /var/db/pkg/rub

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo ports/ports-mgmt/portupgrade/files patch-bin-Makefile

2011-08-21 Thread Andrey Chernov
On Sun, Aug 21, 2011 at 11:53:58AM -0400, Steve Wills wrote: > The attached patch may help. Please give it a try and let me know. > Create ports/ports-mgmt/portupgrade/files and drop this in. I test it with portupgrade-devel, which may be identical now. Thanx, it seems that two mentioned problems

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo ports/ports-mgmt/portupgrade/files patch-bin-Makefile

2011-08-21 Thread Andrey Chernov
> # portupgrade -vuR > /usr/local/lib/ruby/site_ruby/1.9/pkgmisc.rb:104:in `realpath': wrong > number of arguments (2 for 1) (ArgumentError) > from /usr/local/lib/ruby/1.9/pathname.rb:446:in `realpath' > > It is true: 'realpath' have 2 args in pathname.rb and 1 arg in pkgmisc.rb Despite a

Re: cvs commit: ports/ports-mgmt/portupgrade Makefile distinfo ports/ports-mgmt/portupgrade/files patch-bin-Makefile

2011-08-21 Thread Andrey Chernov
On Thu, Aug 18, 2011 at 08:05:50AM +, Stanislav Sedov wrote: > stas2011-08-18 08:05:50 UTC > > FreeBSD ports repository > > Modified files: > ports-mgmt/portupgrade Makefile distinfo > Removed files: > ports-mgmt/portupgrade/files patch-bin-Makefile > Log: > - Upda

Re: cvs commit: ports/security/clamav Makefile distinfo ports/security/clamav/files patch-libclamav__c++__PointerTracking.h patch-unit_tests-check_common_sh

2011-08-01 Thread Andrey Chernov
On Sat, Jul 30, 2011 at 12:51:57AM +0400, Andrey Chernov wrote: > On Sat, Jul 30, 2011 at 12:24:20AM +0400, Andrey Chernov wrote: > > > > > > Could you send me test-suite.log please? > > > > Attached. > > BTW, in the test-stderr.log I found following lines

Re: cvs commit: ports/security/clamav Makefile distinfo ports/security/clamav/files patch-libclamav__c++__PointerTracking.h patch-unit_tests-check_common_sh

2011-07-29 Thread Andrey Chernov
On Sat, Jul 30, 2011 at 12:24:20AM +0400, Andrey Chernov wrote: > > > > Could you send me test-suite.log please? > > Attached. BTW, in the test-stderr.log I found following lines which looks sucpicions: LibClamAV debug: searching for unrar: libclamunrar_iface.so.6.1.11 no

Re: cvs commit: ports/security/clamav Makefile distinfo ports/security/clamav/files patch-libclamav__c++__PointerTracking.h patch-unit_tests-check_common_sh

2011-07-29 Thread Andrey Chernov
On Thu, Jul 28, 2011 at 09:40:47AM -0300, Renato Botelho wrote: > > This is for recent -current, upgrade fails as result. > > > > PASS: check_clamav > > PASS: check_freshclam.sh > > PASS: check_sigtool.sh > > SKIP: check_unit_vg.sh > > PASS: check1_clamscan.sh > > FAIL: check2_clamd.sh > > PASS: c

Re: cvs commit: ports/security/clamav Makefile distinfo ports/security/clamav/files patch-libclamav__c++__PointerTracking.h patch-unit_tests-check_common_sh

2011-07-27 Thread Andrey Chernov
On Tue, Jul 26, 2011 at 10:24:21PM +, Renato Botelho wrote: > garga 2011-07-26 22:24:21 UTC > > FreeBSD ports repository > > Modified files: > security/clamav Makefile distinfo > Removed files: > security/clamav/files patch-libclamav__c++__PointerTracking.h >

Re: cvs commit: ports/www/p5-libwww Makefile distinfo pkg-descr pkg-plist

2011-07-11 Thread Andrey Chernov
On Mon, Jul 11, 2011 at 06:39:11AM +, Sunpoet Po-Chuan Hsieh wrote: > sunpoet 2011-07-11 06:39:11 UTC > > FreeBSD ports repository > > Modified files: > www/p5-libwwwMakefile distinfo pkg-descr pkg-plist > Log: > - Update to 6.02 > - Take maintainership [1] It fail

Re: cvs commit: ports/lang/php5/files patch-configure.in

2011-03-03 Thread Andrey Chernov
On Fri, Mar 04, 2011 at 02:25:04AM +0300, Andrey Chernov wrote: > On Thu, Mar 03, 2011 at 08:20:27AM +, Alex Dupre wrote: > > ale 2011-03-03 08:20:27 UTC > > > > FreeBSD ports repository > > > > Modified files: > > lang/php5/f

Re: cvs commit: ports/lang/php5/files patch-configure.in

2011-03-03 Thread Andrey Chernov
On Thu, Mar 03, 2011 at 08:20:27AM +, Alex Dupre wrote: > ale 2011-03-03 08:20:27 UTC > > FreeBSD ports repository > > Modified files: > lang/php5/files patch-configure.in > Log: > Don't link with librt, nanosleep is in libc. > > Spotted by: ache > > Re

Re: cvs commit: ports/print/ghostscript8 Makefile ports/print/ghostscript8/files patch-jbig2dec__os_types.h

2010-08-03 Thread Andrey Chernov
On Wed, Aug 04, 2010 at 11:36:28AM +0900, Hiroki Sato wrote: > Thanks for the report. Could you try the attached patch and let me > know if it solves the dependency issue? > CONFIGURE_ARGS+=--without-x > +.if defined(WITH_GS_display) > +CONFIGURE_ARGS+=--disable-gtk > +.endif Do you mean !def

Re: cvs commit: ports/print/ghostscript8 Makefile ports/print/ghostscript8/files patch-jbig2dec__os_types.h

2010-08-03 Thread Andrey Chernov
On Tue, Aug 03, 2010 at 11:50:47PM +0400, Andrey Chernov wrote: > On Tue, Aug 03, 2010 at 11:33:30PM +0400, Andrey Chernov wrote: > > On Tue, Aug 03, 2010 at 03:39:45PM +, Hiroki Sato wrote: > > > hrs 2010-08-03 15:39:45 UTC > > > >

Re: cvs commit: ports/print/ghostscript8 Makefile ports/print/ghostscript8/files patch-jbig2dec__os_types.h

2010-08-03 Thread Andrey Chernov
On Tue, Aug 03, 2010 at 11:33:30PM +0400, Andrey Chernov wrote: > On Tue, Aug 03, 2010 at 03:39:45PM +, Hiroki Sato wrote: > > hrs 2010-08-03 15:39:45 UTC > > > > FreeBSD ports repository > > > > Modified files: > > print/ghost

Re: cvs commit: ports/print/ghostscript8 Makefile ports/print/ghostscript8/files patch-jbig2dec__os_types.h

2010-08-03 Thread Andrey Chernov
On Tue, Aug 03, 2010 at 03:39:45PM +, Hiroki Sato wrote: > hrs 2010-08-03 15:39:45 UTC > > FreeBSD ports repository > > Modified files: > print/ghostscript8 Makefile > Removed files: > print/ghostscript8/files patch-jbig2dec__os_types.h > Log: > Use graphics/jbig

Re: cvs commit: ports/security/clamav Makefile ports/security/clamav/files patch-clamav-milter-fix

2009-04-04 Thread Andrey Chernov
On Fri, Apr 03, 2009 at 01:56:35PM +, Renato Botelho wrote: > garga 2009-04-03 13:56:35 UTC > > FreeBSD ports repository > > Modified files: > security/clamav Makefile > Added files: > security/clamav/files patch-clamav-milter-fix > Log: > - Mark clamav-milter a

Re: cvs commit: src/games/fortune/strfile strfile.c

2008-08-08 Thread Andrey Chernov
On Fri, Aug 08, 2008 at 09:43:29PM +0100, David Malone wrote: > On Fri, Aug 08, 2008 at 12:21:50AM -0600, M. Warner Losh wrote: > > This does beg the question why we need cryptographically secure > > randomness for fortune, however... > > I seem to remember us catching a /dev/random related bug be

Re: cvs commit: src/games/fortune/strfile strfile.c

2008-08-08 Thread Andrey Chernov
On Fri, Aug 08, 2008 at 12:16:44PM +0200, Dag-Erling Sm??rgrav wrote: > > 1) PRNG is not crypto. > > Stop spewing nonsense. Do you have enough education to determene what is nonsense and what is not here? For example I have master degree in mathematics. > PRNG and crypto are inseparable. W

Re: cvs commit: src/games/fortune/strfile strfile.c

2008-08-07 Thread Andrey Chernov
On Fri, Aug 08, 2008 at 12:21:50AM -0600, M. Warner Losh wrote: > This does beg the question why we need cryptographically secure > randomness for fortune, however... 1) PRNG is not crypto. 2) We already have it "cryptographically" secure via randomdev() for a long time in anycase. 3) Any code

Re: cvs commit: src/games/fortune/strfile strfile.c

2008-08-07 Thread Andrey Chernov
On Fri, Aug 08, 2008 at 12:38:55AM +0200, Kris Kennaway wrote: > Is that the right solution? If someone is bootstrapping from an old > kernel (e.g. 7.0) then installworld will install a strfile without your > change. No, this is bootstrap tool, so it is rebuilded twice, once without change a

Re: cvs commit: src/lib/libc/gen arc4random.c

2008-07-22 Thread Andrey Chernov
On Tue, Jul 22, 2008 at 10:34:51AM +, Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, "Andrey A. Cherno > v" writes: > > > Increase initially dropped bytes from 512 to 768 (768 is also > > suggested in the Ilya Mironov's article). 768 taken from another > > research where it trea

Re: cvs commit: src/usr.bin/unzip unzip.c

2008-07-02 Thread Andrey Chernov
On Mon, Jun 30, 2008 at 05:11:27PM +, Dag-Erling Smorgrav wrote: > des 2008-06-30 17:11:27 UTC > > FreeBSD src repository > > Modified files: > usr.bin/unzipunzip.c > Log: > SVN rev 180124 on 2008-06-30 17:11:27Z by des > > Quick shot at implementing -t (test

Re: cvs commit: src/include stdio.h src/lib/libc/stdio clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c xprintf.c

2008-05-07 Thread Andrey Chernov
On Tue, May 06, 2008 at 11:40:13PM -0700, Alfred Perlstein wrote: > Oh c'mon! we're going to revert this needed fix just because of > autoconf? Autoconf is just example. Many programs which dig inside FILE will be broken, i.e. many GNU and Linux programs and we already have two examples in our

Re: cvs commit: src/etc/defaults rc.conf

2008-05-01 Thread Andrey Chernov
On Thu, May 01, 2008 at 03:59:00PM -0400, John Baldwin wrote: > Yeah, but my laptop only has vidconsole and it hangs during a panic in X > unless I turn off 'debugger_on_panic'. Ideally KDB_UNATTENDED option (almost the same thing) should be able to produce textdumps, but currently is not. --

Re: cvs commit: src/sys/dev/ata ata-all.c ata-dma.c

2008-04-21 Thread Andrey Chernov
On Sat, Apr 19, 2008 at 05:50:31AM +0400, Andrey Chernov wrote: > On Fri, Apr 18, 2008 at 03:15:04PM +, SЬren Schmidt wrote: > > Modified files: > > sys/dev/ata ata-all.c ata-dma.c > > Log: > > Fix the breakage that caused AHCI devices

Re: cvs commit: src/sys/dev/ata ata-all.c ata-dma.c

2008-04-18 Thread Andrey Chernov
On Fri, Apr 18, 2008 at 03:15:04PM +, SЬren Schmidt wrote: > Modified files: > sys/dev/ata ata-all.c ata-dma.c > Log: > Fix the breakage that caused AHCI devices to vanish. Editor droppings :( Even with this change ATA driver still can't mount root. ata* disks are not visi

Re: cvs commit: src/sys/sys cpuset.h src/sys/kern kern_cpuset.c makesyscalls.sh syscalls.master

2008-03-25 Thread Andrey Chernov
On Tue, Mar 25, 2008 at 09:11:53AM +, Ruslan Ermilov wrote: > ru 2008-03-25 09:11:53 UTC > > FreeBSD src repository > > Modified files: > sys/sys cpuset.h > sys/kern kern_cpuset.c makesyscalls.sh > syscalls.master > L

Re: cvs commit: src/sys/sys param.h src/gnu/usr.bin/binutils/ar Makefile src/gnu/usr.bin/binutils/ranlib Makefile src/usr.bin Makefile

2008-02-21 Thread Andrey Chernov
On Thu, Feb 21, 2008 at 04:12:46PM +, Kai Wang wrote: > kaiw2008-02-21 16:12:46 UTC > > FreeBSD src repository > > Modified files: > sys/sys param.h > gnu/usr.bin/binutils/ar Makefile > gnu/usr.bin/binutils/ranlib Makefile > usr.bin Mak

Re: cvs commit: src/lib/libc/resolv res_comp.c

2008-02-15 Thread Andrey Chernov
On Sat, Feb 16, 2008 at 12:16:49AM +, Xin LI wrote: > delphij 2008-02-16 00:16:49 UTC > > FreeBSD src repository > > Modified files: > lib/libc/resolv res_comp.c > Log: > Allow underscore in domain names while resolving. While having underscore > is a violation of RFC

Re: cvs commit: src/share/colldef el_GR.ISO8859-7.src

2008-02-04 Thread Andrey Chernov
On Mon, Feb 04, 2008 at 08:07:10PM +0200, Diomidis Spinellis wrote: > BTW, as evidenced by > > ls -l /usr/share/locale/*.UTF-8/LC_COLLATE > > we don't support collation for UTF-8 locales. Is anyone planning to > integrate http://unicode.org/reports/tr10/? If not, I could take this on, > in a

Re: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y

2008-01-22 Thread Andrey Chernov
On Wed, Jan 23, 2008 at 02:18:31AM +0300, Andrey Chernov wrote: > > mklocale(1) is a tool used during buildworld. Am I right > > that after this commit it should be bootstrapped (i.e., > > a new version should be built and used instead of the > > currently installed on

Re: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y

2008-01-22 Thread Andrey Chernov
On Tue, Jan 22, 2008 at 10:08:25PM +0300, Ruslan Ermilov wrote: > On Tue, Jan 22, 2008 at 12:04:53AM +, Andrey A. Chernov wrote: > > ache2008-01-22 00:04:52 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/mklocale mklocale.1 yacc.y > > Log: > >

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-12-12 Thread Andrey Chernov
On Wed, Dec 12, 2007 at 06:11:50AM +, Kip Macy wrote: > kmacy 2007-12-12 06:11:50 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_syncache.c > Log: > Remove spurious timestamp check. RFC 1323 explicitly states that timestamps > MAY > be tran

Re: cvs commit: src/lib Makefile src/share/mk bsd.own.mk src/tools/build/options WITHOUT_KERBEROS WITH_GSSAPI

2007-12-10 Thread Andrey Chernov
On Mon, Dec 10, 2007 at 07:09:25PM +, Doug Barton wrote: > dougb 2007-12-10 19:09:24 UTC > > FreeBSD src repository > > Modified files: > lib Makefile > share/mk bsd.own.mk > tools/build/options WITHOUT_KERBEROS > Added files: > too

Re: cvs commit: src/tools/regression/lib/libc/stdio test-printfloat.c test-scanfloat.c

2007-12-03 Thread Andrey Chernov
On Mon, Dec 03, 2007 at 02:22:14AM -0500, David Schultz wrote: > On Mon, Dec 03, 2007, David Schultz wrote: > > das 2007-12-03 07:18:47 UTC > > > > FreeBSD src repository > > > > Modified files: > > tools/regression/lib/libc/stdio test-printfloat.c > >

Re: cvs commit: src/lib/libc/locale none.c

2007-11-26 Thread Andrey Chernov
On Mon, Nov 26, 2007 at 01:50:06PM +0800, Rong-En Fan wrote: > Please blame me for all these ctype fix in 6.x and 7.x. > Andrey fixes them in CURRENT, it's me who do the MFC. IMHO the only fault was to MFC it to 6x, and only because of habbit to install slightly different ports system, i.e from 6

Re: cvs commit: src/share/mk bsd.sys.mk sys.mk

2007-11-22 Thread Andrey Chernov
On Thu, Nov 22, 2007 at 11:21:13PM +, John Birrell wrote: > This time, change the default CFLAGS to match the simple defaults that > the tinderboxes use. That is, don't use -fno-strict-aliasing by default. How it will affect the ports system? -- http://ache.pp.ru/ ___

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Thu, Nov 01, 2007 at 04:06:39AM +0100, Christoph Mallon wrote: > Andrey Chernov wrote: >> On Thu, Nov 01, 2007 at 02:44:25AM +0100, Christoph Mallon wrote: >>> Also the example is still unrealistic: You usually don't multiply chars >>> by two. Lets try something

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Thu, Nov 01, 2007 at 02:52:13AM +0100, Christoph Mallon wrote: >> 2. _c & ~0x7F comes right from is{w}ascii() so there is no such enormously >> big problems to decifer. I just want to keep all ctype in style. > > Repeating cryptic code does not make it better, IMO. This issue is completely non

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Thu, Nov 01, 2007 at 02:44:25AM +0100, Christoph Mallon wrote: > Also the example is still unrealistic: You usually don't multiply chars by > two. Lets try something more realistic: an ASCII filter > > int filter_ascii0(int c) > { > return c < 0 || c >= 128 ? '?' : c; > } > > int filt

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Thu, Nov 01, 2007 at 01:48:19AM +0300, Andrey Chernov wrote: > > > 2. It also breaks common style ctype using for is{w}ascii(). If revert > > > this, is{w}ascii() should be rewritted too. > > > > That seems reasonable. > > Well, I don't want to fight

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Wed, Oct 31, 2007 at 12:43:13PM -1000, Juli Mallett wrote: > > 1. Reader-friendly version generates long code when absolutely no > > optimization used in compiler (for some reason f.e. to avoid optimization > > bugs). > > So if someone is trying to avoid compiler optimization bugs we should s

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Thu, Nov 01, 2007 at 03:23:56AM +1100, Bruce Evans wrote: > In fact, one of the cleanups/optimizations in rev.1.5 and 1.6 by ache > and me was to get rid of the mask. There was already a check for _c > < 0, so the mask cost even more. The top limit was 256 instead of > 128, so the point about

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Wed, Oct 31, 2007 at 10:33:49PM +, Alexey Dokuchaev wrote: > > For ones who doubts there two tests compiled with -O2. As you may see the > > result is almost identical (andl vs cmpl): > > Q.E.D. How about to restore original, more reader-friendly version then? 1. Reader-friendly version

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Tue, Oct 30, 2007 at 10:03:31AM -1000, Juli Mallett wrote: > Is there a specific expensive instruction you're trying to avoid? > For such thoroughyl bit-aligned range checks, you shouldn't even get a branch > for the former case. Is there a platform other than i386 I should look at > where > t

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Tue, Oct 30, 2007 at 06:44:46AM +, Alexey Dokuchaev wrote: > On Mon, Oct 29, 2007 at 09:48:16PM +0100, Christoph Mallon wrote: > > Andrey A. Chernov wrote: > > >ache2007-10-27 22:32:28 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > >include

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Mon, Oct 29, 2007 at 09:48:16PM +0100, Christoph Mallon wrote: > Andrey A. Chernov wrote: >> ache2007-10-27 22:32:28 UTC >> FreeBSD src repository >> Modified files: >> include _ctype.h Log: >> Micro-optimization of prev. commit, change >> (_c < 0 || _c >= 128)

Re: cvs commit: src/include _ctype.h

2007-10-31 Thread Andrey Chernov
On Tue, Oct 30, 2007 at 10:03:31AM -1000, Juli Mallett wrote: > * "Andrey A. Chernov" <[EMAIL PROTECTED]> [ 2007-10-27 ] > [ cvs commit: src/include _ctype.h ] > > ache2007-10-27 22:32:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > include _ct

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-31 Thread Andrey Chernov
On Wed, Oct 31, 2007 at 09:41:13PM +1100, Bruce Evans wrote: > Now the limit is spelled 128, so it really is constant and won't cause > problems unless the constant changes. Only in one particular case, the rest cases still need __mb_sb_limit. > _ctype.h still declares __mb_sb_limit but now doesn

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-26 Thread Andrey Chernov
On Fri, Oct 26, 2007 at 04:26:41PM -0700, John-Mark Gurney wrote: > > Although standard permits functions only, I object against permanent > > removing inlines from ctype. Almost every system have them as macros or > > inlines and not as function calls, and it is for reason. Ctype functions > >

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-26 Thread Andrey Chernov
On Fri, Oct 26, 2007 at 10:41:14AM -0700, LI Xin wrote: > rafan@ has a patch that implements Warner's suggestion by removing the > inline's from _ctype.h and the macros from ctype.h, and is testing the > impact. Basically the approach do the following: > > - Keep __mb_sb_limit intact. It is use

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-26 Thread Andrey Chernov
On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote: > As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore > the compatibility as 1) 7.0 is not released yet, 2) we don't promise > anything in > HEAD branch. However, if most people think get rid of inline stuffs and > have

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-26 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 06:12:16PM -0600, M. Warner Losh wrote: > Maybe we should make them *NOT* be inline instead of all these > kludges? In case we trade compatibility for slowdown in some apps, yes. They are inlines for reason, almost every system have them as inlines. -- http://ache.pp.ru/

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 11:57:09PM +0400, Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 03:31:20PM -0400, Daniel Eischen wrote: > >> Although standard permit this, it will cause lots of programs to break > >> here and there and even may cause core dump. I don't think

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 03:17:32PM -0400, Daniel Eischen wrote: > Why not simply avoid the error check for inlines. Solaris > doesn't seem to add a check, it just does the conversion. > The non-inlined versions do error checking. I already answer that several times. Nobody wants 80% programs ethe

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 03:31:20PM -0400, Daniel Eischen wrote: >> Although standard permit this, it will cause lots of programs to break >> here and there and even may cause core dump. I don't think it is what >> everybody wants. Non-inlined versions a) not used nowdays b) must be exact >> as inli

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 12:20:16PM -0700, LI Xin wrote: > Daniel Eischen wrote: > > Why not simply avoid the error check for inlines. Solaris > > doesn't seem to add a check, it just does the conversion. > > The non-inlined versions do error checking. > > I'll take a look at this and provide a pa

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 03:17:32PM -0400, Daniel Eischen wrote: > Why not simply avoid the error check for inlines. Solaris > doesn't seem to add a check, it just does the conversion. > The non-inlined versions do error checking. Although standard permit this, it will cause lots of programs to br

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 12:15:13PM -0700, LI Xin wrote: > Andrey Chernov wrote: > > On Thu, Oct 25, 2007 at 12:30:07PM -0600, Scott Long wrote: > [snip] > >> and is causing many users problems > >> during upgrades and normal operations. > > > > Like

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 01:10:13PM -0600, Scott Long wrote: >> Well, I think the problem is not exposing a new symbol by itself, but >> __mb_sb_limit is being used in _ctype.h, in a form of __inline >> functions. Therefore, the change will break new binaries running on >> older systems. Personall

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 12:05:40PM -0700, LI Xin wrote: > Well, I think the problem is not exposing a new symbol by itself, but > __mb_sb_limit is being used in _ctype.h, in a form of __inline > functions. Therefore, the change will break new binaries running on > older systems. Yes. Only vice

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 12:30:07PM -0600, Scott Long wrote: > Exposing the __mb_sb_limit symbol has instantly created a need > to have a compat7x package, Yes. We supposed to do this in any case. > and is causing many users problems > during upgrades and normal operations. Like what? I don't

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 09:44:06AM -0700, LI Xin wrote: > Andrey Chernov wrote: > > On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: > >> Andrey A. Chernov wrote: > >>> ache2007-10-15 09:51:30 UTC > >>> FreeBSD src repository > &g

Re: cvs commit: src/lib/libc/locale utf8.c

2007-10-25 Thread Andrey Chernov
On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: > Andrey A. Chernov wrote: >> ache2007-10-15 09:51:30 UTC >> FreeBSD src repository >> Modified files: >> lib/libc/locale utf8.c Log: >> Add comment explaining __mb_sb_limit trick here. >> Revision Changes

Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/shar

2007-10-18 Thread Andrey Chernov
On Thu, Oct 18, 2007 at 01:33:22AM -0700, John-Mark Gurney wrote: > > (in general sensor can be more complicated than single integer) why > > If it's more complicated then that's different, but from my understanding > of the OpenBSD sensor framework is that you'd end up breaking those > "complica

Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/shar

2007-10-17 Thread Andrey Chernov
On Wed, Oct 17, 2007 at 08:38:10PM -0400, Constantine A. Murenin wrote: > Thus the two-layered version of the framework (sensordev/sensor) defines > its own namespace. Granted, on OpenBSD this is much more valuable than it > is on FreeBSD, since FreeBSD already has dynamic sysctl mechanism (whic

Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/shar

2007-10-17 Thread Andrey Chernov
On Wed, Oct 17, 2007 at 05:00:33PM -0700, John-Mark Gurney wrote: > > Why not to put them under DEVFS like /dev/sensors/* ? They are devices > > after all. I agree that putting devices under sysctl.* is bad idea. > > a) How does a userland driver present a DEVFS/device instance? > > b) For expor

Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/shar

2007-10-17 Thread Andrey Chernov
gOn Tue, Oct 16, 2007 at 06:40:47PM +0200, Alexander Leidinger wrote: >> like /var/run/log or /var/run/devd.pipe, that a userland daemon running >> as root that has access to ISA I/O and related resources... It's >> that simple... > > And the code doesn't exists. And when it is written, when will

Re: cvs commit: src/usr.bin/awk Makefile b.c.diff lib.c.diff main.c.diff run.c.diff tran.c.diff src/contrib/one-true-awk b.c lib.c main.c run.c tran.c

2007-10-09 Thread Andrey Chernov
On Tue, Oct 09, 2007 at 11:27:17AM -0700, LI Xin wrote: > David has mentioned in a private e-mail about this change that, the > patchset is intended for adoption by upstream, and I think it will be > eventually be merged into the vendor branch. Anyway the CVS HEAD was > not touched so this is not

Re: cvs commit: src/usr.bin/awk Makefile b.c.diff lib.c.diff main.c.diff run.c.diff tran.c.diff src/contrib/one-true-awk b.c lib.c main.c run.c tran.c

2007-10-09 Thread Andrey Chernov
On Tue, Oct 09, 2007 at 03:28:15PM +, David E. O'Brien wrote: > obrien 2007-10-09 15:28:15 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > usr.bin/awk Makefile > contrib/one-true-awk b.c lib.c main.c run.c tran.c > Removed files:

Re: cvs commit: ports/graphics/ImageMagick Makefile

2007-09-28 Thread Andrey Chernov
On Fri, Sep 28, 2007 at 03:32:15PM -0400, Mikhail Teterin wrote: > п'ятниця 28 вересень 2007 03:21 по, Andrey Chernov Ви написали: > > On Fri, Sep 28, 2007 at 02:15:18PM -0400, Mikhail Teterin wrote: > > > Could you, please, send the (link to) log of test failure(s)? I'

Re: cvs commit: ports/graphics/ImageMagick Makefile

2007-09-28 Thread Andrey Chernov
On Fri, Sep 28, 2007 at 02:15:18PM -0400, Mikhail Teterin wrote: > Could you, please, send the (link to) log of test failure(s)? I'm aware of > one > problem -- OpenEXR's libIlmThread.so wants pthread_* functions, which perl > does not have by default. Only that two: FAIL: Magick++/tests/excep

Re: cvs commit: ports/graphics/ImageMagick Makefile

2007-09-28 Thread Andrey Chernov
On Fri, Sep 28, 2007 at 02:23:16AM +, Mikhail Teterin wrote: > Initiate the lists of options whose presence (or absence) break > self-tests, and set IGNORE, if any such conflict is found. PERL support enabled breaks self-tests too for the reason unknown (Magic.pm works as expected) -- h

Re: cvs commit: src/bin/df df.c src/bin/sh var.c src/include stdlib.h src/libexec/pppoed pppoed.c src/sys/sys param.h src/lib/libc/stdlib Makefile.inc getenv.3 getenv.c putenv.c setenv.c src/tools/reg

2007-07-04 Thread Andrey Chernov
On Wed, Jul 04, 2007 at 06:42:49PM +0400, Andrey Chernov wrote: > On Wed, Jul 04, 2007 at 12:00:41AM +, Sean Farley wrote: > > Several patches to base utilities to handle the POSIX changes from > > Andrey Chernov's previous commit. A few I re-wrote to use setenv() >

Re: cvs commit: src/bin/df df.c src/bin/sh var.c src/include stdlib.h src/libexec/pppoed pppoed.c src/sys/sys param.h src/lib/libc/stdlib Makefile.inc getenv.3 getenv.c putenv.c setenv.c src/tools/reg

2007-07-04 Thread Andrey Chernov
On Wed, Jul 04, 2007 at 12:00:41AM +, Sean Farley wrote: > Several patches to base utilities to handle the POSIX changes from > Andrey Chernov's previous commit. A few I re-wrote to use setenv() > instead of putenv(). Replacing putenv() with setenv() should care about the case when pute

Re: cvs commit: src/share/mk sys.mk

2007-06-27 Thread Andrey Chernov
On Wed, Jun 27, 2007 at 09:47:56PM +0800, Xin LI wrote: > Nitpicking: I think -O1 implies no strict-aliasing. So -O1 -pipe might > be just Ok. It is for easy change-back. > Well, I'd say that all these changes looks scary to me. > > Is there any code in our base system to trigger tree-vrp bug?

Re: cvs commit: src/share/mk sys.mk

2007-06-27 Thread Andrey Chernov
On Wed, Jun 27, 2007 at 11:39:34AM +0200, Harti Brandt wrote: > On Wed, 27 Jun 2007, Kostik Belousov wrote: > > KB>On Tue, Jun 26, 2007 at 07:10:21PM +, Andrey A. Chernov wrote: > KB>> ache2007-06-26 19:10:21 UTC > KB>> > KB>> FreeBSD src repository > KB>> > KB>> Modified files:

Re: cvs commit: ports/misc/astrolog Makefile

2007-06-26 Thread Andrey Chernov
On Tue, Jun 26, 2007 at 05:06:21PM +0800, LI Xin wrote: > Andrey A. Chernov wrote: > > ache2007-06-26 09:00:46 UTC > > > > FreeBSD ports repository > > > > Modified files: > > misc/astrologMakefile > > Log: > > Back out v1.33 because it requires unzip presence at 'ins

Re: cvs commit: ports/misc/astrolog Makefile

2007-06-23 Thread Andrey Chernov
On Sat, Jun 23, 2007 at 11:28:10AM +0200, Erwin Lansing wrote: > On Sat, Jun 23, 2007 at 02:33:30AM +, Andrey A. Chernov wrote: > > ache2007-06-23 02:33:29 UTC > > > > FreeBSD ports repository > > > > Modified files: > > misc/astrologMakefile > > Log: > > Remove a

Re: cvs commit: src/lib/libarchive archive_read_open_fd.c archive_read_open_filename.c

2007-06-18 Thread Andrey Chernov
On Mon, Jun 18, 2007 at 09:20:57PM -0700, Tim Kientzle wrote: > into whether a particular lseek() request is acceptable. > Many devices can do relative but not absolute seeks. Ah, I understand the problem and it is not related to drivers but misunderstanding what lseek does. lseek changes _virt

Re: cvs commit: src/lib/libarchive archive_read_open_fd.c archive_read_open_filename.c

2007-06-17 Thread Andrey Chernov
On Sun, Jun 17, 2007 at 09:52:10PM -0700, Tim Kientzle wrote: > Colin Percival wrote: > > Tim Kientzle wrote: > >> I fear I'll have to avoid seeks ... tape drives on > >> FreeBSD seem to return garbage from lseek(). > > Is there any reason why the tape drivers can't be fixed? > > Since people

Re: cvs commit: ports/news/tin Makefile

2007-06-14 Thread Andrey Chernov
On Thu, Jun 14, 2007 at 09:14:46PM +0400, Andrew Pantyukhin wrote: > 70-700033 don't support ncursesw. If you're I think OSVERSION check is used only for released or stable branches. -current development people are supposed to bring their system to the latest, isn't? > LIB_DEPENDS+= ncur

Re: cvs commit: src/usr.sbin/sysinstall main.c

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 12:10:11PM -0400, John Baldwin wrote: > Now, that said, apparently some folks on this list CAN'T READ. > > Linux has the new putenv() algorithm already, so if any software breaks with > this, it is _ALREADY_ broken on Linux. Please consider that before ripping > ache@ a

Re: cvs commit: src/usr.sbin/sysinstall main.c

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 08:33:56PM +0200, Alexander Leidinger wrote: > And may I remind you that we talk about following POSIX so most of the > programs we have in the ports should be ok? I think so too. > I agree that it may have been more nice if there was a HEADS-UP first > (the age old behavi

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c...

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 01:53:17PM -0400, Garance A Drosehn wrote: > But I expect the fixes to *other* programs (such as usr.bin/env) > could be committed without causing any trouble for anyone. If > that's true, then we might as well leave those changes in. Yes, they could, they are backward-

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pst

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 01:12:12PM -0400, Daniel Eischen wrote: > > Not because I admit they are technically wrong and not because of bug > > reports (I receive nothing). But because I surprisingly meets so > > strong opposition and resistance so lost any desire to continue that. > > Uh, pleas

  1   2   3   >