Re: cvs commit: src/libexec/pppoed pppoed.c

2007-05-01 Thread Ken Smith
On Tue, 2007-05-01 at 04:16 +0400, Andrey Chernov wrote: > Kris, could you please run test build for ports with all changes up to > sys/param.h in? I want to see how many ports will failed if any. > Personally me run lots of ports of my machine and didn't notice any bad > side effect yet. For

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 10:55:31AM +0200, Henrik Brix Andersen wrote: > Perhaps I missed something - but as far as I can tell, just compiling > the ports will not reveal problems related to these *env() changes? Yes, not all problems will be revealed by just compiling (running ports will), but we

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-05-01 Thread Henrik Brix Andersen
On Mon, Apr 30, 2007 at 08:50:07PM -0400, Kris Kennaway wrote: > On Tue, May 01, 2007 at 04:16:27AM +0400, Andrey Chernov wrote: > > Kris, could you please run test build for ports with all changes up to > > sys/param.h in? I want to see how many ports will failed if any. > > Personally me run lo

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Kris Kennaway
On Tue, May 01, 2007 at 04:16:27AM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote: > > On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > > > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > > > What impact is this going

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2007 at 03:52:37PM -0400, Kris Kennaway wrote: > On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > > What impact is this going to have on ports? Surely there are lots of > > > them that use putenv(

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Kris Kennaway
On Mon, Apr 30, 2007 at 11:15:55PM +0400, Andrey Chernov wrote: > On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > > What impact is this going to have on ports? Surely there are lots of > > them that use putenv(). > > If they work under Linux, they already forced to do the right

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2007 at 03:11:45PM -0400, Kris Kennaway wrote: > What impact is this going to have on ports? Surely there are lots of > them that use putenv(). If they work under Linux, they already forced to do the right thing. Only those which are BSD-only may fail. > Can I assume you're in

Re: cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Kris Kennaway
On Mon, Apr 30, 2007 at 12:27:58PM +, Andrey A. Chernov wrote: > ache2007-04-30 12:27:58 UTC > > FreeBSD src repository > > Modified files: > libexec/pppoed pppoed.c > Log: > Prepare for upcoming POSIXed putenv() rewrite: > don't allow putenv() arg be on the stack

cvs commit: src/libexec/pppoed pppoed.c

2007-04-30 Thread Andrey A. Chernov
ache2007-04-30 12:27:58 UTC FreeBSD src repository Modified files: libexec/pppoed pppoed.c Log: Prepare for upcoming POSIXed putenv() rewrite: don't allow putenv() arg be on the stack, replace putenv() with setenv() Revision ChangesPath 1.25 +4 -4