cvs commit: src/sys/i386/include atomic.h

2006-12-29 Thread Bruce Evans
bde 2006-12-29 15:48:18 UTC FreeBSD src repository Modified files: sys/i386/include atomic.h Log: Fix oops in previous commit. Revision ChangesPath 1.47 +1 -1 src/sys/i386/include/atomic.h ___ cvs-all@freeb

cvs commit: src/sys/i386/include atomic.h

2006-10-22 Thread Bruce Evans
bde 2006-10-22 07:00:07 UTC FreeBSD src repository Modified files:(Branch: RELENG_4) sys/i386/include atomic.h Log: MFC: parts of the following, so that atomic.h in RELENG_4 can be compiled by RELENG_6's compiler: 1.26: pass constraints as a parameter since ch

cvs commit: src/sys/i386/include atomic.h

2006-10-21 Thread Bruce Evans
bde 2006-10-21 11:09:50 UTC FreeBSD src repository Modified files:(Branch: RELENG_4) sys/i386/include atomic.h Log: Remove special support for gcc <= 2.8 so that the next change is more readable. gcc-2.8 was last sighted in FreeBSD-3 and wasn't the system com

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > The different placement of volatile broken sparc64 though. However, > an MI wrapper would work around that issue. I can pursue a patch > that adds the wrapper unless one of you two wants to do it. I'll handle it. > I really wish you'd have spoken up ea

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > On Tuesday 28 March 2006 14:28, Dag-Erling Smørgrav wrote: > > which uses uintptr_t, not actual pointers, to avoid warnings. In > > effect, that code is broken. > No, it's on _purpose_, because we do arithmetic on the value (setting > flags, etc.) We hap

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 15:28, John Baldwin wrote: > On Tuesday 28 March 2006 15:04, Daniel Eischen wrote: > > On Tue, 28 Mar 2006, Dag-Erling [iso-8859-1] Smørgrav wrote: > > > > > John Baldwin <[EMAIL PROTECTED]> writes: > > > > s/off/on/ I trust > > > > > > > > Not true. The tinderbox would a

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 15:04, Daniel Eischen wrote: > On Tue, 28 Mar 2006, Dag-Erling [iso-8859-1] Smørgrav wrote: > > > John Baldwin <[EMAIL PROTECTED]> writes: > > > s/off/on/ I trust > > > > > > Not true. The tinderbox would attest to that. Please see code such as > > > this: [...] > > > >

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Daniel Eischen
On Tue, 28 Mar 2006, Dag-Erling [iso-8859-1] Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > s/off/on/ I trust > > > > Not true. The tinderbox would attest to that. Please see code such as > > this: [...] > > which uses uintptr_t, not actual pointers, to avoid warnings. In > eff

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 14:28, Dag-Erling Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > On Tuesday 28 March 2006 13:05, Dag-Erling Smørgrav wrote: > > > John Baldwin <[EMAIL PROTECTED]> writes: > > > > One reason for not having the casts, btw, is that you lose type > > > > checkin

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > On Tuesday 28 March 2006 13:05, Dag-Erling Smørgrav wrote: > > John Baldwin <[EMAIL PROTECTED]> writes: > > > One reason for not having the casts, btw, is that you lose type > > > checking. > > Huh? Before my patch, any use of atomic_*_ptr with warnings t

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 13:05, Dag-Erling Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > One reason for not having the casts, btw, is that you lose type > > checking. > > Huh? Before my patch, any use of atomic_*_ptr with warnings turned > off would result in a slew of warnings b

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > One reason for not having the casts, btw, is that you lose type > checking. Huh? Before my patch, any use of atomic_*_ptr with warnings turned off would result in a slew of warnings because you'd be passing pointers to a function which is declared to tak

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 11:30, Dag-Erling Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > On Tuesday 28 March 2006 09:34, Dag-Erling Smorgrav wrote: > > > Log: > > > Use wrapper macros for atomic pointer operations in order to perform the > > > correct casts. This should prob

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smørgrav
John Baldwin <[EMAIL PROTECTED]> writes: > On Tuesday 28 March 2006 09:34, Dag-Erling Smorgrav wrote: > > Log: > > Use wrapper macros for atomic pointer operations in order to perform the > > correct casts. This should probably be merged to other architectures. > It should really be uintptr_

Re: cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread John Baldwin
On Tuesday 28 March 2006 09:34, Dag-Erling Smorgrav wrote: > des 2006-03-28 14:34:48 UTC > > FreeBSD src repository > > Modified files: > sys/i386/include atomic.h > Log: > Use wrapper macros for atomic pointer operations in order to perform the > correct casts. This s

cvs commit: src/sys/i386/include atomic.h

2006-03-28 Thread Dag-Erling Smorgrav
des 2006-03-28 14:34:48 UTC FreeBSD src repository Modified files: sys/i386/include atomic.h Log: Use wrapper macros for atomic pointer operations in order to perform the correct casts. This should probably be merged to other architectures. Revision ChangesPa