cvs commit: src/sys/kern kern_fork.c

2008-07-30 Thread Konstantin Belousov
kib 2008-07-30 09:44:40 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern kern_fork.c Log: SVN rev 180991 on 2008-07-30 09:44:40Z by kib MFC r180738: Do the pargs_hold() on the copy of the pointer to the p_args of the child

cvs commit: src/sys/kern kern_fork.c

2008-07-23 Thread Konstantin Belousov
kib 2008-07-23 08:45:25 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: SVN rev 180738 on 2008-07-23 08:45:25Z by kib Do the pargs_hold() on the copy of the pointer to the p_args of the child process immediately after bulk bcopy()

cvs commit: src/sys/kern kern_fork.c

2008-03-23 Thread Konstantin Belousov
kib 2008-03-23 06:52:01 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern kern_fork.c Log: MFC rev. 1.292: Fix the leak of the vmspace on the fork when the process limits are exceeded. Revision ChangesPath 1.282.2.3

cvs commit: src/sys/kern kern_fork.c

2008-03-20 Thread Konstantin Belousov
kib 2008-03-20 15:24:49 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Fix the leak of the vmspace on the fork when the process limits are exceeded. Pointy hat to: me MFC after: 3 days Revision ChangesPath 1.292

cvs commit: src/sys/kern kern_fork.c

2008-03-19 Thread Jeff Roberson
jeff2008-03-20 03:05:17 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: - Don't call the empty sched_newproc() function. sched_newproc() already existed as sched_fork() which is a non empty function in both schedulers. Revision

cvs commit: src/sys/kern kern_fork.c

2007-11-14 Thread Julian Elischer
julian 2007-11-15 02:13:45 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: When forking, the new thread deserves a name too. Don't just use the td_startcopy section as it is not the right thing to do in other cases (e.g. if starting a new

cvs commit: src/sys/kern kern_fork.c

2007-11-05 Thread Julian Elischer
julian 2007-11-06 02:59:40 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern kern_fork.c Log: MFC of removal of single threading code from the main fork path. This turns out to be un-needed, and in fact can produce deadlocks.

cvs commit: src/sys/kern kern_fork.c

2007-11-05 Thread Julian Elischer
julian 2007-11-06 03:01:33 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern kern_fork.c Log: MFC of un-neede singl-threading code. Revision ChangesPath 1.252.2.7 +0 -42 src/sys/kern/kern_fork.c

cvs commit: src/sys/kern kern_fork.c

2007-11-02 Thread Julian Elischer
julian 2007-11-02 19:40:36 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Completely remove the code for single threading the mainline fork code. Put in a little comment explaining why it went away. Re-enable it in the case there an

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Dag-Erling Smørgrav
Julian Elischer [EMAIL PROTECTED] writes: This removes a reproducible lockup in NFS. Could you elaborate on that? DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Julian Elischer
Dag-Erling Smørgrav wrote: Julian Elischer [EMAIL PROTECTED] writes: This removes a reproducible lockup in NFS. Could you elaborate on that? DES facts: There is an error in the single-threading mode selected in fork (some optimization code that was added at some time (maybe by me))

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread David Xu
Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the single-threading code in fork. After discussions with jeff, alc, (various Ironport people), david Xu, and mostly Alfred (who

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Alfred Perlstein
* David Xu [EMAIL PROTECTED] [071024 18:34] wrote: Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the single-threading code in fork. After discussions with jeff, alc,

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread David Xu
Alfred Perlstein wrote: * David Xu [EMAIL PROTECTED] [071024 18:34] wrote: Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the single-threading code in fork. After discussions with jeff,

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Alfred Perlstein
* David Xu [EMAIL PROTECTED] [071024 19:32] wrote: Alfred Perlstein wrote: * David Xu [EMAIL PROTECTED] [071024 18:34] wrote: Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread David Xu
Alfred Perlstein wrote: thread_suspend_check() with SINGLE_BOUNDARY is used is only called in userret() where I don't think any code is still using the p_fd. This is not an acceptable solution as it will deadlock unless all threads exit the kernel. Where is deadlock ?

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Alfred Perlstein
* David Xu [EMAIL PROTECTED] [071024 19:40] wrote: Alfred Perlstein wrote: thread_suspend_check() with SINGLE_BOUNDARY is used is only called in userret() where I don't think any code is still using the p_fd. This is not an acceptable solution as it will deadlock unless all threads exit

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Julian Elischer
Alfred Perlstein wrote: * David Xu [EMAIL PROTECTED] [071024 19:32] wrote: Alfred Perlstein wrote: * David Xu [EMAIL PROTECTED] [071024 18:34] wrote: Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log:

Re: cvs commit: src/sys/kern kern_fork.c

2007-10-24 Thread Julian Elischer
Alfred Perlstein wrote: * David Xu [EMAIL PROTECTED] [071024 18:34] wrote: Julian Elischer wrote: julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the single-threading code in fork. After discussions with

cvs commit: src/sys/kern kern_fork.c

2007-10-23 Thread Julian Elischer
julian 2007-10-23 17:54:16 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Take out the single-threading code in fork. After discussions with jeff, alc, (various Ironport people), david Xu, and mostly Alfred (who found the problem) it has

Re: cvs commit: src/sys/kern kern_fork.c kern_proc.c sched_4bsd.c sched_ule.c src/sys/sys proc.h

2007-09-21 Thread Kostik Belousov
On Fri, Sep 21, 2007 at 04:10:23AM +, Jeff Roberson wrote: jeff2007-09-21 04:10:23 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c kern_proc.c sched_ule.c sched_4bsd.c sys/sys proc.h Log:

Re: cvs commit: src/sys/kern kern_fork.c kern_proc.c sched_4bsd.c sched_ule.c src/sys/sys proc.h

2007-09-21 Thread Jeff Roberson
On Fri, 21 Sep 2007, Kostik Belousov wrote: On Fri, Sep 21, 2007 at 04:10:23AM +, Jeff Roberson wrote: jeff2007-09-21 04:10:23 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c kern_proc.c sched_ule.c sched_4bsd.c

cvs commit: src/sys/kern kern_fork.c kern_proc.c sched_4bsd.c sched_ule.c src/sys/sys proc.h

2007-09-20 Thread Jeff Roberson
jeff2007-09-21 04:10:23 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c kern_proc.c sched_ule.c sched_4bsd.c sys/sys proc.h Log: - Redefine p_swtime and td_slptime as p_swtick and td_slptick. This

cvs commit: src/sys/kern kern_fork.c kern_resource.c

2007-07-20 Thread Xin LI
delphij 2007-07-20 15:29:35 UTC FreeBSD src repository Modified files:(Branch: RELENG_5) sys/kern kern_fork.c kern_resource.c Log: MFC: Close race conditions between fork() and [sg]etpriority()'s PRIO_USER case, and possibly also other places that deference

cvs commit: src/sys/kern kern_fork.c kern_resource.c

2007-07-19 Thread John Baldwin
jhb 2007-07-19 18:46:32 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern kern_fork.c kern_resource.c Log: MFC: Close race conditions between fork() and [sg]etpriority()'s PRIO_USER case, and possibly also other places that deference

cvs commit: src/sys/kern kern_fork.c sched_4bsd.c sched_ule.c

2007-06-12 Thread Jeff Roberson
jeff2007-06-12 07:47:09 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c sched_4bsd.c sched_ule.c Log: - Move some common code out of sched_fork_exit() and back into fork_exit(). Revision ChangesPath 1.279 +12 -0

cvs commit: src/sys/kern kern_fork.c

2007-06-04 Thread Jeff Roberson
jeff2007-06-04 23:53:34 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Commit 6/14 of sched_lock decomposition. - Use thread_lock() rather than sched_lock for per-thread scheduling sychronization. - Use the per-process spinlock

cvs commit: src/sys/kern kern_fork.c

2007-05-18 Thread Robert Watson
rwatson 2007-05-18 21:10:08 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Remove unnecessary assignment. CID:2227 Found with: Coverity Prevent(tm) Revision ChangesPath 1.272 +0 -2

Re: cvs commit: src/sys/kern kern_fork.c kern_resource.c

2007-03-11 Thread Don Lewis
On 26 Feb, Xin LI wrote: delphij 2007-02-26 03:38:10 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c kern_resource.c Log: Close race conditions between fork() and [sg]etpriority()'s PRIO_USER case, possibly also other places that deferences

cvs commit: src/sys/kern kern_fork.c src/sys/isa syscons_isa.c src/sys/pc98/cbus syscons_cbus.c

2007-02-27 Thread John Baldwin
jhb 2007-02-27 17:22:30 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c sys/isa syscons_isa.c sys/pc98/cbussyscons_cbus.c Log: Use pause() rather than tsleep() on explicit global dummy variables. Revision

cvs commit: src/sys/kern kern_fork.c kern_resource.c

2007-02-25 Thread Xin LI
delphij 2007-02-26 03:38:10 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c kern_resource.c Log: Close race conditions between fork() and [sg]etpriority()'s PRIO_USER case, possibly also other places that deferences p_ucred. In the past, we

cvs commit: src/sys/kern kern_fork.c

2006-09-04 Thread Pawel Jakub Dawidek
pjd 2006-09-04 10:26:17 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern kern_fork.c Log: MFC:sys/kern/kern_fork.c1.259 - Use suser_cred(9) instead of checking cr_ruid directly. - For privileged processes safe two mutex

cvs commit: src/sys/kern kern_fork.c

2006-08-01 Thread John Baldwin
jhb 2006-08-01 15:30:56 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Don't lock each of the processes while looking for a pid. The allproc and proctree locks that we already hold provide sufficient protection. Revision Changes

cvs commit: src/sys/kern kern_fork.c

2006-06-27 Thread Pawel Jakub Dawidek
pjd 2006-06-27 11:28:50 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: - Use suser_cred(9) instead of checking cr_ruid directly. - For privileged processes safe two mutex operations. We may want to consider if this is good idea to use

cvs commit: src/sys/kern kern_fork.c

2006-03-18 Thread David Xu
davidxu 2006-03-18 23:37:36 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern kern_fork.c Log: MFC revision 1.258. Approved by: re (mux) Revision ChangesPath 1.252.2.1 +17 -1 src/sys/kern/kern_fork.c

cvs commit: src/sys/kern kern_fork.c

2006-03-15 Thread David Xu
davidxu 2006-03-15 23:24:14 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Fix a race between file operations and rfork(RFCFDG) by parking all other threads at user boundary, the race can crash kernel under stress testing. Reviewed by:

cvs commit: src/sys/kern kern_fork.c

2006-02-06 Thread John Baldwin
jhb 2006-02-06 21:54:48 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: We don't need the proc lock to check P_KTHREAD on curthread since it is only set before the kthread starts executing and is never cleared. Revision Changes

cvs commit: src/sys/kern kern_fork.c

2006-02-05 Thread Wayne Salamon
wsalamon2006-02-06 00:28:50 UTC FreeBSD src repository Modified files: sys/kern kern_fork.c Log: Audit the args to rfork(), and the child PID for all fork system calls. Obtained from: TrustedBSD Project Approved by: rwatson (mentor) Revision Changes