cvs commit: src/sys/kern tty_pty.c

2008-08-23 Thread Ed Schouten
ed 2008-08-23 16:03:00 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: SVN rev 182069 on 2008-08-23 16:03:00Z by ed Allow the user to suppress the rate-limited pty(4) warning. The pty(4) driver raises up to warnings when an old

cvs commit: src/sys/kern tty_pty.c

2008-08-15 Thread John Baldwin
jhb 2008-08-15 19:25:40 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern tty_pty.c Log: SVN rev 181764 on 2008-08-15 19:25:40Z by jhb MFC: Close two different races with concurrent opens of pty master devices. Revision

cvs commit: src/sys/kern tty_pty.c

2008-08-04 Thread John Baldwin
jhb 2008-08-04 19:51:23 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: SVN rev 181301 on 2008-08-04 19:51:23Z by jhb Close two different races with concurrent opens of pty master devices that could result in leaked ttys or a leaked pty

cvs commit: src/sys/kern tty_pty.c

2008-01-28 Thread Konstantin Belousov
kib 2008-01-28 12:47:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_7_0) sys/kern tty_pty.c Log: MFC rev. 1.157: In rev. 1.156, the convertion of the minor number to the unit number resulted in the argument to the make_dev() to be a unit

cvs commit: src/sys/kern tty_pty.c

2008-01-26 Thread Konstantin Belousov
kib 2008-01-27 07:51:43 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern tty_pty.c Log: MFC rev. 1.157: In rev. 1.156, the convertion of the minor number to the unit number resulted in the argument to the make_dev() to be a unit

cvs commit: src/sys/kern tty_pty.c

2008-01-25 Thread Konstantin Belousov
kib 2008-01-26 06:09:23 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: In rev. 1.156, the convertion of the minor number to the unit number resulted in the argument to the make_dev() to be a unit number. Correct this by supplying a

cvs commit: src/sys/kern tty_pty.c

2008-01-21 Thread Konstantin Belousov
kib 2008-01-21 12:57:18 UTC FreeBSD src repository Modified files:(Branch: RELENG_7_0) sys/kern tty_pty.c Log: MFC rev. 1.156: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out

cvs commit: src/sys/kern tty_pty.c

2008-01-19 Thread Konstantin Belousov
kib 2008-01-19 17:57:06 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern tty_pty.c Log: MFC rev. 1.156: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out

cvs commit: src/sys/kern tty_pty.c

2008-01-18 Thread Konstantin Belousov
kib 2008-01-18 18:07:04 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out of the names[] bounds, creating wrong slave

cvs commit: src/sys/kern tty_pty.c

2007-11-15 Thread John Baldwin
jhb 2007-11-15 20:20:55 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern tty_pty.c Log: MFC: Make it easier to add more ptys to the pty(4) driver. Approved by:re (kensmith) Revision ChangesPath 1.137.2.6 +13 -20

cvs commit: src/sys/kern tty_pty.c

2007-11-15 Thread John Baldwin
jhb 2007-11-15 20:18:26 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern tty_pty.c Log: MFC: Make it easier to add more ptys to the pty(4) driver. Approved by:re (kensmith) Revision ChangesPath 1.152.2.1 +13 -20

cvs commit: src/sys/kern tty_pty.c

2007-11-08 Thread John Baldwin
jhb 2007-11-08 15:51:53 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Make it easier to add more ptys to the pty(4) driver: - Use unit2minor() and minor2unit() to generate minor numbers to support unit numbers higher than 255. - Use

cvs commit: src/sys/kern tty_pty.c

2007-11-08 Thread John Baldwin
jhb 2007-11-08 21:45:56 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: A couple of optimizations to the last commit. Submitted by: Christoph Mallon christoph mallon of gmx de Revision ChangesPath 1.154 +2 -2

cvs commit: src/sys/kern tty_pty.c

2007-07-03 Thread Konstantin Belousov
kib 2007-07-03 17:45:53 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Use make_dev_credf(MAKEDEV_REF) instead of make_dev() from pty clone handler. Debugging help and testing by: Peter Holm Approved by:re (kensmith) Revision

cvs commit: src/sys/kern tty_pty.c

2006-10-04 Thread Martin Blapp
mbr 2006-10-04 17:52:21 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern tty_pty.c Log: Back out rev. 1.137.2.3. It open a possible security hole. Submitted by: bde Approved by:re (implicit) Revision Changes

cvs commit: src/sys/kern tty_pty.c

2006-10-03 Thread Martin Blapp
mbr 2006-10-04 05:43:40 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Back out part of rev. 1.149. While adding a workaround in ptcopen() to avoid leaked ptys works fine, this opens a possible security hole. Submitted by: bde MFC

cvs commit: src/sys/kern tty_pty.c

2006-09-30 Thread Martin Blapp
mbr 2006-09-30 21:02:19 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern tty_pty.c Log: Fix 'pty leak by number'. Make the leaked ptys usable again. Approved by:re Revision ChangesPath 1.137.2.3 +9 -2

cvs commit: src/sys/kern tty_pty.c

2006-09-30 Thread Martin Blapp
mbr 2006-09-30 22:51:05 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Readd rev. 1.145 because of vfs bugs and races near revoke(). Until they are fixed we can't free any slaves. Add a workaround to not to leak ptys by number.

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-30 Thread Bruce Evans
On Sat, 30 Sep 2006, Martin Blapp wrote: What's the best to do now ? Back out again the last commit and that destroy slave can be called, make tty_pts.c as broken ? Or will you or Bruce fix the underlaying problem ? It's far beyond my horizont ... Start with removing all device and tty

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-30 Thread Martin Blapp
Hi Bruce, Ok will do so. What do you think, can we solve the old vfs bugs and complications near revoke() before 7.0 gets released ? Martin Martin Blapp, [EMAIL PROTECTED] [EMAIL PROTECTED] -- ImproWare AG, UNIXSP ISP,

cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Martin Blapp
mbr 2006-09-29 09:52:57 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Free tty struct after last close. This should fix the pty-leak by numbers. Remove workarounds for tty_refcount beeing 0, this will be fixed differently later. Back

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Martin Blapp
Hi all, Free tty struct after last close. This should fix the pty-leak by numbers. Remove workarounds for tty_refcount beeing 0, this will be fixed differently later. Back out rev 1.145 since we initialize the tty struct from scratch and bad things can't happen anymore. Sigh. Peter

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], Martin Blapp writes: Memory modified after free 0xc45b7d00(252) val=deadc0dd @ 0xc45b7d70 panic: Most recently used by DEVFS1 Try zeroing all points to the cdev when you relinguish it, it's clearly a late access -- Poul-Henning Kamp | UNIX since Zilog Zeus

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Martin Blapp
Hi, Try zeroing all points to the cdev when you relinguish it, it's clearly a late access Will try ! Thanks for the pointer ! Martin ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Kris Kennaway
On Fri, Sep 29, 2006 at 08:26:40PM +0200, Martin Blapp wrote: Hi all, Free tty struct after last close. This should fix the pty-leak by numbers. Remove workarounds for tty_refcount beeing 0, this will be fixed differently later. Back out rev 1.145 since we initialize the tty

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Bruce Evans
On Fri, 29 Sep 2006, Martin Blapp wrote: Free tty struct after last close. This should fix the pty-leak by numbers. Remove workarounds for tty_refcount beeing 0, this will be fixed differently later. Back out rev 1.145 since we initialize the tty struct from scratch and bad things can't

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Martin Blapp
Hi, I think I found the bug while looking for problems near vgonel(). We're nowhere near ready to free devices in in last-close, since vgonel() doesn't do anything to evict processes from device functions before it forces the device closed. Drivers must be aware of the problem. The tty

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], Martin Blapp writes: So what can we do to destroy devices after last close ? Mark them with some flag and handle this during device operations ? DEVFS has an eviction feature which, at this point, is only used in UFS I belive. -- Poul-Henning Kamp | UNIX

Re: cvs commit: src/sys/kern tty_pty.c

2006-09-29 Thread Martin Blapp
What's the best to do now ? Back out again the last commit and that destroy slave can be called, make tty_pts.c as broken ? Or will you or Bruce fix the underlaying problem ? It's far beyond my horizont ... Martin So what can we do to destroy devices after last close ? Mark them with some

cvs commit: src/sys/kern tty_pty.c

2006-03-30 Thread Christian S.J. Peron
csjp2006-03-30 16:46:56 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern tty_pty.c Log: MFC 1.144 tty_pty.c Allow root to open jail PTYs from the host environment. This un-breaks using utilities like watch(8) (or other programs

Re: cvs commit: src/sys/kern tty_pty.c

2006-03-30 Thread Devon H. O'Dell
On Thu, Mar 30, 2006 at 04:46:56PM +, Christian S.J. Peron wrote: csjp2006-03-30 16:46:56 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern tty_pty.c Log: MFC 1.144 tty_pty.c Allow root to open jail PTYs from the

cvs commit: src/sys/kern tty_pty.c

2006-02-02 Thread Olivier Houchard
cognet 2006-02-02 20:35:45 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Don't destroy the slave /dev entry until someone figures out why devfs seems to behave badly when we do so. Revision ChangesPath 1.145 +1 -1

Re: cvs commit: src/sys/kern tty_pty.c

2006-02-02 Thread Steve Kargl
On Thu, Feb 02, 2006 at 08:35:45PM +, Olivier Houchard wrote: cognet 2006-02-02 20:35:45 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Don't destroy the slave /dev entry until someone figures out why devfs seems to behave badly

Re: cvs commit: src/sys/kern tty_pty.c

2006-02-02 Thread Olivier Houchard
On Thu, Feb 02, 2006 at 03:42:26PM -0800, Steve Kargl wrote: On Thu, Feb 02, 2006 at 08:35:45PM +, Olivier Houchard wrote: cognet 2006-02-02 20:35:45 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Don't destroy the slave /dev

Re: cvs commit: src/sys/kern tty_pty.c

2006-02-02 Thread Steve Kargl
On Fri, Feb 03, 2006 at 01:45:20AM +0100, Olivier Houchard wrote: On Thu, Feb 02, 2006 at 03:42:26PM -0800, Steve Kargl wrote: On Thu, Feb 02, 2006 at 08:35:45PM +, Olivier Houchard wrote: cognet 2006-02-02 20:35:45 UTC FreeBSD src repository Modified files:

Re: cvs commit: src/sys/kern tty_pty.c

2006-02-02 Thread Olivier Houchard
On Thu, Feb 02, 2006 at 05:17:31PM -0800, Steve Kargl wrote: On Fri, Feb 03, 2006 at 01:45:20AM +0100, Olivier Houchard wrote: On Thu, Feb 02, 2006 at 03:42:26PM -0800, Steve Kargl wrote: On Thu, Feb 02, 2006 at 08:35:45PM +, Olivier Houchard wrote: cognet 2006-02-02 20:35:45

cvs commit: src/sys/kern tty_pty.c

2006-01-31 Thread Christian S.J. Peron
csjp2006-01-31 17:17:45 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Allow root in the host environment to open ptys within jailed environments. This logic change was introduced in revision 1.74: Correct an oversight in jail() that

cvs commit: src/sys/kern tty_pty.c

2006-01-04 Thread Poul-Henning Kamp
phk 2006-01-04 09:09:47 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: Use ttyalloc() instead of ttymalloc() Revision ChangesPath 1.140 +1 -1 src/sys/kern/tty_pty.c ___