rwatson 2008-10-06 18:43:11 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
sys/sys un.h
Log:
SVN rev 183650 on 2008-10-06 18:43:11Z by rwatson
Now that portalfs doesn't directly invoke uipc_connect2(), make it a
static
rwatson 2008-10-03 09:01:55 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
SVN rev 183563 on 2008-10-03 09:01:55Z by rwatson
Remove or update several stale comments.
A bit of whitespace/style cleanup.
Update copyright.
MFC
rwatson 2008-10-03 13:01:56 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
sys/sys un.h
Log:
SVN rev 183572 on 2008-10-03 13:01:56Z by rwatson
Further minor cleanups to UNIX domain sockets:
- Staticize and locally
rwatson 2008-09-13 00:16:20 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern uipc_usrreq.c
Log:
SVN rev 182993 on 2008-09-13 00:16:20Z by rwatson
Extend global UNIX domain socket rwlock coverage to include incrementing
and
trhodes 2008-07-26 00:55:35 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
sys/netipsec ipsec.c
Log:
SVN rev 180820 on 2008-07-26 00:55:35Z by trhodes
Fill in a few sysctl descriptions.
Approved by:rwatson
Revision
On Tue, 2008-07-08 at 12:11 +0930, Daniel O'Connor wrote:
On Tue, 8 Jul 2008, Coleman Kane wrote:
Hopefully people will begin to incorporate svn blame into their
work-flows.
A 2 line comment would be much simpler and more likely to actually work
IMO :)
Yeah, commenting such things
This really deserves a comment at each invocation of bcopy in
order to prevent regressions by someone fixing it again.
-Alfred
* Ed Maste [EMAIL PROTECTED] [080703 16:26] wrote:
emaste 2008-07-03 23:26:10 UTC
FreeBSD src repository
Modified files:
sys/kern
On Mon, 2008-07-07 at 12:52 -0700, Alfred Perlstein wrote:
This really deserves a comment at each invocation of bcopy in
order to prevent regressions by someone fixing it again.
-Alfred
* Ed Maste [EMAIL PROTECTED] [080703 16:26] wrote:
emaste 2008-07-03 23:26:10 UTC
FreeBSD
On Mon, Jul 07, 2008 at 12:52:09PM -0700, Alfred Perlstein wrote:
* Ed Maste [EMAIL PROTECTED] [080703 16:26] wrote:
emaste 2008-07-03 23:26:10 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
SVN rev 180238 on 2008-07-03
On Tue, 8 Jul 2008, Coleman Kane wrote:
Hopefully people will begin to incorporate svn blame into their
work-flows.
A 2 line comment would be much simpler and more likely to actually work
IMO :)
--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
emaste 2008-07-03 23:26:10 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
SVN rev 180238 on 2008-07-03 23:26:10Z by emaste
Use bcopy instead of strlcpy in uipc_bind and unp_connect, since
soun-sun_path isn't a null-terminated string.
rwatson 2008-03-01 11:50:45 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.211 from HEAD to RELENG_7:
Correct typos in comments.
Revision ChangesPath
1.206.2.2 +2 -2
rwatson 2008-01-23 12:07:17 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.214 from HEAD to RELENG_7:
Move unlock of global UNIX domain socket lock slightly lower in
unp_connect(): it
rwatson 2008-01-23 12:08:12 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7_0)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.214 from HEAD to RELENG_7_0:
Move unlock of global UNIX domain socket lock slightly lower in
unp_connect():
rwatson 2008-01-18 19:16:03 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Move unlock of global UNIX domain socket lock slightly lower in
unp_connect(): it is expected to return with the lock held, and two
possible error paths otherwise
rwatson 2008-01-10 12:38:17 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove lock pushdown todo item in comment -- I did that for 7.0.
MFC after: 3 weeks
Revision ChangesPath
1.212 +0 -1
rwatson 2008-01-10 12:29:13 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Correct typos in comments.
MFC after: 3 weeks
Revision ChangesPath
1.211 +2 -2 src/sys/kern/uipc_usrreq.c
jeff2008-01-01 01:46:43 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
- Place the fhold() in unp_internalize_fp to be more consistent with refs.
- Clear all of the gc flags before doing a run. Stale flags were causing
us to skip
jeff2007-12-31 03:44:55 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
- Check the correct variable against NULL in two places.
- If the unp_file is NULL that means it has never been internalized and it
must be reachable.
rwatson 2007-05-29 12:36:00 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Add DDB show unpcb command, allowing DDB to print out many pertinent
details from UNIX domain socket protocol layer state.
Revision ChangesPath
1.205
rwatson 2007-05-11 12:28:45 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove more one more stale comment regarding unpcb type-safety.
Revision ChangesPath
1.204 +0 -4 src/sys/kern/uipc_usrreq.c
rwatson 2007-05-11 12:10:45 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Clarify and update quite a few comments to reflect locking optimizations,
the addition of unpcb refcounts, and bug fixes. Some of these fixes are
appropriate for
rwatson 2007-05-10 20:00:36 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.193 from HEAD to RELENG_6:
Change unp_mtx to supporting recursion, and do not drop the unp_mtx over
rwatson 2007-05-08 08:10:37 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.169 from HEAD to RELENG_6:
Remove unused (and ifdef'd) unp_abort() and unp_drain().
RevisionChanges
rwatson 2007-05-08 08:37:27 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.174 from HEAD to RELENG_6:
In uipc_send() and uipc_rcvd(), store unp-unp_conn pointer in unp2
while working
rwatson 2007-05-08 08:41:13 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.175 from HEAD to RELENG_6:
Move various UNIX socket global variables and sysctls from the middle of
the file
rwatson 2007-05-08 10:16:23 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.178,1.192 from HEAD to RELENG_6:
Add two new unpcb flags, UNP_BINDING and UNP_CONNECTING, which will be
used
rwatson 2007-05-08 10:20:22 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.179,1.180 from HEAD to RELENG_6:
Add additional comments to the top of the UNIX domain socket implementation
rwatson 2007-05-08 10:22:46 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.184 from HEAD to RELENG_6:
Remove now unneeded ENOTCONN clause from SOCK_DGRAM side of uipc_send():
we have
rwatson 2007-05-08 10:01:51 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.177 from HEAD to RELENG_6:
Merge unp_bind() into uipc_bind(), as it is called only from uipc_bind().
rwatson 2007-05-08 11:47:19 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.187 from HEAD to RELENG_6:
Minor white space tweaks.
RevisionChangesPath
1.155.2.20 +2 -4
rwatson 2007-05-08 11:50:57 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.196 from HEAD to RELENG_6:
Add an additional MAC check to the UNIX domain socket connect path:
check that the
wkoszek 2007-05-06 12:00:38 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Don't acquire Giant unconditionally.
Reviewed by:rwatson
Revision ChangesPath
1.202 +20 -14src/sys/kern/uipc_usrreq.c
rwatson 2007-03-12 14:52:00 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
In uipc_close(), we no longer always free the unpcb, as the last reference
may be dropped later. In this case, always unlock the unpcb so as not to
leak the lock.
rwatson 2007-03-01 09:00:42 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove two simultaneous acquisitions of multiple unpcb locks from
uipc_send in cases where only a global read lock is held by breaking
them out and avoiding the
rwatson 2007-03-01 11:07:18 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
Merge uipc_usrreq.c:1.183 from HEAD to RELENG_6:
Close a race that occurs when using sendto() to connect and send on a
UNIX domain
rwatson 2007-02-28 08:08:50 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Lock unp2 after checking for a non-NULL unp2 pointer in uipc_send() on
datagram UNIX domain sockets, not before.
Revision ChangesPath
1.198 +1 -1
rwatson 2007-02-22 09:37:44 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Add an additional MAC check to the UNIX domain socket connect path:
check that the subject has read/write access to the vnode using the
vnode MAC check.
MFC
rwatson 2007-02-20 10:50:02 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Break introductory comment into two paragraphs to separate material on the
garbage collection complications from general discussion of UNIX domain
sockets.
rwatson 2007-02-14 12:22:11 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Change unp_mtx to supporting recursion, and do not drop the unp_mtx over
sonewconn() in unp_connect(). This avoids a race that occurs due to
v_socket being an
rwatson 2007-02-14 15:05:40 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Minor rearrangement of global variables, comments, etc, in UNIX domain
sockets.
Revision ChangesPath
1.194 +34 -37src/sys/kern/uipc_usrreq.c
rwatson 2007-02-13 21:00:57 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Set UNP_CONNECTING when committing to moving ahead in unp_connect().
This logic was lost when merging the remainder of these changes in
1.178.
Revision
rwatson 2007-02-06 14:31:38 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Push UNIX domain socket locking further into uipc_ctloutput() in order to
avoid holding the UNIX domain socket subsystem lock over soooptcopyin()
and
jhb 2007-01-12 16:24:23 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
MFC: Close a race between enumerating UNIX domain socket pcb structures via
sysctl and socket teardown. Note that we engage in a bit of
rwatson 2006-08-13 23:16:59 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Minor white space tweaks.
Revision ChangesPath
1.187 +2 -4 src/sys/kern/uipc_usrreq.c
___
rwatson 2006-08-06 10:39:22 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Don't set pru_sosend, pru_soreceive, pru_sopoll to default values, as they
are already set to default values.
Revision ChangesPath
1.185 +0 -3
rwatson 2006-08-02 14:30:58 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove now unneeded ENOTCONN clause from SOCK_DGRAM side of uipc_send():
we have to check it regardless of the target address, so don't check it
twice.
rwatson 2006-07-31 23:00:05 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Close a race that occurs when using sendto() to connect and send on a
UNIX domain socket at the same time as the remote host is closing the
new connections as
rwatson 2006-07-26 19:16:35 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove call to soisdisconnected() in uipc_detach(), since it will already
have been invoked by uipc_close() or uipc_abort(), and the socket is in a
state of being
rwatson 2006-07-23 10:19:04 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Move various UNIX socket global variables and sysctls from the middle of
the file to the top.
Revision ChangesPath
1.175 +32 -32
rwatson 2006-07-23 10:25:28 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Since unp_attach() and unp_detach() are now called only from uipc_attach()
and uipc_detach(), merge them into their calling functions.
Revision ChangesPath
rwatson 2006-07-23 11:02:12 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Merge unp_bind() into uipc_bind(), as it is called only from uipc_bind().
Revision ChangesPath
1.177 +85 -94src/sys/kern/uipc_usrreq.c
rwatson 2006-07-23 12:01:14 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
sys/sys unpcb.h
Log:
Add two new unpcb flags, UNP_BINDING and UNP_CONNECTING, which will be
used to mark UNIX domain sockets as being in the process of
rwatson 2006-07-23 20:06:45 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Add additional comments to the top of the UNIX domain socket implementation
providing some high level pointers regarding the implementation.
Revision Changes
rwatson 2006-07-23 21:01:09 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove duplicate 'or'.
Submitted by: ru
Revision ChangesPath
1.180 +4 -4 src/sys/kern/uipc_usrreq.c
rwatson 2006-07-22 17:24:55 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Re-wrap and other minor formatting and punctuation fixes for UNIX domain
socket comments.
Revision ChangesPath
1.173 +82 -84
rwatson 2006-07-22 18:41:42 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
In uipc_send() and uipc_rcvd(), store unp-unp_conn pointer in unp2
while working with the second unpcb to make the code more clear.
Revision ChangesPath
maxim 2006-07-13 13:42:37 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
MFC rev. 1.168: for sockets with LOCAL_CREDS option remove all previous
linked SCM_CREDS control messages and then add a control message
rwatson 2006-07-11 21:49:55 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Reduce periods of simultaneous acquisition of various socket buffer
locks and the unplock during uipc_rcvd() and uipc_send() by caching
certain values from one
rwatson 2006-06-26 16:18:22 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Trim basically unused 'unp' in uipc_connect().
Revision ChangesPath
1.170 +0 -3 src/sys/kern/uipc_usrreq.c
rwatson 2006-06-16 22:11:49 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Remove unused (and ifdef'd) unp_abort() and unp_drain().
MFC after: 1 month
Revision ChangesPath
1.169 +0 -18 src/sys/kern/uipc_usrreq.c
maxim 2006-06-13 14:33:35 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
o There are two methods to get a process credentials over the unix
sockets:
1) A sender sends SCM_CREDS message to a reciever, struct cmsgcred;
2) A reciever
maxim 2006-05-21 09:12:24 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
MFC rev. 1.167: inherit LOCAL_CREDS option from listen socket
for sockets returned by accept(2).
Revision ChangesPath
1.155.2.5
maxim 2006-04-24 19:09:33 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Inherit LOCAL_CREDS option from listen socket for sockets returned
by accept(2).
PR: kern/90644
Submitted by: Andrey Simonenko
OK'ed by:
rwatson 2006-03-17 13:52:57 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Modify UNIX domain sockets to guarantee, and assume, that so_pcb is always
defined for an in-use socket. This allows us to eliminate countless tests
of whether
jeff2006-03-13 03:06:03 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern uipc_usrreq.c
Log:
MFC Rev 1.162
VFS SMP fixes, stack api, softupdates fixes.
Sponsored by: Isilon Systems, Inc.
Approved by:re (scottl)
rwatson 2006-01-13 00:00:32 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
XXX a comment in uipc_usrreq.c that requires updating.
Revision ChangesPath
1.161 +2 -0 src/sys/kern/uipc_usrreq.c
mux 2005-12-14 22:27:48 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
sys/netinet raw_ip.c tcp_usrreq.c udp_usrreq.c
Log:
Fix a bunch of SYSCTL_INT() that should have been SYSCTL_ULONG() to
match the type of the variable they
rwatson 2005-11-10 16:06:05 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_usrreq.c
Log:
Correct a number of serious and closely related bugs in the UNIX domain
socket file descriptor garbage collection code, which is intended to
detect and clear cycles
69 matches
Mail list logo
