cvs commit: src/sys/netinet tcp_input.c

2008-10-07 Thread Robert Watson
rwatson 2008-10-07 09:41:07 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: SVN rev 183662 on 2008-10-07 09:41:07Z by rwatson Don't pass curthread to sbreserve_locked() in tcp_do_segment(), as the netisr or ithread's socket buffer size

cvs commit: src/sys/netinet tcp_input.c

2008-09-29 Thread Robert Watson
rwatson 2008-09-29 15:19:37 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: SVN rev 183463 on 2008-09-29 15:19:37Z by rwatson Merge r183323 from head to stable/7: When dropping a packet and issuing a reset

cvs commit: src/sys/netinet tcp_input.c

2008-09-29 Thread Robert Watson
rwatson 2008-09-29 18:23:08 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: SVN rev 183469 on 2008-09-29 18:23:08Z by rwatson Merge r183356 from head to stable/7: As a follow-on to r183323, correct another

cvs commit: src/sys/netinet tcp_input.c

2008-09-25 Thread Robert Watson
rwatson 2008-09-25 17:26:54 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: SVN rev 183356 on 2008-09-25 17:26:54Z by rwatson As a follow-on to r183323, correct another case where ip_output() was called without an inpcb pointer despite

cvs commit: src/sys/netinet tcp_input.c

2008-09-24 Thread Robert Watson
rwatson 2008-09-24 11:07:03 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: SVN rev 183323 on 2008-09-24 11:07:03Z by rwatson When dropping a packet and issuing a reset during TCP segment handling, unconditionally drop the tcbinfo lock

cvs commit: src/sys/netinet tcp_input.c

2008-09-12 Thread Bjoern A. Zeeb
bz 2008-09-12 19:28:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: SVN rev 182970 on 2008-09-12 19:28:57Z by bz MFC: svn r182885, cvs rev. 1.381 tcp_input.c Work around an integer division resulting

cvs commit: src/sys/netinet tcp_input.c

2008-09-12 Thread Bjoern A. Zeeb
bz 2008-09-12 19:36:37 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_input.c Log: SVN rev 182971 on 2008-09-12 19:36:37Z by bz MFC: svn r182885, cvs rev. 1.381 tcp_input.c Work around an integer division resulting

cvs commit: src/sys/netinet tcp_input.c

2008-09-09 Thread Bjoern A. Zeeb
bz 2008-09-09 07:35:21 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: SVN rev 182885 on 2008-09-09 07:35:21Z by bz Work around an integer division resulting in 0 and thus the congestion window not being incremented, if cwnd

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2008-09-07 Thread Bjoern A. Zeeb
bz 2008-09-07 18:50:25 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: SVN rev 182851 on 2008-09-07 18:50:25Z by bz Split tcp_mss() in tcp_mss() and tcp_mss_update() where the former calls the latter. Merge

cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_syncache.c tcp_usrreq.c tcp_var.h

2008-07-31 Thread Rui Paulo
rpaulo 2008-07-31 15:10:09 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_syncache.c tcp_usrreq.c tcp_var.h Log: SVN rev 181056 on 2008-07-31 15:10:09Z by rpaulo MFp4 (//depot/projects/tcpecn/):

cvs commit: src/sys/netinet tcp_input.c

2008-05-09 Thread Robert Watson
rwatson 2008-05-09 20:40:48 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: Merge tcp_input.c:1.374 from HEAD to RELENG_7: Add further TCP inpcb locking assertions to some TCP input code paths. Revision

cvs commit: src/sys/netinet tcp_input.c

2008-04-07 Thread Robert Watson
rwatson 2008-04-07 12:41:45 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Add further TCP inpcb locking assertions to some TCP input code paths. MFC after: 1 month Revision ChangesPath 1.374 +11 -0

cvs commit: src/sys/netinet tcp_input.c

2008-03-08 Thread Bjoern A. Zeeb
bz 2008-03-08 17:01:27 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: MFC: rev. 1.372 Fix indentation (whitespace changes only). rev. 1.373 Some cleanup of tcp_mss(): - Move the assigment

cvs commit: src/sys/netinet tcp_input.c

2008-03-02 Thread Bjoern A. Zeeb
bz 2008-03-02 08:40:47 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Some cleanup of tcp_mss(): - Move the assigment of the socket down before we first need it. No need to do it at the beginning and then drop out the function by

cvs commit: src/sys/netinet tcp_input.c

2008-03-01 Thread Bjoern A. Zeeb
bz 2008-03-01 22:27:15 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Fix indentation (whitespace changes only). MFC after: 6 days Revision ChangesPath 1.372 +4 -4 src/sys/netinet/tcp_input.c

Re: cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2007-12-20 Thread Ruslan Ermilov
Hi Andre, On Tue, Jul 31, 2007 at 04:48:08PM +0200, Andre Oppermann wrote: Gleb Smirnoff wrote: On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote: A andre 2007-07-28 12:20:39 UTC A A FreeBSD src repository A A Modified files: A sys/netinet tcp_input.c

cvs commit: src/sys/netinet tcp_input.c

2007-10-06 Thread Mike Silbersack
silby 2007-10-07 00:07:28 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Improve the debugging message: TCP: [X.X.X.X]:X to [X.X.X.X]:X tcpflags 0x18PUSH,ACK; tcp_do_segment: FIN_WAIT_2: Received data after socket was closed, sending RST

cvs commit: src/sys/netinet tcp_input.c

2007-09-10 Thread Ken Smith
kensmith2007-09-10 14:49:33 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Make sure that either inp is NULL or we have obtained a lock on it before jumping to dropunlock to avoid a panic. While here move the calls to ipsec4_in_reject() and

Re: cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2007-07-31 Thread Gleb Smirnoff
On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote: A andre 2007-07-28 12:20:39 UTC A A FreeBSD src repository A A Modified files: A sys/netinet tcp_input.c tcp_subr.c tcp_var.h A Log: A Provide a sysctl to toggle reporting of TCP debug logging: A A

Re: cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2007-07-31 Thread Andre Oppermann
Gleb Smirnoff wrote: On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote: A andre 2007-07-28 12:20:39 UTC A A FreeBSD src repository A A Modified files: A sys/netinet tcp_input.c tcp_subr.c tcp_var.h A Log: A Provide a sysctl to toggle reporting of TCP

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Dag-Erling Smørgrav
[EMAIL PROTECTED] writes: All of these statements seem to cancel each other out or are incorrec. I consider the subject closed as it is compiling a universe run right now. Famous last words. As I've said far too many times before, 'make universe' is worthless. Now will you please fix this

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= writes: [EMAIL PROTECTED] writes: All of these statements seem to cancel each other out or are incorrec. I consider the subject closed as it is compiling a universe run right now. Famous last words. As I've said far too many

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread mjacob
I believe I have it fixed and was just waiting for the different compiles to finish. I realize that I've inconvenienced you all by being slow in correcting this- and I do apologize. Except to DES. ___ cvs-all@freebsd.org mailing list

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Warner Losh
[EMAIL PROTECTED] writes: All of these statements seem to cancel each other out or are incorrec. I consider the subject closed as it is compiling a universe run right now. Famous last words. As I've said far too many times before, 'make universe' is worthless. Now will you please

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread mjacob
On Mon, 30 Jul 2007, Warner Losh wrote: [EMAIL PROTECTED] writes: All of these statements seem to cancel each other out or are incorrec. I consider the subject closed as it is compiling a universe run right now. Famous last words. As I've said far too many times before, 'make universe' is

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Dag-Erling Smørgrav
Warner Losh [EMAIL PROTECTED] writes: Thank you for your opinion. However, make universe is not worthless. If doing one, and checking the output for errors, isn't sufficient to get tinderbox to not whine, then tinderbox is broken. Thank you for *your* opinion, but the tinderbox is not at

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Dag-Erling Smørgrav
Dag-Erling Smørgrav [EMAIL PROTECTED] writes: The attached patch unbreaks the build. With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the brokenness of netinet/tcp_fsm.h. DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] Index: sys/netinet/tcp_fsm.h

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Andre Oppermann
Dag-Erling Smørgrav wrote: Dag-Erling Smørgrav [EMAIL PROTECTED] writes: The attached patch unbreaks the build. With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the brokenness of netinet/tcp_fsm.h. Please don't forget to undo the #ifdef and change of the log function in

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Dag-Erling Smørgrav
Andre Oppermann [EMAIL PROTECTED] writes: Please don't forget to undo the #ifdef and change of the log function in tcp_input.c. You mean revert 1.365? Sure, see updated patch. DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] Index: sys/netinet/tcp_fsm.h

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Mark Linimon
On Mon, Jul 30, 2007 at 02:01:41AM -0700, [EMAIL PROTECTED] wrote: I've asked RE to let me check in a change and hopefully we can move on and then I'll try and figure out the latest ports version of tinderbox and see if it actually does what I need quicker. The tinderbox in ports is a ports

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread Christoph Mallon
Dag-Erling Smørgrav wrote: Dag-Erling Smørgrav [EMAIL PROTECTED] writes: The attached patch unbreaks the build. With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the brokenness of netinet/tcp_fsm.h. Hi, may I suggest to declare the array as static const char *

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-30 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Dag-Erling_Smørgrav [EMAIL PROTECTED] writes: : Warner Losh [EMAIL PROTECTED] writes: : Thank you for your opinion. However, make universe is not worthless. : If doing one, and checking the output for errors, isn't sufficient to : get tinderbox to not

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread Andre Oppermann
Matt Jacob wrote: mjacob 2007-07-29 01:31:33 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_usrreq.c Log: Fix compilation problems- tcpstates is only available if TCPDEBUG is set. Approved by:re (in spirit) Thanks for fixing

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread Maxim Konovalov
Thanks for fixing this. The whole tcpstates stuff is hackish. We need a better fix as the state reporting in the log message should not depend on TCPDEBUG. tb still fails at tcpstates. -- Maxim Konovalov ___ cvs-all@freebsd.org mailing list

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
I know. I'm going to look at it more today. On Sun, 29 Jul 2007, Maxim Konovalov wrote: Thanks for fixing this. The whole tcpstates stuff is hackish. We need a better fix as the state reporting in the log message should not depend on TCPDEBUG. tb still fails at tcpstates. -- Maxim

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
I'm not sure I *did* fix this- the tinderbox stuff is still falling opver. On Sun, 29 Jul 2007, Andre Oppermann wrote: Matt Jacob wrote: mjacob 2007-07-29 01:31:33 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_usrreq.c Log: Fix

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
Sorry- I was a tired and cranky idiot. I have this fixed now, and will do a real universe run *and* ask re. The problem here is that the code is definitely ancient wanky- there's a const char *[] array in tcp_fsm.h that's compiled in iff TCPSTATES is defined. Various files include

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
Here's what probably works. I'll do the test compiles. Index: netinet/tcp_input.c === RCS file: /home/ncvs/src/sys/netinet/tcp_input.c,v retrieving revision 1.366 diff -u -r1.366 tcp_input.c --- netinet/tcp_input.c 29 Jul 2007

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread Bjoern A. Zeeb
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote: Here's what probably works. I'll do the test compiles. If I am not wrong it will not. The follwoing two files have comments at the beginning to explain the changes. I don't like the extern char *tcpstates[] but it seems to be the best solution

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote: On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote: Here's what probably works. I'll do the test compiles. If I am not wrong it will not. The follwoing two files have comments at the beginning to explain the changes. I don't like the extern char

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread Bjoern A. Zeeb
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote: Hi, On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote: On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote: Here's what probably works. I'll do the test compiles. If I am not wrong it will not. The follwoing two files have comments at the beginning to

Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-29 Thread mjacob
solution for now. No, that's what's actually wrong. tcpstates has to be static to honor the intent of the original author. If you want to do something extern then the actual tcpstates should go into tcp_debug.c. However, this is slightly less flexible in that the way it is now each source

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c

2007-07-28 Thread Andre Oppermann
andre 2007-07-28 11:51:45 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c Log: o Move all detailed checks for RST in LISTEN state from tcp_input() to syncache_rst(). o Fix tests for flag combinations of RST and SYN, ACK, FIN.

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2007-07-28 Thread Andre Oppermann
andre 2007-07-28 12:20:39 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: Provide a sysctl to toggle reporting of TCP debug logging: sys.net.inet.tcp.log_debug = 1 It defaults to enabled for the moment and is to

cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

2007-07-28 Thread Matt Jacob
mjacob 2007-07-29 01:31:33 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_usrreq.c Log: Fix compilation problems- tcpstates is only available if TCPDEBUG is set. Approved by:re (in spirit) Revision ChangesPath 1.366 +6

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_syncache.c tcp_syncache.h tcp_var.h

2007-07-26 Thread Mike Silbersack
silby 2007-07-27 00:57:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_syncache.c tcp_var.h Added files: sys/netinet tcp_syncache.h Log: Export the contents of the syncache to netstat.

cvs commit: src/sys/netinet tcp_input.c

2007-07-25 Thread Andre Oppermann
andre 2007-07-25 18:48:24 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Fix comments in tcp_do_segment(). Approved by:re (kensmith) Revision ChangesPath 1.362 +3 -5 src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2007-07-04 Thread Peter Wemm
peter 2007-07-05 05:55:57 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: Fix cast-qualifiers warning when INET6 is not present Approved by: re (rwatson) Revision ChangesPath 1.361 +1 -2

cvs commit: src/sys/netinet tcp_input.c

2007-06-12 Thread John Baldwin
jhb 2007-06-12 18:53:32 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_input.c Log: MFC 1.315: In the SYN_SENT case, Initialize the snd_wnd before the call to tcp_mss(). The TCP hostcache logic in tcp_mss() depends on the

cvs commit: src/sys/netinet tcp_input.c

2007-06-10 Thread Andre Oppermann
andre 2007-06-10 20:59:22 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Fix style for comments, be more verbose and add some more. Revision ChangesPath 1.357 +34 -23src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c

2007-06-10 Thread Andre Oppermann
andre 2007-06-10 21:07:21 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Fix a case in tcp_do_segment() where tcp_update_sack_list() would be called with an incorrect segment end value. tcp_reass() may trim segments when they overlap with

cvs commit: src/sys/netinet tcp_input.c

2007-06-09 Thread Andre Oppermann
andre 2007-06-09 21:09:50 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove some bogosity from the SYN_SENT case in tcp_do_segment and simplify handling of the send/receive window scaling. No change in effective behavour. RFC1323

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h

2007-05-28 Thread Andre Oppermann
andre 2007-05-28 11:03:53 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c tcp_var.h Log: Refactor and rewrite in parts the SYN handling code on listen sockets in tcp_input(): o tighten the checks on allowed TCP flags to be

cvs commit: src/sys/netinet tcp_input.c

2007-05-28 Thread Andre Oppermann
andre 2007-05-28 11:35:40 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Fix indentation of the syncache_expand() section in tcp_input(). Revision ChangesPath 1.354 +52 -52src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c

2007-05-28 Thread Andre Oppermann
andre 2007-05-28 23:27:44 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c Log: Make log messages more verbose and simpler to understand for non-experts. Update comments to be more conscious, verbose and fully reflect reality.

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_timewait.c tcp_var.h

2007-05-16 Thread Andre Oppermann
andre 2007-05-16 17:14:26 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_timewait.c tcp_var.h Log: Move TIME_WAIT related functions and timer handling from files other than repo

cvs commit: src/sys/netinet tcp_input.c

2007-05-09 Thread Maxim Konovalov
maxim 2007-05-09 06:09:41 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: o Unbreak options TCPDEBUG nooptions INET6 kernel build. PR: kern/112517 Submitted by: vd Revision ChangesPath 1.347 +2 -0

cvs commit: src/sys/netinet tcp_input.c

2007-05-09 Thread Maxim Konovalov
maxim 2007-05-09 11:39:46 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: o Fix style(9) bugs introduced in the last commit. Pointed out by: bde Revision ChangesPath 1.348 +3 -3 src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Andre Oppermann
andre 2007-05-06 15:16:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove the defunct remains of the TCPS_TIME_WAIT cases from tcp_do_segment and change it to a void function. We use a compressed structure for TCPS_TIME_WAIT to

cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Andre Oppermann
andre 2007-05-06 15:23:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Reorder the TCP header prediction test to check for the most volatile values first to spend less time on a fallback to normal processing. Revision ChangesPath

Re: cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Robert Watson
On Sun, 6 May 2007, Andre Oppermann wrote: andre 2007-05-06 15:16:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove the defunct remains of the TCPS_TIME_WAIT cases from tcp_do_segment and change it to a void function. We use a

cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Andre Oppermann
andre 2007-05-06 15:41:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: o Remove redundant tcp reassembly check in header prediction code o Rearrange code to make intent in TCPS_SYN_SENT case more clear o Assorted style cleanup o

Re: cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Andre Oppermann
Robert Watson wrote: On Sun, 6 May 2007, Andre Oppermann wrote: andre 2007-05-06 15:16:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove the defunct remains of the TCPS_TIME_WAIT cases from tcp_do_segment and change it to a void

cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_subr.c tcp_syncache.c tcp_usrreq.c tcp_var.h

2007-05-06 Thread Andre Oppermann
andre 2007-05-06 15:56:31 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_subr.c tcp_syncache.c tcp_usrreq.c tcp_var.h Log: Use existing TF_SACK_PERMIT flag in struct tcpcb t_flags field instead of a

Re: cvs commit: src/sys/netinet tcp_input.c

2007-05-06 Thread Robert Watson
On Sun, 6 May 2007, Andre Oppermann wrote: Robert Watson wrote: On Sun, 6 May 2007, Andre Oppermann wrote: andre 2007-05-06 15:16:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove the defunct remains of the TCPS_TIME_WAIT cases from

cvs commit: src/sys/netinet tcp_input.c

2007-05-04 Thread Robert Watson
rwatson 2007-05-04 17:45:53 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tweak comment at end of tcp_input() when calling into tcp_do_segment(): the pcbinfo lock will be released as well, not just the pcb lock. Revision ChangesPath

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 13:51:34 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c Log: Simplifly syncache_expand() and clarify its semantics. Zero is returned when the ACK is invalid and doesn't belong to any registered connection,

cvs commit: src/sys/netinet tcp_input.c tcp_var.h

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 15:28:01 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_var.h Log: o Remove unncessary TOF_SIGLEN flag from struct tcpopt o Correctly set to-to_signature in tcp_dooptions() o Update comments Revision ChangesPath

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 14:34:54 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c tcp_var.h Log: Remove bogus check for accept queue length and associated failure handling from the incoming SYN handling section of tcp_input().

cvs commit: src/sys/netinet tcp_input.c

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 15:21:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Add more KASSERT's. Revision ChangesPath 1.339 +4 -0 src/sys/netinet/tcp_input.c ___ cvs-all@freebsd.org

cvs commit: src/sys/netinet tcp_input.c

2007-04-15 Thread Robert Watson
rwatson 2007-04-15 21:03:23 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Remove unused variable tcbinfo_mtx. Revision ChangesPath 1.336 +0 -1 src/sys/netinet/tcp_input.c ___

cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_syncache.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h

2007-04-11 Thread Andre Oppermann
andre 2007-04-11 09:45:16 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_syncache.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h Log: Change the TCP timer

Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_syncache.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h

2007-04-11 Thread Sergey Matveychuk
Please note, it broke build world. Andre Oppermann wrote: andre 2007-04-11 09:45:16 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_syncache.c tcp_timer.c

cvs commit: src/sys/netinet tcp_input.c

2007-04-04 Thread Andre Oppermann
andre 2007-04-04 14:39:49 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: In tcp_dooptions() skip over SACK options if it is a SYN segment. Revision ChangesPath 1.331 +2 -0 src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c

2007-04-04 Thread Andre Oppermann
andre 2007-04-04 16:13:45 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c Log: Move last tcpcb initialization for the inbound connection case from tcp_input() to syncache_socket() where it belongs and the majority of it already

Re: cvs commit: src/sys/netinet tcp_input.c

2007-03-29 Thread Andrey Chernov
On Wed, Mar 28, 2007 at 12:58:14PM +, Andre Oppermann wrote: andre 2007-03-28 12:58:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: When blackholing do a 'dropunlock' in the new world order to prevent the INP_INFO_LOCK from

cvs commit: src/sys/netinet tcp_input.c

2007-03-28 Thread Andre Oppermann
andre 2007-03-28 12:58:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: When blackholing do a 'dropunlock' in the new world order to prevent the INP_INFO_LOCK from leaking. Reported by:ache Found by: rwatson Revision

cvs commit: src/sys/netinet tcp_input.c tcp_sack.c

2007-03-23 Thread Andre Oppermann
andre 2007-03-23 18:33:21 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_sack.c Log: Bring SACK option handling in tcp_dooptions() in line with all other options and ajust users accordingly. Revision ChangesPath 1.326 +7 -4

cvs commit: src/sys/netinet tcp_input.c

2007-03-23 Thread Andre Oppermann
andre 2007-03-23 19:11:22 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tidy up some code to conform better to surroundings and style(9), 0 = NULL and space/tab. Revision ChangesPath 1.327 +16 -17

cvs commit: src/sys/netinet tcp_input.c

2007-03-23 Thread Andre Oppermann
andre 2007-03-23 20:16:50 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Split tcp_input() into its two functional parts: o tcp_input() now handles TCP segment sanity checks and preparations including the INPCB lookup and syncache.

cvs commit: src/sys/netinet tcp_input.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 18:36:49 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tidy up tcp_log_in_vain and blackhole. Revision ChangesPath 1.321 +31 -44src/sys/netinet/tcp_input.c ___

cvs commit: src/sys/netinet tcp_input.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 18:49:43 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tidy up the ACCEPTCONN section of tcp_input(), ajust comments and remove old dead T/TCP code. Revision ChangesPath 1.322 +27 -57

cvs commit: src/sys/netinet tcp_input.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 18:52:58 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Update and clarify comments in first section of tcp_input(). Revision ChangesPath 1.323 +13 -15src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 18:56:03 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Tidy up IPFIREWALL_FORWARD sections and comments. Revision ChangesPath 1.324 +3 -4 src/sys/netinet/tcp_input.c

cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_timer.c tcp_usrreq.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 19:37:55 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_sack.c tcp_subr.c tcp_timer.c tcp_usrreq.c Log: ANSIfy function declarations and remove register keywords for variables.

cvs commit: src/sys/netinet tcp_input.c

2007-03-19 Thread Andre Oppermann
andre 2007-03-19 18:49:04 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Match up SYSCTL declaration style. Revision ChangesPath 1.318 +15 -14src/sys/netinet/tcp_input.c ___

cvs commit: src/sys/netinet tcp_input.c

2007-03-16 Thread Qing Li
qingli 2007-03-16 22:04:25 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_input.c Log: MFC:r1.316, accept valid RST packet when delayed ack is in effect. RevisionChangesPath 1.281.2.12 +7 -5

cvs commit: src/sys/netinet tcp_input.c

2007-03-07 Thread Qing Li
qingli 2007-03-07 23:21:59 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: This patch is provided to fix a couple of deployment issues observed in the field. In one situation, one end of the TCP connection sends a back-to-back RST packet,

cvs commit: src/sys/netinet tcp_input.c

2007-02-28 Thread Mohan Srinivasan
mohans 2007-02-28 20:48:01 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: In the SYN_SENT case, Initialize the snd_wnd before the call to tcp_mss(). The TCP hostcache logic in tcp_mss() depends on the snd_wnd being initialized. Revision

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h src/usr.bin/netstat inet.c

2007-02-26 Thread Mohan Srinivasan
mohans 2007-02-26 22:25:21 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h usr.bin/netstat inet.c Log: Reap FIN_WAIT_2 connections marked SOCANTRCVMORE

cvs commit: src/sys/netinet tcp_input.c udp_usrreq.c udp_var.h src/sys/netinet6 udp6_usrreq.c

2007-02-20 Thread Robert Watson
rwatson 2007-02-20 10:20:03 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c udp_usrreq.c udp_var.h sys/netinet6 udp6_usrreq.c Log: Rename two identically named log_in_vain variables: tcp_input.c's static log_in_vain to tcp_log_in_vain,

Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h

2007-02-07 Thread Robert Watson
On Thu, 1 Feb 2007, Andre Oppermann wrote: andre 2007-02-01 18:32:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h Log: Auto sizing TCP socket buffers. Normally the socket buffers are

cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h

2007-02-01 Thread Andre Oppermann
andre 2007-02-01 18:32:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h Log: Auto sizing TCP socket buffers. Normally the socket buffers are static (either derived from global

Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h

2007-02-01 Thread Andre Oppermann
Andre Oppermann wrote: andre 2007-02-01 18:32:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c tcp_var.h Log: Auto sizing TCP socket buffers. Normally the socket buffers are static

Re: cvs commit: src/sys/netinet tcp_input.c

2006-09-26 Thread Andrew R. Reiter
On Mon, 25 Sep 2006, John-Mark Gurney wrote: :Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400: : On Tue, 26 Sep 2006, John-Mark Gurney wrote: : : :jmg 2006-09-26 01:21:47 UTC : : : : FreeBSD src repository : : : : Modified files: : :sys/netinet

cvs commit: src/sys/netinet tcp_input.c

2006-09-25 Thread John-Mark Gurney
jmg 2006-09-26 01:21:47 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: fix calculating to_tsecr... This prevents the rtt calculations from going all wonky... Revision ChangesPath 1.309 +1 -1

Re: cvs commit: src/sys/netinet tcp_input.c

2006-09-25 Thread Andrew R. Reiter
On Tue, 26 Sep 2006, John-Mark Gurney wrote: :jmg 2006-09-26 01:21:47 UTC : : FreeBSD src repository : : Modified files: :sys/netinet tcp_input.c : Log: : fix calculating to_tsecr... This prevents the rtt calculations from : going all wonky... : : Revision Changes

Re: cvs commit: src/sys/netinet tcp_input.c

2006-09-25 Thread John-Mark Gurney
Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400: On Tue, 26 Sep 2006, John-Mark Gurney wrote: :jmg 2006-09-26 01:21:47 UTC : : FreeBSD src repository : : Modified files: :sys/netinet tcp_input.c : Log: : fix calculating to_tsecr... This

cvs commit: src/sys/netinet tcp_input.c

2006-09-23 Thread Bruce M Simpson
bms 2006-09-23 16:26:31 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Always set the IP version in the TCP input path, to preserve the header field for possible later IPSEC SPD lookup, even when the kernel is built without 'options

cvs commit: src/sys/netinet tcp_input.c tcp_subr.c tcp_var.h

2006-09-19 Thread Gleb Smirnoff
glebius 2006-09-19 12:58:40 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_input.c tcp_subr.c tcp_var.h Log: With recent MFC the tcp_twclose() can be converted to void, as it is in HEAD. Submitted by: ru Approved by:

  1   2   >