cvs commit: src/sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c

2008-09-13 Thread Bjoern A. Zeeb
bz 2008-09-13 17:26:46 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c Log: SVN rev 183001 on 2008-09-13 17:26:46Z by bz Implement IPv6 support for TCP MD5 Signature Option (RFC 2385) the same way it has been

Re: cvs commit: src/sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c

2008-09-13 Thread Bjoern A. Zeeb
On Sat, 13 Sep 2008, Bjoern A. Zeeb wrote: Hi, bz 2008-09-13 17:26:46 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c Log: SVN rev 183001 on 2008-09-13 17:26:46Z by bz Implement IPv6 support for TCP MD5 Signature Option

cvs commit: src/sys/netinet tcp_output.c

2008-09-07 Thread Bjoern A. Zeeb
bz 2008-09-07 11:38:30 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: SVN rev 182841 on 2008-09-07 11:38:30Z by bz Add a second KASSERT checking for len = 0 in the tcp output path. This is different to the first one (as len gets

Re: cvs commit: src/sys/netinet tcp_output.c

2008-09-07 Thread Bjoern A. Zeeb
On Sun, 7 Sep 2008, Bjoern A. Zeeb wrote: bz 2008-09-07 11:38:30 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: SVN rev 182841 on 2008-09-07 11:38:30Z by bz Add a second KASSERT checking for len = 0 in the tcp output path. This is

cvs commit: src/sys/netinet tcp_output.c

2008-07-15 Thread Rui Paulo
rpaulo 2008-07-15 10:32:35 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: SVN rev 180535 on 2008-07-15 10:32:35Z by rpaulo Fix commment in typo. Mtcp_output.c Revision ChangesPath 1.151 +1 -1

cvs commit: src/sys/netinet tcp_output.c

2008-05-05 Thread Andre Oppermann
andre 2008-05-05 20:46:39 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_output.c Log: MFC rev. 1.149: Remove TCP options ordering assumptions in tcp_addoptions(). Revision ChangesPath 1.141.2.5 +11 -1

cvs commit: src/sys/netinet tcp_output.c

2008-04-07 Thread Andre Oppermann
andre 2008-04-07 18:50:05 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Remove now unnecessary comment. Revision ChangesPath 1.148 +0 -2 src/sys/netinet/tcp_output.c ___

cvs commit: src/sys/netinet tcp_output.c

2008-04-07 Thread Andre Oppermann
andre 2008-04-07 19:09:23 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Remove TCP options ordering assumptions in tcp_addoptions(). Ordering was changed in rev. 1.161 of tcp_var.h. All option now test for sufficient space in TCP

cvs commit: src/sys/netinet tcp_output.c

2008-03-13 Thread Bjoern A. Zeeb
bz 2008-03-13 10:09:12 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_output.c Log: MFC rev. 1.146 tcp_output.c Padding after EOL option must be zeros according to RFC793 but the NOPs used are 0x01. While we

cvs commit: src/sys/netinet tcp_output.c

2008-03-09 Thread Bjoern A. Zeeb
bz 2008-03-09 13:26:50 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Padding after EOL option must be zeros according to RFC793 but the NOPs used are 0x01. While we could simply pad with EOLs (which are 0x00), rather use an explicit

cvs commit: src/sys/netinet tcp_output.c

2007-12-05 Thread Bjoern A. Zeeb
bz 2007-12-05 10:37:17 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_output.c Log: MFC: rev. 1.143 sys/netinet/tcp_output.c Make TSO work with IPSEC compiled into the kernel. The lookup hurts a bit for

cvs commit: src/sys/netinet tcp_output.c

2007-12-02 Thread Bjoern A. Zeeb
bz 2007-12-02 10:17:30 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_output.c Log: MFC: rev. 1.144 sys/netinet/tcp_output.c Let opt be an array. Though opt[0] == opt == opt, opt is highly confusing and hard to

cvs commit: src/sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c

2007-12-02 Thread Bjoern A. Zeeb
bz 2007-12-02 10:32:49 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_output.c tcp_subr.c tcp_syncache.c Log: MFC: rev. 1.303 sys/netinet/tcp_subr.c [1] rev. 1.135 sys/netinet/tcp_syncache.c rev. 1.145

cvs commit: src/sys/netinet tcp_output.c

2007-11-30 Thread Bjoern A. Zeeb
bz 2007-11-30 23:46:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Centralize and correct computation of TCP-MD5 signature offset within the packet (tcp header options field). Reviewed by:tools/regression/netinet/tcpconnect

cvs commit: src/sys/netinet tcp_output.c

2007-11-28 Thread Bjoern A. Zeeb
bz 2007-11-28 13:33:27 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Let opt be an array. Though opt[0] == opt == opt, opt is highly confusing and hard to understand so change it to just opt and remove the extra cast no longer/not

cvs commit: src/sys/netinet tcp_output.c

2007-11-21 Thread Bjoern A. Zeeb
bz 2007-11-21 22:30:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Make TSO work with IPSEC compiled into the kernel. The lookup hurts a bit for connections but had been there anyway if IPSEC was compiled in. So moving the lookup

Re: cvs commit: src/sys/netinet tcp_output.c

2007-11-21 Thread Bjoern A. Zeeb
On Wed, 21 Nov 2007, Bjoern A. Zeeb wrote: bz 2007-11-21 22:30:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Make TSO work with IPSEC compiled into the kernel. The lookup hurts a bit for connections but had been there anyway if IPSEC

cvs commit: src/sys/netinet tcp_output.c

2007-06-09 Thread Andre Oppermann
andre 2007-06-09 19:39:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Don't send pure window updates when the peer has closed the connection and won't ever send more data. Revision ChangesPath 1.137 +4 -1

cvs commit: src/sys/netinet tcp_output.c

2007-06-09 Thread Andre Oppermann
andre 2007-06-09 21:19:12 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Make the handling of the tcp window explicit for the SYN_SENT case in tcp_outout(). This is currently not strictly necessary but paves the way to simplify the

cvs commit: src/sys/netinet tcp_output.c

2007-05-25 Thread John Baldwin
jhb 2007-05-25 16:36:39 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_output.c Log: MFC: Fix statistical accounting for bytes and packets during sack retransmits. Revision ChangesPath 1.112.2.2 +1 -1

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-18 Thread Rui Paulo
At Fri, 11 May 2007 21:59:13 +0200, Andre Oppermann wrote: Julian Elischer wrote: Rui Paulo wrote: At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10

cvs commit: src/sys/netinet tcp_output.c

2007-05-18 Thread John Baldwin
jhb 2007-05-18 19:56:24 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Fix statistical accounting for bytes and packets during sack retransmits. MFC after: 1 week Submitted by: mohans Revision ChangesPath 1.136

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-11 Thread Andre Oppermann
Julian Elischer wrote: Rui Paulo wrote: At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files:

cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Andre Oppermann
andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Fix an incorrect replace of a timer reference made during the TCP timer rewrite in rev. 1.132. This unmasked yet another bug that causes certain connections to get

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Andre Oppermann
Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Fix an incorrect replace of a timer reference made during the TCP timer rewrite in rev. 1.132. This unmasked yet another bug that causes

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Rui Paulo
At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Fix an incorrect replace of a timer reference made during the TCP

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Andre Oppermann
Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Fix an incorrect replace of a timer reference made during the TCP

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Rui Paulo
At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Andre Oppermann
Rui Paulo wrote: At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Andre Oppermann
Julian Elischer wrote: Rui Paulo wrote: At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files:

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Julian Elischer
Rui Paulo wrote: At Fri, 11 May 2007 02:12:53 +0200, Andre Oppermann wrote: Rui Paulo wrote: At Fri, 11 May 2007 01:17:09 +0200, Andre Oppermann wrote: Andre Oppermann wrote: andre 2007-05-10 23:11:29 UTC FreeBSD src repository Modified files: sys/netinet

Re: cvs commit: src/sys/netinet tcp_output.c

2007-05-10 Thread Rui Paulo
At Fri, 11 May 2007 02:41:15 +0200, Andre Oppermann wrote: I don't have them handy. Could you resend them to me so I can have a look by tomorrow. http://fnop.net/~rpaulo/priv/freebsd/ They are here. Good night. ___ cvs-all@freebsd.org mailing list

cvs commit: src/sys/netinet tcp_output.c

2007-03-22 Thread Gleb Smirnoff
glebius 2007-03-22 10:55:13 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_output.c Log: Carefully merge revs 1.123, 1.124, omitting the 1.120 change. This should fix resets of the long living TCP connections with EHOSTDOWN

cvs commit: src/sys/netinet tcp_output.c

2007-03-21 Thread Andre Oppermann
andre 2007-03-21 19:04:07 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Subtract optlen in the maximum length check for TSO and finally avoid slightly oversized TSO mbuf chains. Submitted by: kmacy Revision ChangesPath

cvs commit: src/sys/netinet tcp_output.c

2007-03-19 Thread Andre Oppermann
andre 2007-03-19 18:42:28 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Match up SYSCTL_INT declarations in style. Revision ChangesPath 1.128 +2 -2 src/sys/netinet/tcp_output.c

cvs commit: src/sys/netinet tcp_output.c

2007-03-01 Thread Andre Oppermann
andre 2007-03-01 13:12:09 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Prevent TSO mbuf chain from overflowing a few bytes by subtracting the TCP options size before the TSO total length calculation. Bug found by: kmacy

cvs commit: src/sys/netinet tcp_output.c

2007-02-28 Thread Gleb Smirnoff
glebius 2007-02-28 12:41:50 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Toss the code, that handles errors from ip_output(), to make it more readable: - Merge two embedded if() into one. - Introduce switch() block to handle different

cvs commit: src/sys/netinet tcp_output.c

2007-02-28 Thread Gleb Smirnoff
glebius 2007-02-28 12:47:49 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Add EHOSTDOWN and ENETUNREACH to the list of soft errors, that shouldn't be returned up to the caller. PR: 100172 Submitted by: Andrew - Supernews

cvs commit: src/sys/netinet tcp_output.c

2006-09-28 Thread Andre Oppermann
andre 2006-09-28 13:59:26 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: When doing TSO correctly do the check to prevent a maximum sized IP packet from overflowing. Revision ChangesPath 1.119 +1 -1

cvs commit: src/sys/netinet tcp_output.c

2006-09-28 Thread Andre Oppermann
andre 2006-09-28 18:02:46 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: When tcp_output() receives an error upon sending a packet it reverts parts of its internal state to ignore the failed send and try again a bit later. If the error is

cvs commit: src/sys/netinet tcp_output.c

2006-09-15 Thread Andre Oppermann
andre 2006-09-15 16:08:09 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: When doing TSO subtract hdrlen from TCP_MAXWIN to prevent ip-ip_len from wrapping when we generate a maximally sized packet for later segmentation. Noticed by:

cvs commit: src/sys/netinet tcp_output.c

2006-09-07 Thread Andre Oppermann
andre 2006-09-07 12:53:01 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Second step of TSO (TCP segmentation offload) support in our network stack. TSO is only used if we are in a pure bulk sending state. The presence of TCP-MD5,