cvs commit: src/sys/netinet tcp_syncache.c

2008-08-30 Thread Bjoern A. Zeeb
bz 2008-08-30 16:49:36 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: SVN rev 182482 on 2008-08-30 16:49:36Z by bz MFC: svn r182056, cvs 1.154 tcp_syncache.c Cache the cred locally in _syncache_add()

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-30 Thread Bjoern A. Zeeb
bz 2008-08-30 13:26:17 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: SVN rev 182474 on 2008-08-30 13:26:17Z by bz MFC: svn r182045, cvs 1.153 tcp_syncache.c Add an explicit comment why we NULLify the t

cvs commit: src/sys/netinet tcp_syncache.c tcp_syncache.h

2008-08-24 Thread Julian Elischer
julian 2008-08-25 00:33:30 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_syncache.h Log: SVN rev 182129 on 2008-08-25 00:33:30Z by julian Move some struct defs around. This is a prep step for Vimage.A No real effect of this at this tim

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-23 Thread Bjoern A. Zeeb
bz 2008-08-23 14:22:12 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: SVN rev 182056 on 2008-08-23 14:22:12Z by bz Cache the cred locally in _syncache_add() while holding the locks, so we can be sure that it's valid. In case we a

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-23 Thread Bjoern A. Zeeb
bz 2008-08-23 12:27:18 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: SVN rev 182045 on 2008-08-23 12:27:18Z by bz Add an explicit comment why we NULLify the two variables. Reviewed by:rwatson MFC after: 3 days R

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-05 Thread John Baldwin
jhb 2008-08-05 22:22:47 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: SVN rev 181340 on 2008-08-05 22:22:47Z by jhb MFC: Change incorrect stale cookie detection in syncookie_lookup() that prematurely decla

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-05 Thread John Baldwin
jhb 2008-08-05 22:08:04 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: SVN rev 181339 on 2008-08-05 22:08:04Z by jhb MFC: Fix a check in the SYN cache expansion to accept packets that arrive in the receive

cvs commit: src/sys/netinet tcp_syncache.c

2008-08-05 Thread John Baldwin
jhb 2008-08-05 21:59:20 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: SVN rev 181337 on 2008-08-05 21:59:20Z by jhb Minor style tweaks. Revision ChangesPath 1.150 +5 -6 src/sys/netinet/tcp_syncache.c

cvs commit: src/sys/netinet tcp_syncache.c

2008-07-30 Thread Kip Macy
kmacy 2008-07-30 20:51:20 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: SVN rev 181014 on 2008-07-30 20:51:20Z by kmacy MFC interface for external consumers to syncache_expand RevisionChangesPath

cvs commit: src/sys/netinet tcp_syncache.c tcp_syncache.h

2008-07-20 Thread Kip Macy
kmacy 2008-07-21 02:11:06 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_syncache.h Log: SVN rev 180645 on 2008-07-21 02:11:06Z by kmacy add interface for external consumers to syncache_expand - rename syncache_add in a manner consisten

cvs commit: src/sys/netinet tcp_syncache.c

2008-06-16 Thread Stephan Uphoff
ups 2008-06-16 20:08:22 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: SVN rev 179833 on 2008-06-16 20:08:22Z by ups Change incorrect stale cookie detection in syncookie_lookup() that prematurely declared a cookie as expired. R

cvs commit: src/sys/netinet tcp_syncache.c

2008-06-16 Thread Stephan Uphoff
ups 2008-06-16 19:56:59 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: SVN rev 179832 on 2008-06-16 19:56:59Z by ups Fix a check in SYN cache expansion (syncache_expand()) to accept packets that arrive in the receive window instead o

cvs commit: src/sys/netinet tcp_syncache.c

2008-05-19 Thread John Baldwin
jhb 2008-05-19 18:23:09 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: MFC: Always bump tcpstat.tcps_badrst if we get a RST for a connection in the syncache that has an invalid SEQ. Revision ChangesPa

cvs commit: src/sys/netinet tcp_syncache.c

2008-05-08 Thread John Baldwin
jhb 2008-05-08 22:21:09 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Always bump tcpstat.tcps_badrst if we get a RST for a connection in the syncache that has an invalid SEQ instead of only doing it when we suceed in mallocing space

cvs commit: src/sys/netinet tcp_syncache.c

2008-04-18 Thread Kip Macy
kmacy 2008-04-19 03:39:17 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: move tcbinfo lock acquisition in to syncache Revision ChangesPath 1.143 +3 -0 src/sys/netinet/tcp_syncache.c __

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-24 Thread Kip Macy
Whatever, just run all future changes by silby. On Jan 24, 2008 2:58 AM, Andre Oppermann <[EMAIL PROTECTED]> wrote: > Kip Macy wrote: > > Did you talk to the original submitter? Note that FreeBSD's TCP stack > > is for use in servers and is not intending as a validating TCP stack. > > If you would

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-24 Thread Mike Karels
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]> In-Reply-To: <[EMAIL PROTECTED]> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mike Silbersack <[EMAIL PROTECTED]>, [EMAIL PROTECTED], [EMAIL PROTECTED], cvs-all@fr

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-24 Thread Maxim Konovalov
[...] > > I'm not generally opposed to security improvements that only affect edge > > cases... but being unable to connect is not an edge case! > > Fully agreed. I'll reopen the PR and follow up with the originator > to do some further analysis. All operating system he cites that were > unable t

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-24 Thread Andre Oppermann
Kip Macy wrote: Did you talk to the original submitter? Note that FreeBSD's TCP stack is for use in servers and is not intending as a validating TCP stack. If you would like it to serve as such you would better served by tracking down the ANVL tests that FreeBSD fails. Also note that there is no

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-24 Thread Andre Oppermann
Mike Silbersack wrote: On Wed, 23 Jan 2008, Andre Oppermann wrote: OTOH the enforcement of this rule wasn't really there before and it may be argued that we've got a POLA violation here. A careful reading That's exactly the point. We were not enforcing timestamps since... whenever the RFC

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-23 Thread Mike Silbersack
On Wed, 23 Jan 2008, Andre Oppermann wrote: OTOH the enforcement of this rule wasn't really there before and it may be argued that we've got a POLA violation here. A careful reading That's exactly the point. We were not enforcing timestamps since... whenever the RFC1323 code went in. Then

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-23 Thread Kip Macy
Did you talk to the original submitter? Note that FreeBSD's TCP stack is for use in servers and is not intending as a validating TCP stack. If you would like it to serve as such you would better served by tracking down the ANVL tests that FreeBSD fails. Also note that there is no MUST in the follow

Re: cvs commit: src/sys/netinet tcp_syncache.c

2008-01-23 Thread Andre Oppermann
Mike Silbersack wrote: silby 2007-11-20 06:56:04 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Comment out the syncache's test which ensures that hosts which negotiate TCP timestamps in the initial SYN packet actually use them in the r

cvs commit: src/sys/netinet tcp_syncache.c

2007-12-20 Thread Ruslan Ermilov
ru 2007-12-20 12:34:32 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: MFC: 1.141: Fix bugs in the TCP syncache timeout code. Approved by:re (kensmith) Revision ChangesPath 1.130.2.6 +18 -8

cvs commit: src/sys/netinet tcp_syncache.c

2007-12-19 Thread Ruslan Ermilov
ru 2007-12-19 16:56:28 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix bugs in the TCP syncache timeout code. including: When system ticks are positive, for entries in the cache bucket, syncache_timer() ran on every tick (doing

cvs commit: src/sys/netinet tcp_syncache.c tcp_syncache.h

2007-12-12 Thread Kip Macy
kmacy 2007-12-12 20:35:59 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_syncache.h Log: Add interface for tcp offload to syncache: - make neccessary changes to release offload resources when a syncache entry is removed before connect

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-12-12 Thread Andrey Chernov
On Wed, Dec 12, 2007 at 06:11:50AM +, Kip Macy wrote: > kmacy 2007-12-12 06:11:50 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_syncache.c > Log: > Remove spurious timestamp check. RFC 1323 explicitly states that timestamps > MAY > be tran

cvs commit: src/sys/netinet tcp_syncache.c

2007-12-11 Thread Kip Macy
kmacy 2007-12-12 06:11:50 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Remove spurious timestamp check. RFC 1323 explicitly states that timestamps MAY be transmitted if negotiated. Revision ChangesPath 1.138 +1 -17 s

cvs commit: src/sys/netinet tcp_syncache.c

2007-12-06 Thread Mike Silbersack
silby 2007-12-07 05:52:24 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: MFC rev 1.136: Fix SACK No merges to branches prior to 7 are necessary; this is a 7 and above bug only. Approved by:re (gnn)

cvs commit: src/sys/netinet tcp_syncache.c

2007-12-03 Thread Mike Silbersack
silby 2007-12-04 07:11:13 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix SACK negotiation that was broken in rev 1.105. Before this fix, FreeBSD would negotiate SACK on outgoing connections, but would always fail to negotiate it o

cvs commit: src/sys/netinet tcp_syncache.c

2007-11-30 Thread Bjoern A. Zeeb
bz 2007-11-30 23:41:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Move call to tcp_signature_compute() after we adjusted the payload offset in the tcp header. With relevant parts of the tcp header changing after the 'signature' wa

cvs commit: src/sys/netinet tcp_syncache.c

2007-11-20 Thread Mike Silbersack
silby 2007-11-20 15:26:18 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c Log: MFC rev 1.134: Comment out the syncache's test which ensures that hosts which negotiate TCP timestamps in the initial SYN packet actually us

cvs commit: src/sys/netinet tcp_syncache.c

2007-11-19 Thread Mike Silbersack
silby 2007-11-20 06:56:04 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Comment out the syncache's test which ensures that hosts which negotiate TCP timestamps in the initial SYN packet actually use them in the rest of the connection.

cvs commit: src/sys/netinet tcp_syncache.c tcp_usrreq.c

2007-10-25 Thread Mike Silbersack
silby 2007-10-26 05:41:25 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_syncache.c tcp_usrreq.c Log: MFC: tcp_syncache.c rev 1.131 tcp_usrreq.c rev 1.164 Pick the smallest possible TCP window scaling facto

cvs commit: src/sys/netinet tcp_syncache.c src/sys/security/mac mac_framework.h mac_inet.c mac_policy.h src/sys/security/mac_biba mac_biba.c src/sys/security/mac_lomac mac_lomac.c src/sys/security/mac

2007-10-25 Thread Robert Watson
rwatson 2007-10-25 14:37:37 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c sys/security/mac mac_framework.h mac_inet.c mac_policy.h sys/security/mac_biba mac_biba.c sys/security/mac_lomac mac_lomac.c sys/security/mac_mls mac_mls.

cvs commit: src/sys/netinet tcp_syncache.c tcp_usrreq.c

2007-10-19 Thread Mike Silbersack
silby 2007-10-19 08:53:15 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_usrreq.c Log: Pick the smallest possible TCP window scaling factor that will still allow us to scale up to sb_max, aka kern.ipc.maxsockbuf. We do this because the

cvs commit: src/sys/netinet tcp_syncache.c

2007-09-28 Thread Maxim Konovalov
maxim 2007-09-28 17:39:45 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_syncache.c Log: o Update tcp sendcookie stats. HEAD has a different code and does not have this bug. Submitted by: Igor Sysoev Reviewed by:sil

cvs commit: src/sys/netinet tcp_syncache.c

2007-07-29 Thread Bruce A. Mah
bmah2007-07-29 20:13:22 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix a typo in a log message: s/Reveived/Received/. Approved by:re (rwatson) Revision ChangesPath 1.128 +1 -1 src/sys/netinet/tcp_syncache

cvs commit: src/sys/netinet tcp_syncache.c

2007-07-28 Thread Mike Silbersack
silby 2007-07-28 20:13:40 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix a panic introduced in rev 1.126. Approved by: re (rwatson) Revision ChangesPath 1.127 +1 -1 src/sys/netinet/tcp_syncache.c ___

cvs commit: src/sys/netinet tcp_syncache.c

2007-07-28 Thread Andre Oppermann
andre 2007-07-28 12:02:05 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: o Move setting/resetting logic of syncache timer from macro SYNCACHE_TIMEOUT to new function syncache_timeout(). o Fix inverted timeout callout engagement logic t

cvs commit: src/sys/netinet tcp_syncache.c

2007-06-06 Thread Andre Oppermann
andre 2007-06-06 22:10:12 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Correctly print SEQ and IRS in the corresponding log message in syncache_expand(). Revision ChangesPath 1.121 +1 -1 src/sys/netinet/tcp_syncache.

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-30 Thread Dmitry Morozovsky
On Mon, 28 May 2007, Gleb Smirnoff wrote: GS> On Fri, May 25, 2007 at 04:58:23PM -0600, M. Warner Losh wrote: GS> M> : during program debugging. Everything below LOG_NOTICE should not GS> M> : need fsync after each line. An examination of all users of LOG_DEBUG GS> M> : in our kernel doesn't sho

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-28 Thread Gleb Smirnoff
On Fri, May 25, 2007 at 04:58:23PM -0600, M. Warner Losh wrote: M> : during program debugging. Everything below LOG_NOTICE should not M> : need fsync after each line. An examination of all users of LOG_DEBUG M> : in our kernel doesn't show anything critical that would require fsync. M> : The atta

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-25 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Andre Oppermann <[EMAIL PROTECTED]> writes: : Robert Watson wrote: : > : > On Fri, 25 May 2007, Andre Oppermann wrote: : > : >>> Kernel-sourced log messages result in an fsync() of log files the : >>> message is written to, as syslogd feels that kernel

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-25 Thread Andre Oppermann
Robert Watson wrote: On Fri, 25 May 2007, Andre Oppermann wrote: Kernel-sourced log messages result in an fsync() of log files the message is written to, as syslogd feels that kernel messages are very important and should go to disk as quickly and reliably as possible. As a result, it's ver

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-25 Thread Robert Watson
On Fri, 25 May 2007, Andre Oppermann wrote: Kernel-sourced log messages result in an fsync() of log files the message is written to, as syslogd feels that kernel messages are very important and should go to disk as quickly and reliably as possible. As a result, it's very desirable to rate li

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-25 Thread Andre Oppermann
Robert Watson wrote: On Thu, 24 May 2007, Gleb Smirnoff wrote: A> W/o logging we have no way of really knowing. Before we were possibly A> accepting stuff we shouldn't have (spoofing and attacks). Now we may A> drop stuff we perhaps should accept anyway. W/o logging diagnosing a A> TCP

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-25 Thread Robert Watson
On Thu, 24 May 2007, Gleb Smirnoff wrote: A> W/o logging we have no way of really knowing. Before we were possibly A> accepting stuff we shouldn't have (spoofing and attacks). Now we may A> drop stuff we perhaps should accept anyway. W/o logging diagnosing a A> TCP problem was very diffi

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-24 Thread Andre Oppermann
Gleb Smirnoff wrote: On Thu, May 24, 2007 at 01:36:49AM +0200, Andre Oppermann wrote: A> Yes, these logs can be triggered remotely. Broken packets and spoofed A> packets may cause them. We're interested in the former. A> A> I'll do some benchmarks on the impact of the logging and then decid

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-24 Thread Gleb Smirnoff
On Thu, May 24, 2007 at 01:36:49AM +0200, Andre Oppermann wrote: A> Yes, these logs can be triggered remotely. Broken packets and spoofed A> packets may cause them. We're interested in the former. A> A> I'll do some benchmarks on the impact of the logging and then decide A> whether to put it

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-23 Thread Andre Oppermann
Gleb Smirnoff wrote: On Fri, May 18, 2007 at 09:13:01PM +, Andre Oppermann wrote: A> andre 2007-05-18 21:13:01 UTC A> A> FreeBSD src repository A> A> Modified files: A> sys/netinet tcp_syncache.c A> Log: A> o Add syslog logging under LOG_DEBUG to various failure

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-21 Thread Gleb Smirnoff
On Fri, May 18, 2007 at 09:13:01PM +, Andre Oppermann wrote: A> andre 2007-05-18 21:13:01 UTC A> A> FreeBSD src repository A> A> Modified files: A> sys/netinet tcp_syncache.c A> Log: A> o Add syslog logging under LOG_DEBUG to various failures caused by A> bogus

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-05-18 Thread Andre Oppermann
Andre Oppermann wrote: andre 2007-05-18 21:42:26 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Be more restrictive with segment validity checks in syncache_expand() and log check failures to syslog at LOG_DEBUG level. Always prefi

cvs commit: src/sys/netinet tcp_syncache.c

2007-05-18 Thread Andre Oppermann
andre 2007-05-18 21:42:26 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Be more restrictive with segment validity checks in syncache_expand() and log check failures to syslog at LOG_DEBUG level. Always prefill the sc->sc_ts field to

cvs commit: src/sys/netinet tcp_syncache.c

2007-05-18 Thread Andre Oppermann
andre 2007-05-18 21:13:01 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: o Add syslog logging under LOG_DEBUG to various failures caused by bogus segments o Add more KASSERT()s o Update comments Revision ChangesPath 1.117

cvs commit: src/sys/netinet tcp_syncache.c

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 13:36:49 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Only update TCP timestamp on SYN duplication if it is present on current SYN in syncache_add(). Otherwise disable timestamps. Revision ChangesPath 1.112

cvs commit: src/sys/netinet tcp_syncache.c

2007-04-20 Thread Andre Oppermann
andre 2007-04-20 13:30:08 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: o Plug memory leak in syncache_add() on MAC label allocation failure. o Simplify code flow with 'done' goto label. o Remove mbuf argument from syncache_respond().

cvs commit: src/sys/netinet tcp_syncache.c

2007-04-17 Thread Andre Oppermann
andre 2007-04-17 15:25:14 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: When we run into the syncache entry limits syncache_add() tries to free the oldest entry in the current bucket row. The global entry limit may be smaller than the

Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-19 Thread John Hay
On Mon, Mar 19, 2007 at 07:16:38PM +0900, Hajimu UMEMOTO wrote: > Hi, > > > On Mon, 19 Mar 2007 09:48:50 +0100 > > Andre Oppermann <[EMAIL PROTECTED]> said: > > andre> I thought I had tested IPv6 as well but as it turns out I have > andre> changed /etc/hosts to use IPv4 first instead of I

Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-19 Thread Hajimu UMEMOTO
Hi, > On Mon, 19 Mar 2007 09:48:50 +0100 > Andre Oppermann <[EMAIL PROTECTED]> said: andre> I thought I had tested IPv6 as well but as it turns out I have andre> changed /etc/hosts to use IPv4 first instead of IPv6 as is the andre> default. We should think of doing this in -current for 7

Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-19 Thread Andre Oppermann
Kip Macy wrote: With Andre's most recent changes what is the result? Also, is this all over localhost or? Andre's commit fixed the problem. Looking at the fix the problem couldn't have been isolated to localhost. My original patch had two problems in syncache that broke IPv6 independently.

Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-18 Thread Kip Macy
With Andre's most recent changes what is the result? Also, is this all over localhost or? Andre's commit fixed the problem. Looking at the fix the problem couldn't have been isolated to localhost. -Kip ___ cvs-all@freebsd.org mailing list ht

Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-18 Thread gnn
At Sat, 17 Mar 2007 00:27:51 -0700, Kip Macy wrote: > > On 3/16/07, Kip Macy <[EMAIL PROTECTED]> wrote: > > I didn't realize that FreeBSD uses ipv6 by default, so X11 should be > > using it. However, connections take a long long time now. Previously > > it took 1s for an xterm to come up, now it t

cvs commit: src/sys/netinet tcp_syncache.c

2007-03-17 Thread Andre Oppermann
andre 2007-03-17 11:52:54 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Unbreak IPv6 after consolidation of TCP options insertion. Submitted by: tegge Revision ChangesPath 1.107 +2 -3 src/sys/netinet/tcp_syncache

IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-16 Thread Kip Macy
On 3/16/07, Kip Macy <[EMAIL PROTECTED]> wrote: I didn't realize that FreeBSD uses ipv6 by default, so X11 should be using it. However, connections take a long long time now. Previously it took 1s for an xterm to come up, now it takes 20 - 30. Andre - if you're unable to isolate the problem plea

Re: cvs commit: src/sys/netinet tcp_syncache.c

2007-03-16 Thread Kip Macy
I didn't realize that FreeBSD uses ipv6 by default, so X11 should be using it. However, connections take a long long time now. Previously it took 1s for an xterm to come up, now it takes 20 - 30. Andre - if you're unable to isolate the problem please back out your recent changes. -

cvs commit: src/sys/netinet tcp_syncache.c

2007-03-16 Thread Kip Macy
kmacy 2007-03-17 06:40:09 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix the most obvious of the bugs introduced by recent syncache changes - *ip is not initialized in the case of inet6 connection, but ip->ip_len is being change

cvs commit: src/sys/netinet tcp_syncache.c tcp_usrreq.c

2007-02-01 Thread Andre Oppermann
andre 2007-02-01 17:39:19 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_usrreq.c Log: Change the way the advertized TCP window scaling is computed. Instead of upper-bounding it to the size of the initial socket buffer lower-bound it to

cvs commit: src/sys/netinet tcp_syncache.c src/sys/security/mac mac_framework.h mac_inet.c src/sys/sys mac_policy.h

2006-12-12 Thread Christian S.J. Peron
csjp2006-12-13 06:00:57 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c sys/security/mac mac_framework.h mac_inet.c sys/sys mac_policy.h Log: Fix LOR between the syncache and inpcb locks when MAC is present in the ke

cvs commit: src/sys/netinet tcp_syncache.c

2006-09-14 Thread Andrey A. Chernov
ache2006-09-14 10:22:35 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Add missing #ifdef INET6 (can't be compiled) Revision ChangesPath 1.101 +2 -0 src/sys/netinet/tcp_syncache.c __

cvs commit: src/sys/netinet tcp_syncache.c

2006-09-13 Thread Andre Oppermann
andre 2006-09-13 13:21:18 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Remove unessary includes and follow common ordering style. Revision ChangesPath 1.100 +2 -10 src/sys/netinet/tcp_syncache.c

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-26 Thread Andre Oppermann
andre 2006-06-26 17:54:53 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: In syncache_respond() do not reply with a MSS that is larger than what the peer announced to us but make it at least tcp_minmss in size. Sponsored by: TCP/IP O

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-26 Thread Andre Oppermann
andre 2006-06-26 09:43:55 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Reverse the source/destination parameters to in[6]_pcblookup_hash() in syncache_respond() for the #ifdef MAC case. Submitted by: Tai-hwa Liang Revision

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-25 Thread Andre Oppermann
andre 2006-06-25 11:11:34 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Decrement the global syncache counter in syncache_expand() when the entry is removed from the bucket. This fixes the syncache statistics. Revision ChangesP

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-22 Thread Andre Oppermann
andre 2006-06-22 15:07:45 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Move the syncookie MD5 context from globals to the stack to make it MP safe. Revision ChangesPath 1.94 +2 -2 src/sys/netinet/tcp_syncache.c __

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-20 Thread Andre Oppermann
andre 2006-06-20 08:11:30 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Allocate a zero'ed syncache hashtable. mtx_init() tests the supplied memory location for already existing/initialized mutexes. With random data in the memory loca

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-18 Thread Andre Oppermann
andre 2006-06-18 13:03:42 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Do not access syncache entry before it was allocated for the TF_NOOPT case in syncache_add(). Found by: Coverity Prevent CID:1473 Revisi

cvs commit: src/sys/netinet tcp_syncache.c tcp_var.h

2006-06-18 Thread Andre Oppermann
andre 2006-06-18 12:26:11 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_var.h Log: Move all syncache related structures to tcp_syncache.c. They are only used there. This unbreaks userland programs that include tcp_var.h. Discuss

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-18 Thread Andre Oppermann
andre 2006-06-18 11:48:03 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Remove double lock acquisition in syncookie_lookup() which came from last minute conversions to macros. Pointy hat to: andre Revision ChangesPath 1.

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-17 Thread Andre Oppermann
andre 2006-06-17 18:42:07 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix the !INET6 compile. Reported by:alc Revision ChangesPath 1.89 +4 -2 src/sys/netinet/tcp_syncache.c __

cvs commit: src/sys/netinet tcp_syncache.c

2006-06-17 Thread Andre Oppermann
andre 2006-06-17 17:49:11 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: ANSIfy and tidy up comments. Sponsored by: TCP/IP Optimization Fundraise 2005 Revision ChangesPath 1.88 +23 -52src/sys/netinet/tcp_syncache.

cvs commit: src/sys/netinet tcp_syncache.c

2006-02-16 Thread Qing Li
qingli 2006-02-16 18:05:03 UTC FreeBSD src repository Modified files:(Branch: RELENG_5) sys/netinet tcp_syncache.c Log: Fixes a crash due to the memory of the newly allocated syncache entry in syncache_lookup() is not cleared and may lead to an arbitrary and

cvs commit: src/sys/netinet tcp_syncache.c

2006-02-15 Thread Qing Li
qingli 2006-02-16 01:06:22 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_syncache.c Log: MFC:rev 1.84 Approved by:re (scottl) Revision ChangesPath 1.74.2.5 +3 -4 src/sys/netinet/tcp_syncache.c __

cvs commit: src/sys/netinet tcp_syncache.c

2006-02-09 Thread Qing Li
qingli 2006-02-09 21:29:02 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Set the M_ZERO flag when calling uma_zalloc() to allocate a syncache entry. Reviewed by:andre, glebius MFC after: 3 days Revision ChangesPath

Re: cvs commit: src/sys/netinet tcp_syncache.c

2006-02-09 Thread Jeff Roberson
On Thu, 9 Feb 2006, Gleb Smirnoff wrote: On Wed, Feb 08, 2006 at 11:32:58PM +, Qing Li wrote: Q> qingli 2006-02-08 23:32:58 UTC Q> Q> FreeBSD src repository Q> Q> Modified files: Q> sys/netinet tcp_syncache.c Q> Log: Q> Redo the previous fix by setting the UMA_ZONE_

Re: cvs commit: src/sys/netinet tcp_syncache.c

2006-02-09 Thread Gleb Smirnoff
On Wed, Feb 08, 2006 at 11:32:58PM +, Qing Li wrote: Q> qingli 2006-02-08 23:32:58 UTC Q> Q> FreeBSD src repository Q> Q> Modified files: Q> sys/netinet tcp_syncache.c Q> Log: Q> Redo the previous fix by setting the UMA_ZONE_ZINIT bit in the syncache Q> zone, elim

cvs commit: src/sys/netinet tcp_syncache.c

2006-02-08 Thread Qing Li
qingli 2006-02-08 23:32:58 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Redo the previous fix by setting the UMA_ZONE_ZINIT bit in the syncache zone, eliminating the need to call bzero() after each syncache entry allocation. Sugges

Re: cvs commit: src/sys/netinet tcp_syncache.c

2006-02-08 Thread Gleb Smirnoff
On Tue, Feb 07, 2006 at 07:59:46PM +, Qing Li wrote: Q> qingli 2006-02-07 19:59:46 UTC Q> Q> FreeBSD src repository Q> Q> Modified files: Q> sys/netinet tcp_syncache.c Q> Log: Q> Fixes a crash due to the memory of the newly allocated syncache entry Q> in syncache_

cvs commit: src/sys/netinet tcp_syncache.c

2006-02-07 Thread Qing Li
qingli 2006-02-07 19:59:46 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fixes a crash due to the memory of the newly allocated syncache entry in syncache_lookup() is not cleared and may lead to an arbitrary and bogus rtentry pointer whi

cvs commit: src/sys/netinet tcp_syncache.c

2006-01-31 Thread Andre Oppermann
andre 2006-01-31 16:03:42 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_syncache.c Log: MFC 1.81: In syncache_expand() fix a case that currently can't be triggered. Revision ChangesPath 1.74.2.4 +4 -1 src/sys/net

cvs commit: src/sys/netinet tcp_syncache.c

2006-01-18 Thread Andre Oppermann
andre 2006-01-18 18:25:03 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: In syncache_expand() insert a proper syncache_free() to fix a case that currently can't be triggered. But better be safe than sorry later on. Additionally it prop

cvs commit: src/sys/netinet tcp_syncache.c

2006-01-14 Thread Gleb Smirnoff
glebius 2006-01-14 13:04:08 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: UMA can return NULL not only in case when our zone is full, but also in case of generic memory shortage. In the latter case we may not find an old entry. Found