cvs commit: src/usr.bin/tar write.c

2008-08-27 Thread Tim Kientzle
kientzle2008-08-28 05:53:51 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 182350 on 2008-08-28 05:53:51Z by kientzle MFC r180281: Simplify handling of fd's to ensure they don't get leaked. Revision Chang

cvs commit: src/usr.bin/tar write.c

2008-08-27 Thread Tim Kientzle
kientzle2008-08-28 05:39:20 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 182343 on 2008-08-28 05:39:20Z by kientzle MFC r179988: Include the name of the truncated file in the error message. Revision Cha

cvs commit: src/usr.bin/tar write.c

2008-08-12 Thread Tim Kientzle
kientzle2008-08-13 05:54:49 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 181681 on 2008-08-13 05:54:49Z by kientzle MFC r180274: Minor fix for Linux build Revision ChangesPath 1.41.2.17 +0 -3

cvs commit: src/usr.bin/tar write.c

2008-08-12 Thread Tim Kientzle
kientzle2008-08-13 05:41:09 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 181676 on 2008-08-13 05:41:09Z by kientzle MFC r179236: No need to guard against free(NULL) Revision ChangesPath 1.41.2.16

cvs commit: src/usr.bin/tar write.c

2008-08-12 Thread Tim Kientzle
kientzle2008-08-13 05:36:49 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 181674 on 2008-08-13 05:36:49Z by kientzle MFC r178714: Allow -r with -T when there are no files on the command line PR:

cvs commit: src/usr.bin/tar write.c

2008-08-12 Thread Tim Kientzle
kientzle2008-08-13 05:27:32 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: SVN rev 181670 on 2008-08-13 05:27:32Z by kientzle MFC r176395: Allow appending to archives on block devices Revision ChangesPath 1

cvs commit: src/usr.bin/tar write.c

2008-08-10 Thread Tim Kientzle
kientzle2008-08-10 07:43:19 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181517 on 2008-08-10 07:43:19Z by kientzle MFC r180281: Clean up fd handling. Revision ChangesPath 1.63.2.9 +14 -13src

cvs commit: src/usr.bin/tar write.c

2008-08-10 Thread Tim Kientzle
kientzle2008-08-10 07:41:00 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181516 on 2008-08-10 07:41:00Z by kientzle MFC r180277: Restore an unnecessary NULL check, for stylistic reasons. Revision Change

cvs commit: src/usr.bin/tar write.c

2008-08-10 Thread Tim Kientzle
kientzle2008-08-10 07:38:25 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181515 on 2008-08-10 07:38:25Z by kientzle MFC r179988: Include the filename when reporting file truncation. Revision ChangesP

cvs commit: src/usr.bin/tar write.c

2008-08-10 Thread Tim Kientzle
kientzle2008-08-10 07:15:33 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181513 on 2008-08-10 07:15:33Z by kientzle MFC r179236: Remove an unnecessary check for NULL Revision ChangesPath 1.63.2.5

cvs commit: src/usr.bin/tar write.c

2008-08-09 Thread Tim Kientzle
kientzle2008-08-10 06:44:39 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181506 on 2008-08-10 06:44:39Z by kientzle MFC r178714: allow -r and -T together even when there are no files on the command line.

cvs commit: src/usr.bin/tar write.c

2008-08-09 Thread Tim Kientzle
kientzle2008-08-10 06:24:31 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/tar write.c Log: SVN rev 181499 on 2008-08-10 06:24:31Z by kientzle MFC r176395 | kientzle | 2008-02-18 21:27:17 -0800 (Mon, 18 Feb 2008) > Allow appending

cvs commit: src/usr.bin/tar write.c

2008-07-05 Thread Colin Percival
cperciva2008-07-05 08:10:55 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: SVN rev 180284 on 2008-07-05 08:10:55Z by cperciva Move duplicated code from tar_mode_[cru] into archive_write. Fix a bug I introduced 7 minutes ago: clean up proper

cvs commit: src/usr.bin/tar write.c

2008-07-04 Thread Colin Percival
cperciva2008-07-05 06:05:34 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: SVN rev 180281 on 2008-07-05 06:05:34Z by cperciva Clean up write_entry by eliminating fd except in the #ifdef __linux block where it is used. [1] Don't leak file

cvs commit: src/usr.bin/tar write.c

2008-07-04 Thread Colin Percival
cperciva2008-07-05 02:21:51 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: SVN rev 180277 on 2008-07-05 02:21:51Z by cperciva Revert CVS revision 1.68; it is now possible for entry to be NULL at the end of write_entry. (This was perfectly saf

cvs commit: src/usr.bin/tar write.c

2008-07-04 Thread Tim Kientzle
kientzle2008-07-05 02:06:55 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: SVN rev 180274 on 2008-07-05 02:06:55Z by kientzle Stop using the deprecated linux/ext2_fs.h. Revision ChangesPath 1.72 +0 -3 src/usr.bin/tar/write.

cvs commit: src/usr.bin/tar write.c

2008-06-24 Thread Tim Kientzle
kientzle2008-06-25 05:01:02 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: SVN rev 179988 on 2008-06-25 05:01:02Z by kientzle Pass the entry down into the core write loop, so we can include the filename when reporting errors. Thanks to: D

cvs commit: src/usr.bin/tar write.c

2008-05-22 Thread Colin Percival
cperciva2008-05-23 05:07:22 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: The value le->name cannot be NULL when we're freeing an entry in the hardlink table for two reasons: 1. If le->name is set to NULL, the structure le won't be inserted into

cvs commit: src/usr.bin/tar write.c

2008-05-19 Thread Colin Percival
cperciva2008-05-19 18:09:26 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: There's no way for entry to possibly be NULL at the end of write_entry (in fact, there has never been any way for it to be NULL, going all the way back to revision 1.1 of

cvs commit: src/usr.bin/tar write.c

2008-05-01 Thread Tim Kientzle
kientzle2008-05-02 05:14:58 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Allow -r with -T even if there are no files on the command line. PR: bin/123246 MFC after: 3 days Revision ChangesPath 1.66 +1 -1 src/usr.bin/tar/

cvs commit: src/usr.bin/tar write.c

2008-02-18 Thread Tim Kientzle
kientzle2008-02-19 05:27:17 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Allow appending to archives on block devices as well as archives in regular files, since both are seekable. Thanks to: Reinoud Zandijk (@netbsd.org) Revision Chan

cvs commit: src/usr.bin/tar write.c

2007-08-24 Thread Tim Kientzle
kientzle2007-08-25 04:27:41 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC: Don't try to store file body if there was a fatal error writing the header. Revision ChangesPath 1.41.2.12 +1 -1 src/usr.b

cvs commit: src/usr.bin/tar write.c

2007-08-24 Thread Tim Kientzle
kientzle2007-08-25 04:08:46 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC refactored code to copy entry from one archive to another. This is the code that implements the @ interpolation feature. Revision Chang

cvs commit: src/usr.bin/tar write.c

2007-05-24 Thread Colin Percival
cperciva2007-05-24 09:27:50 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC rev. 1.62: Complain about "tar -c /path/which/does/not/exist". Revision ChangesPath 1.41.2.7 +10 -0 src/usr.bin/tar/write.c

Re: cvs commit: src/usr.bin/tar write.c

2007-05-04 Thread Tim Kientzle
I wonder if it would be simpler to set non-zero exit only if this is the first path returned from tree_next() ... Hmm... I considered this, but I wasn't sure if there were any edge cases where the first path returned by tree_next might not be the path passed to tree_open; so I decided to take th

Re: cvs commit: src/usr.bin/tar write.c

2007-05-04 Thread Alexander Leidinger
Quoting Colin Percival <[EMAIL PROTECTED]> (from Thu, 03 May 2007 10:20:22 -0700): Tim Kientzle wrote: I wonder if it would be simpler to set non-zero exit only if this is the first path returned from tree_next() (which should be the path given on the command line). That would avoid the head

Re: cvs commit: src/usr.bin/tar write.c

2007-05-03 Thread Colin Percival
Tim Kientzle wrote: > I wonder if it would be simpler to set non-zero exit only > if this is the first path returned from tree_next() (which > should be the path given on the command line). That > would avoid the headache of having to perform a textual > path comparison. > > A simple flag to indi

Re: cvs commit: src/usr.bin/tar write.c

2007-05-03 Thread Kris Kennaway
On Thu, May 03, 2007 at 09:29:52AM -0400, Mikhail T. wrote: > Kris Kennaway wrote: > >On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > > > >>Rong-en Fan wrote: > >> > >>>On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: > >>> > Modified files: > usr.bi

Re: cvs commit: src/usr.bin/tar write.c

2007-05-03 Thread Mikhail T.
Kris Kennaway wrote: On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: Rong-en Fan wrote: On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: Modified files: usr.bin/tar write.c Log: Don't consider an lstat(2) failure to be an error (in the sen

Re: cvs commit: src/usr.bin/tar write.c

2007-05-03 Thread Rong-en Fan
On 5/3/07, Colin Percival <[EMAIL PROTECTED]> wrote: Rong-en Fan wrote: > On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: >> Modified files: >> usr.bin/tar write.c >> Log: >> Don't consider an lstat(2) failure to be an error (in the sense of >> affecting the return valu

Re: cvs commit: src/usr.bin/tar write.c

2007-05-02 Thread Kris Kennaway
On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > Rong-en Fan wrote: > > On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: > >> Modified files: > >> usr.bin/tar write.c > >> Log: > >> Don't consider an lstat(2) failure to be an error (in the sense of > >> af

Re: cvs commit: src/usr.bin/tar write.c

2007-05-02 Thread Tim Kientzle
Colin Percival wrote: cperciva2007-05-03 04:33:11 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: If lstat(2) fails, have bsdtar return a non-zero exit code if the failed path is one which was specified on the command line. This looks like a ni

Re: cvs commit: src/usr.bin/tar write.c

2007-05-02 Thread Colin Percival
Rong-en Fan wrote: > On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: >> Modified files: >> usr.bin/tar write.c >> Log: >> Don't consider an lstat(2) failure to be an error (in the sense of >> affecting the return value from bsdtar) [...] > > This commit makes 'make packa

cvs commit: src/usr.bin/tar write.c

2007-05-02 Thread Colin Percival
cperciva2007-05-03 04:33:11 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: If lstat(2) fails, have bsdtar return a non-zero exit code if the failed path is one which was specified on the command line. This is a compromise between the situation

Re: cvs commit: src/usr.bin/tar write.c

2007-05-02 Thread Rong-en Fan
On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: cperciva2007-03-15 10:11:38 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Don't consider an lstat(2) failure to be an error (in the sense of affecting the return value from bsdtar), since (a)

cvs commit: src/usr.bin/tar write.c

2007-04-09 Thread Colin Percival
cperciva2007-04-09 08:22:34 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Clean up error handling in archive_append to match how errors are handled in write_hierarchy. Approved by:kientzle Revision ChangesPath 1.61 +39 -1

cvs commit: src/usr.bin/tar write.c

2007-03-31 Thread Colin Percival
cperciva2007-03-31 10:14:03 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Split the append_archive function (used for processing @ directives) into separate append_archive and append_archive_filename functions; the first takes a "struct archive

cvs commit: src/usr.bin/tar write.c

2007-03-21 Thread Colin Percival
cperciva2007-03-21 15:15:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC revisions 1.5[6789]: * Remove unused pathlen argument from write_entry function. * Fix logic bug in deciding if do_chdir should be called.

cvs commit: src/usr.bin/tar write.c

2007-03-17 Thread Colin Percival
cperciva2007-03-17 19:18:29 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Remove pathlen argument from write_entry function. It has never been used. Approved by:kientzle MFC after: 3 days Revision ChangesPath 1.59 +

cvs commit: src/usr.bin/tar write.c

2007-03-17 Thread Colin Percival
cperciva2007-03-17 16:17:15 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Fix logic bug; we want to do_chdir if arg doesn't start with / _and_ it doesn't start with @/ either. This unbreaks "tar -c -C /no/such/directory @/path/to/archive".

cvs commit: src/usr.bin/tar write.c

2007-03-15 Thread Colin Percival
cperciva2007-03-15 10:11:38 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Don't consider an lstat(2) failure to be an error (in the sense of affecting the return value from bsdtar), since (a) it usually occurs due to a perfectly innocent (and un

cvs commit: src/usr.bin/tar write.c

2007-03-13 Thread Colin Percival
cperciva2007-03-14 07:30:51 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Reduce the risk of inducing heart attacks, by printing the right path when complaining about lstat(2) failing. It's a bit scary to find the message tar: /: Cannot stat:

cvs commit: src/usr.bin/tar write.c

2007-02-24 Thread Tim Kientzle
kientzle2007-02-25 07:24:45 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC write.c 1.54. This implements -r support for empty or nonexistent files and corrects the bad handling of files that change size during archi

cvs commit: src/usr.bin/tar write.c

2007-02-17 Thread Tim Kientzle
kientzle2007-02-18 06:23:57 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Andrew and Colin each pointed out to me that truncating the backup of a growing file should not be considered a "bad thing." PR: bin/108990 MFC after: 7 days Pointy

cvs commit: src/usr.bin/tar write.c

2007-02-14 Thread Tim Kientzle
kientzle2007-02-14 08:16:08 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Correctly handle writes beyond the end of the archive entry (as determined by the initial size given to the header). Libarchive recently changed to correctly return the am

cvs commit: src/usr.bin/tar write.c

2007-02-07 Thread Tim Kientzle
kientzle2007-02-08 07:25:53 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Update -r handling: * Create file if it doesn't exist. * If archive is "empty", then append to it with pax restricted * If user specified a format, use that if it'

cvs commit: src/usr.bin/tar write.c

2007-01-23 Thread Colin Percival
cperciva2007-01-23 12:13:29 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC revisions 1.48-1.50: * Print error messages where appropriate, and print the right one. * Properly handle errors in archive_write_close.

cvs commit: src/usr.bin/tar write.c

2007-01-05 Thread Colin Percival
cperciva2007-01-05 16:20:21 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: If append_archive fails while writing an archive header, output the error message from the archive being written (not the message from the archive being read, where no err

cvs commit: src/usr.bin/tar write.c

2007-01-02 Thread Colin Percival
cperciva2007-01-02 15:03:39 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Clean up the struct archive used for reading an archive in the handling of @archive commands. This bug should be harmless as long as you don't use an excessive number of

cvs commit: src/usr.bin/tar write.c

2007-01-02 Thread Colin Percival
cperciva2007-01-02 12:24:14 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Handle errors which occur during archive_write_data and archive_write_close by printing an error message and exiting with a non-zero status code. MFC after: 1 week

cvs commit: src/usr.bin/tar write.c

2006-08-14 Thread Tim Kientzle
kientzle2006-08-15 03:54:42 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.bin/tar write.c Log: MFC 1.47: Remove two unused variables Revision ChangesPath 1.41.2.2 +0 -6 src/usr.bin/tar/write.c _

cvs commit: src/usr.bin/tar write.c

2006-07-30 Thread Tim Kientzle
kientzle2006-07-31 04:57:46 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Remove two unused variables. Thanks to: Stefan Farfeleder Revision ChangesPath 1.47 +0 -6 src/usr.bin/tar/write.c __

cvs commit: src/usr.bin/tar write.c

2005-11-06 Thread Tim Kientzle
kientzle2005-11-06 22:53:51 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: Edit pathnames for -x but not for -t. Otherwise, people get confused when list the archive contents, then try to extract selected files (file selection always works again