cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-07-02 Thread Pav Lucistnik
pav 2007-07-02 08:05:34 UTC FreeBSD src repository (doc,ports committer) Modified files:(Branch: RELENG_6) usr.sbin/pkg_install/lib deps.c Log: MFC 1.12: Replace rather inefficient bubble sort with a recursive depth-first search. This speeds up registration of pa

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-20 Thread Maxim Sobolev
Kris Kennaway wrote: So the answer to my question is ... ? I'm still not sure you understood it. If you are making no functional changes then the md5 of the resulting binary will be unchanged, and this is in fact a good way to check whether you are introducing functional changes or just style/

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Alfred Perlstein
* Maxim Sobolev <[EMAIL PROTECTED]> [070619 16:28] wrote: > Kris Kennaway wrote: > >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: > >>Kris Kennaway wrote: > >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > I have made the following patch to bring style(9) bac

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Kris Kennaway
On Tue, Jun 19, 2007 at 04:26:54PM -0700, Maxim Sobolev wrote: > Kris Kennaway wrote: > >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: > >>Kris Kennaway wrote: > >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > I have made the following patch to bring style(9

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Maxim Sobolev
Kris Kennaway wrote: On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: Kris Kennaway wrote: On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: I have made the following patch to bring style(9) back and make code more readable. Do you guys want to run it on bento or cou

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Kris Kennaway
On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: > Kris Kennaway wrote: > >On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > >>I have made the following patch to bring style(9) back and make code > >>more readable. Do you guys want to run it on bento or could I just ch

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Maxim Sobolev
Kris Kennaway wrote: On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: I have made the following patch to bring style(9) back and make code more readable. Do you guys want to run it on bento or could I just check it in? http://sobomax.homeunix.org/~sobomax/deps.c.diff Is md5 ch

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Kris Kennaway
On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > I have made the following patch to bring style(9) back and make code > more readable. Do you guys want to run it on bento or could I just check > it in? > > http://sobomax.homeunix.org/~sobomax/deps.c.diff Is md5 checksum the same

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Maxim Sobolev
I have made the following patch to bring style(9) back and make code more readable. Do you guys want to run it on bento or could I just check it in? http://sobomax.homeunix.org/~sobomax/deps.c.diff -Maxim Pav Lucistnik wrote: pav 2007-06-18 22:49:13 UTC FreeBSD src repository (doc

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Pav Lucistnik
Nate Lawson píše v út 19. 06. 2007 v 11:50 -0700: > Kris Kennaway wrote: > > On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: > >> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: > >>> Coleman Kane pe v ??t 19. 06. 2007 v 11:51 -0400: > On Mon, 2007-06-18 at 22:49 +000

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Nate Lawson
Kris Kennaway wrote: > On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: >> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: >>> Coleman Kane pe v ??t 19. 06. 2007 v 11:51 -0400: On Mon, 2007-06-18 at 22:49 +, Pav Lucistnik wrote: > pav 2007-06-18 22:49:1

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Kris Kennaway
On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: > On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: > > Coleman Kane pe v ??t 19. 06. 2007 v 11:51 -0400: > > > On Mon, 2007-06-18 at 22:49 +, Pav Lucistnik wrote: > > > > pav 2007-06-18 22:49:13 UTC > > > > > > >

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Coleman Kane
On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: > Coleman Kane píše v út 19. 06. 2007 v 11:51 -0400: > > On Mon, 2007-06-18 at 22:49 +, Pav Lucistnik wrote: > > > pav 2007-06-18 22:49:13 UTC > > > > > > FreeBSD src repository (doc,ports committer) > > > > > > Modified file

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Coleman Kane
On Mon, 2007-06-18 at 22:49 +, Pav Lucistnik wrote: > pav 2007-06-18 22:49:13 UTC > > FreeBSD src repository (doc,ports committer) > > Modified files: > usr.sbin/pkg_install/lib deps.c > Log: > - Replace rather inefficient bubble sort with a recursive depth-first > searc

Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-19 Thread Pav Lucistnik
Coleman Kane píše v út 19. 06. 2007 v 11:51 -0400: > On Mon, 2007-06-18 at 22:49 +, Pav Lucistnik wrote: > > pav 2007-06-18 22:49:13 UTC > > > > FreeBSD src repository (doc,ports committer) > > > > Modified files: > > usr.sbin/pkg_install/lib deps.c > > Log: > > - Replace

cvs commit: src/usr.sbin/pkg_install/lib deps.c

2007-06-18 Thread Pav Lucistnik
pav 2007-06-18 22:49:13 UTC FreeBSD src repository (doc,ports committer) Modified files: usr.sbin/pkg_install/lib deps.c Log: - Replace rather inefficient bubble sort with a recursive depth-first search. This speeds up registration of packages considerably. - style(9) p