cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

2008-08-24 Thread Ed Schouten
ed 2008-08-24 10:01:22 UTC FreeBSD src repository Modified files: .ObsoleteFiles.inc libexec Makefile Removed files: libexec/pt_chown Makefile pt_chown.c Log: SVN rev 182105 on 2008-08-24 10:01:22Z by ed Remove the now

Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

2008-08-24 Thread Ed Schouten
* Ed Schouten [EMAIL PROTECTED] wrote: I've done tests with FreeBSD 5.2.1, FreeBSD 6.3 and FreeBSD 7.0 jails. All of them still work if I remove pt_chown. Just a small sidenote: on FreeBSD 5.2.1 openpty() and posix_openpt() still work like it should, but ptsname() (and thus grantpt()) are

Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

2008-08-24 Thread Robert Watson
On Sun, 24 Aug 2008, Ed Schouten wrote: Remove the now unneeded pt_chown utility. Before we had a posix_openpt() that allocated PTY's with proper permissions in place, we used this set-uid utility to change the ownership of PTY slave devices to the real user ID of the process. This

Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

2008-08-24 Thread Ed Schouten
* Robert Watson [EMAIL PROTECTED] wrote: Do you plan to provide updated compat libs for 4.x, 5.x, 6.x, 7.x, to replace libc/libutil code that expects to be able to execute the pt_chown binary? What happens if that code can't find the pt_chown binary it expects? I thought my commit message

Re: cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

2008-08-24 Thread Robert Watson
On Sun, 24 Aug 2008, Ed Schouten wrote: There is no need for compat libraries, because the existing ones already do this: - Try to run pt_chown. - If that fails, try to chmod/chown the slave device by hand. - If that fails, return an error. Because the PTY that openpty() obtains already has