Author: jkeenan
Date: Mon Nov 19 16:04:08 2007
New Revision: 22901

Modified:
   trunk/t/configure/115-auto_warnings.t

Log:
Applying patch submitted by Andy Dougherty in
http://rt.perl.org/rt3/Ticket/Display.html?id=47606.  Explanatory comments;
better message in $TODO.


Modified: trunk/t/configure/115-auto_warnings.t
==============================================================================
--- trunk/t/configure/115-auto_warnings.t       (original)
+++ trunk/t/configure/115-auto_warnings.t       Mon Nov 19 16:04:08 2007
@@ -24,17 +24,16 @@
 my $step = 'dummy';
 
 my $conf = Parrot::Configure->new;
-$conf->data->set('cc', 'cc');
-$conf->data->set('ccflags', '-I/usr/include');
+$conf->data->set('cc', 'cc'); # XXX Cannot assume there iss a compiler 'cc'
+$conf->data->set('ccflags', '-I/usr/include'); # XXX Cannot assume this.
 
 my $cwd = cwd();
 my $warning;
 
 TODO: {
     # http://rt.perl.org/rt3/Ticket/Display.html?id=47395
-    local $TODO =
-        q<Reported failing where vendor-supplied Perl 5 Config.pm does not 
match true state of system available for Parrot configuration>;
-    $warning = "-Wall";
+    local $TODO = q<Not all compilers support -Wall>;
+    $warning = "-Wall"; # XXX Cannot assume all compilers accept -Wall.
     {
         my $verbose = 0;
         my $rv      = auto::warnings::try_warning($step, $conf, $warning);

Reply via email to