Author: petdance
Date: Sun Feb 10 23:15:18 2008
New Revision: 25647

Modified:
   trunk/src/gc/dod.c

Log:
This little || should have been &&.  Otherwise, we dereference NULL.
Thanks, splint!

Diff in runs from running valgrind on "hello world":

4974c2974
<  ERROR SUMMARY: 973 errors from 99 contexts (suppressed: 14529 from 5)
---
>  ERROR SUMMARY: 879 errors from 59 contexts (suppressed: 14529 from 5)


Modified: trunk/src/gc/dod.c
==============================================================================
--- trunk/src/gc/dod.c  (original)
+++ trunk/src/gc/dod.c  Sun Feb 10 23:15:18 2008
@@ -134,7 +134,7 @@
          *     use a second pointer chain, which is, when not empty,
          *     processed first.
          */
-        if (tptr || hi_prio) {
+        if (tptr && hi_prio) {
             if (PMC_next_for_GC(tptr) == tptr) {
                 PMC_next_for_GC(obj) = obj;
             }

Reply via email to