Re: [PATCH 1/2] Treat Windows Store's "app execution aliases" as symbolic links

2021-03-13 Thread Joe Lowe via Cygwin-patches
. This may not be an issue, if most/all relevent store apps function the same when the executable is exec-ed directly vs via the appexec link. Joe L. On 3/13/2021 4:21 PM, Johannes Schindelin wrote: Hi Joe, On Fri, 12 Mar 2021, Joe Lowe wrote: I am skeptical about this patch (part 1

Re: [PATCH 1/2] Treat Windows Store's "app execution aliases" as symbolic links

2021-03-12 Thread Joe Lowe
I am skeptical about this patch (part 1), interposing appexec reparse point data as symlinks for cygwin applications. The appexec reparse point data is essentially an extended attribute holding data that is used by CreateProcess(), more like a windows .lnk file or an X11 .desktop file, not

Re: [PATCH] Compatibility improvement to reparse point handling, v3

2017-06-21 Thread Joe Lowe
On 2017-06-20 01:17, Corinna Vinschen wrote: > Actually, DT_UNKNOWN indicates nothing. The sole purpose of this > value is to tell the application that the information is not readily > available without having to perform costly operations, which often OK. > I pushed your patch, plus a

Re: [PATCH] Compatibility improvement to reparse point handling, v3

2017-06-19 Thread Joe Lowe
On 2017-06-19 04:45, Corinna Vinschen wrote:> Hi Joe, > > As discussed in the previous iteration of this patch, this change > results in nuking DT_UNKNOWN for reparse points we don't handle. Still, > IMHO, if we have reparse points we know nothing about, they should stay > DT_UNKNOWN. > > Why

[PATCH] Compatibility improvement to reparse point handling, v3

2017-06-14 Thread Joe Lowe
3rd pass at reparse point handling patch. Changes to this version of the patch. 1. Refactored, smaller, less code impact. 2. readdir() and stat() consistency changes now also handle native file (non-directory) symbolic links. readir() returns DT_REG to match lstat() indicating a normal file.

Re: [PATCH] Compatibility improvement to reparse point handling, v2

2017-06-13 Thread Joe Lowe
On 2017-06-13 00:57, Corinna Vinschen wrote:> On Jun 12 13:08, Joe Lowe wrote: >> On 2017-06-12 03:27, Corinna Vinschen wrote: >>> On Jun 9 15:44, Joe Lowe wrote: >>>> -else >>>> +else if (res == -1) >>>>{ >>>

[PATCH] readdir() with mount point dentry, return mount point INO

2017-06-13 Thread Joe Lowe
This patch fixes a minor compatibility issue w/ cygwin mount point handling in readdir(), compared to equivalent behavior of Linux and MacOS. dentry.d_ino should indicate the INO of the mount point itself, not the target volume root folder. Changed return type from

Re: [PATCH] Compatibility improvement to reparse point handling, v2

2017-06-12 Thread Joe Lowe
Corinna, I will work through the code and apply your feedback. A few additional comments below. On 2017-06-12 03:27, Corinna Vinschen wrote: On Jun 9 15:44, Joe Lowe wrote: 2nd pass at reparse point handling patch. [...] static inline int readdir_check_reparse_point (POBJECT_ATTRIBUTES

[PATCH] Compatibility improvement to reparse point handling, v2

2017-06-09 Thread Joe Lowe
2nd pass at reparse point handling patch. Patch is intended to improve cygwin application compatibility with native mount points and native symlinks where target does not begin with "\??\X:" or "\??\UNC" or "\??\Volume{". Such symlinks function with native windows apps, but fail today with