RE: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Gary R. Van Sickle
[snip] > As far as I can tell the O_BINARY changes are good to have. > > Earl > Well, mandatory if standards are to be cloven to and tragedy is to be avoided. -- Gary R. Van Sickle -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/pr

Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Christopher Faylor
On Tue, Sep 14, 2004 at 12:42:31PM -0700, Earl Chew wrote: >Christopher Faylor wrote: >>Let me again point out that a cygwin program shouldn't be doing *ANY OF >>THIS*. >> >>It shouldn't be calling GetFileSize and it shouldn't be calling >>CreateFile. > >I think part of the original motivation migh

Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Earl Chew
Christopher Faylor wrote: Let me again point out that a cygwin program shouldn't be doing *ANY OF THIS*. It shouldn't be calling GetFileSize and it shouldn't be calling CreateFile. I think part of the original motivation might have been that under some circumstances this set of programs needs to be

RE: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Robb, Sam
> On Tue, Sep 14, 2004 at 10:32:47AM -0700, Earl Chew wrote: > >Earl Chew wrote: > >>The call to GetFileSize() doesn't match the Microsoft documentation, > >>and invariably mis-sizes the disk image as zero. Earl, Thanks for the comments. I considered some of the things you suggested, but for t

Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Christopher Faylor
On Tue, Sep 14, 2004 at 10:32:47AM -0700, Earl Chew wrote: >Earl Chew wrote: >>The call to GetFileSize() doesn't match the Microsoft documentation, >>and invariably mis-sizes the disk image as zero. > >A couple of comments regarding your recent changes: > >a. GetFileSize() returns the bits 32-63 of

Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-14 Thread Earl Chew
Earl Chew wrote: The call to GetFileSize() doesn't match the Microsoft documentation, and invariably mis-sizes the disk image as zero. A couple of comments regarding your recent changes: a. GetFileSize() returns the bits 32-63 of the file size in the 2nd parameter. I think code like this is more

Re: BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-13 Thread Christopher Faylor
On Sun, Sep 12, 2004 at 10:40:39PM -0700, Earl Chew wrote: >The call to GetFileSize() doesn't match the Microsoft documentation, >and invariably mis-sizes the disk image as zero. That's odd. Why would a cygwin program be calling GetFileSize? e2fsprogs should be using statfs and stat. cgf -- Un

BUG: Bad call to GetFileSze in ext2fsprogs lib/ext2fs/getsize.c

2004-09-12 Thread Earl Chew
The call to GetFileSize() doesn't match the Microsoft documentation, and invariably mis-sizes the disk image as zero. Earl -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ