Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-10 Thread Corinna Vinschen
On Nov 9 21:14, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Corinna Vinschen on 11/9/2009 7:05 AM: > > This part of the testcase > > > > data2 = (char *) malloc (2 * pagesize); > > if (!data2) > > return 1; > > data2 += (pagesize - ((long int) d

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [please limit replies about the patch itself to autoconf-patches] According to Corinna Vinschen on 11/9/2009 7:05 AM: > This part of the testcase > > data2 = (char *) malloc (2 * pagesize); > if (!data2) > return 1; > data2 += (pagesize - (

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 11/9/2009 7:05 AM: > This part of the testcase > > data2 = (char *) malloc (2 * pagesize); > if (!data2) > return 1; > data2 += (pagesize - ((long int) data2 & (pagesize - 1))) & (pagesize - 1); > if (data2

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Corinna Vinschen
On Nov 9 05:50, Eric Blake wrote: > According to Corinna Vinschen on 11/9/2009 4:59 AM: > > MAP_FIXED > > [...] > > If the specified address cannot be used, mmap() will fail. Because > > requiring a fixed address for a mapping is less portable, the use of > > this option is discouraged. >

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 11/9/2009 4:59 AM: >>> I just found that the latest autoconf *still* has this broken test >>> for mmap, which basically calls >>> >>> data2 = malloc (size); >>> mmap(data2, ...); >>> >>> Why has this test never been

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Corinna Vinschen
On Nov 8 14:07, Charles Wilson wrote: > Corinna Vinschen wrote: > > On Nov 8 14:56, Corinna Vinschen wrote: > >> Btw., the check for mmap in grep's configure file is broken. It tries > >> to mmap to a fixed address formerly allocated via malloc(). This doesn't > >> work on Windows. An autoconf

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Charles Wilson
Corinna Vinschen wrote: > On Nov 8 14:56, Corinna Vinschen wrote: >> Btw., the check for mmap in grep's configure file is broken. It tries >> to mmap to a fixed address formerly allocated via malloc(). This doesn't >> work on Windows. An autoconf run with a newer version of autoconf would >> be

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Christopher Faylor
On Sun, Nov 08, 2009 at 10:51:56AM -0500, Ralph Hempel wrote: >Corinna Vinschen wrote: >> On Nov 8 14:56, Corinna Vinschen wrote: >>> Btw., the check for mmap in grep's configure file is broken. It tries >>> to mmap to a fixed address formerly allocated via malloc(). This doesn't >>> work on Win

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Ralph Hempel
Corinna Vinschen wrote: On Nov 8 14:56, Corinna Vinschen wrote: Btw., the check for mmap in grep's configure file is broken. It tries to mmap to a fixed address formerly allocated via malloc(). This doesn't work on Windows. An autoconf run with a newer version of autoconf would be nice. I

Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Corinna Vinschen
On Nov 8 14:56, Corinna Vinschen wrote: > Btw., the check for mmap in grep's configure file is broken. It tries > to mmap to a fixed address formerly allocated via malloc(). This doesn't > work on Windows. An autoconf run with a newer version of autoconf would > be nice. I just found that the