Re: Problem with new acl code and cdrtools

2016-02-09 Thread Peter Rosin
On 2016-02-09 10:06, Ismail Donmez wrote: > Hi Peter, > > On Tue, Feb 9, 2016 at 10:56 AM, Peter Rosin wrote: >> My take on the situation was that you could disable SUN ACLs by telling >> configure that cdrtools should not use aclfromtext(), and that the code >> that backs this was already in p

Re: Problem with new acl code and cdrtools

2016-02-09 Thread Corinna Vinschen
On Feb 8 13:24, Yaakov Selkowitz wrote: > On 2016-02-08 08:10, Corinna Vinschen wrote: > >Alternatively we could allow to use the Solaris ACL functions even if > >only including sys/acl.h, given some macro: > > > > sys/acl.h: > > > > #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS > > # include

Re: Problem with new acl code and cdrtools

2016-02-09 Thread Ismail Donmez
Hi Peter, On Tue, Feb 9, 2016 at 10:56 AM, Peter Rosin wrote: > My take on the situation was that you could disable SUN ACLs by telling > configure that cdrtools should not use aclfromtext(), and that the code > that backs this was already in place. I.e. that you could get a working > build recip

Re: Problem with new acl code and cdrtools

2016-02-09 Thread Peter Rosin
On 2016-02-09 08:56, Ismail Donmez wrote: > Hi, > > On Tue, Feb 9, 2016 at 6:14 AM, Warren Young wrote: >> On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: >>> >>> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin wrote: On 2016-02-08 14:31, Ismail Donmez wrote: > This is a generic code so I

Re: Problem with new acl code and cdrtools

2016-02-09 Thread Ismail Donmez
On Tue, Feb 9, 2016 at 10:46 AM, Warren Young wrote: > On Feb 9, 2016, at 12:56 AM, Ismail Donmez wrote: >> >> On Tue, Feb 9, 2016 at 6:14 AM, Warren Young wrote: >>> On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: Thats a hack :) >>> >>> Peter’s proposal is as far from a hack as it

Re: Problem with new acl code and cdrtools

2016-02-09 Thread Warren Young
On Feb 9, 2016, at 12:56 AM, Ismail Donmez wrote: > > On Tue, Feb 9, 2016 at 6:14 AM, Warren Young wrote: >> On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: >>> >>> Thats a hack :) >> >> Peter’s proposal is as far from a hack as it gets. > > What Peter suggests is telling autoconf to assume

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
Hi, On Tue, Feb 9, 2016 at 6:14 AM, Warren Young wrote: > On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: >> >> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin wrote: >>> On 2016-02-08 14:31, Ismail Donmez wrote: This is a generic code so I don't want to add a cygwin specific dependency

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Warren Young
On Feb 8, 2016, at 9:59 AM, Ismail Donmez wrote: > > On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin wrote: >> On 2016-02-08 14:31, Ismail Donmez wrote: >>> This is a generic code so I don't want to add a cygwin specific >>> dependency there. Is there a preprocessor definition for cygwin >>> version

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Yaakov Selkowitz
On 2016-02-08 08:10, Corinna Vinschen wrote: Alternatively we could allow to use the Solaris ACL functions even if only including sys/acl.h, given some macro: sys/acl.h: #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS # include #else [...POSIX definitions...] #endif Do t

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin wrote: > On 2016-02-08 14:31, Ismail Donmez wrote: >> This is a generic code so I don't want to add a cygwin specific >> dependency there. Is there a preprocessor definition for cygwin >> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Peter Rosin
On 2016-02-08 14:31, Ismail Donmez wrote: > This is a generic code so I don't want to add a cygwin specific > dependency there. Is there a preprocessor definition for cygwin > version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+ Pardon me for butting in, but isn't adding a Cygwin vers

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
On Mon, Feb 8, 2016 at 4:36 PM, Corinna Vinschen wrote: > On Feb 8 16:13, Ismail Donmez wrote: >> On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen >> wrote: >> > On Feb 8 15:31, Ismail Donmez wrote: >> >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen >> >> wrote: >> >> > On Feb 8 12:01, Is

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Corinna Vinschen
On Feb 8 16:13, Ismail Donmez wrote: > On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen > wrote: > > On Feb 8 15:31, Ismail Donmez wrote: > >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen > >> wrote: > >> > On Feb 8 12:01, Ismail Donmez wrote: > >> >> Hi, > >> >> > >> >> cdrtools has some

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen wrote: > On Feb 8 15:31, Ismail Donmez wrote: >> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen >> wrote: >> > On Feb 8 12:01, Ismail Donmez wrote: >> >> Hi, >> >> >> >> cdrtools has some code to detect Solaris style ACLs: >> >> >> >> #if defin

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Corinna Vinschen
On Feb 8 15:31, Ismail Donmez wrote: > On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen > wrote: > > On Feb 8 12:01, Ismail Donmez wrote: > >> Hi, > >> > >> cdrtools has some code to detect Solaris style ACLs: > >> > >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ > >> defined(HAVE_ACLF

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen wrote: > On Feb 8 12:01, Ismail Donmez wrote: >> Hi, >> >> cdrtools has some code to detect Solaris style ACLs: >> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) >> # define HAVE_

Re: Problem with new acl code and cdrtools

2016-02-08 Thread Corinna Vinschen
On Feb 8 12:01, Ismail Donmez wrote: > Hi, > > cdrtools has some code to detect Solaris style ACLs: > > #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ > defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) > # define HAVE_SUN_ACL1 /* Sun UFS ACL's present */ > #endif > > Since cyg

Problem with new acl code and cdrtools

2016-02-08 Thread Ismail Donmez
Hi, cdrtools has some code to detect Solaris style ACLs: #if defined(HAVE_ACL) && defined(HAVE_FACL) && \ defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT) # define HAVE_SUN_ACL1 /* Sun UFS ACL's present */ #endif Since cygwin still seems to be defining aclfromtext() and acltotext