Re: cygcheck exit status

2005-07-06 Thread Eric Blake
Igor Pechtchanski pechtcha at cs.nyu.edu writes: Because it's in a for loop, and when the first file fails but second succeeds, you still want the overall command to exit with failure. That's the correct intent, but shouldn't it be = instead of =, technically? There's no such thing as =.

RE: cygcheck exit status

2005-07-06 Thread Dave Korn
Original Message From: Eric Blake Sent: 06 July 2005 15:19 But I hate thinking in negative logic, hence my definition of cygcheck to return true on success.] Mneh. I don't like boolean success-fail return values full stop. They convey too little information and then need to be

Re: cygcheck exit status

2005-07-06 Thread Igor Pechtchanski
On Wed, 6 Jul 2005, Eric Blake wrote: Igor Pechtchanski pechtcha at cs.nyu.edu writes: Because it's in a for loop, and when the first file fails but second succeeds, you still want the overall command to exit with failure. That's the correct intent, but shouldn't it be = instead of =,

RE: cygcheck exit status

2005-07-06 Thread Dave Korn
Original Message From: Igor Pechtchanski Sent: 06 July 2005 16:36 On Wed, 6 Jul 2005, Eric Blake wrote: Igor Pechtchanski pechtcha at cs.nyu.edu writes: Because it's in a for loop, and when the first file fails but second succeeds, you still want the overall command to exit with

cygcheck exit status

2005-07-05 Thread Eric Blake
As mentioned on cygwin (hopefully I'm not falling afoul of trivial patch size, since I don't have assignment; and hopefully gmane didn't kill this): 2005-07-05 Eric Blake [EMAIL PROTECTED] * cygcheck.cc (track_down, cygcheck): Return true on success. (main): Reflect cygcheck

Re: cygcheck exit status

2005-07-05 Thread Christopher Faylor
On Tue, Jul 05, 2005 at 08:49:06PM +, Eric Blake wrote: @@ -1677,7 +1681,7 @@ main (int argc, char **argv) { if (i) puts (); - cygcheck (argv[i]); + ok = cygcheck (argv[i]); Why are you anding the result here? Why not just set ok = cygcheck (...)? cgf

Re: cygcheck exit status

2005-07-05 Thread Eric Blake
Christopher Faylor cgf-no-personal-reply-please at cygwin.com writes: On Tue, Jul 05, 2005 at 08:49:06PM +, Eric Blake wrote: at at -1677,7 +1681,7 at at main (int argc, char **argv) { if (i) puts (); - cygcheck (argv[i]); + ok = cygcheck

cygcheck exit status

2005-07-05 Thread Eric Blake
It is annoying that cygcheck exits with status 0, even if it could not find a file: $ cygcheck /bin/lilypond.exe C:/cygwin/bin/lilypond.exe C:/cygwin/bin\cygwin1.dll C:\WINNT\system32\ADVAPI32.DLL C:\WINNT\system32\NTDLL.DLL C:\WINNT\system32\KERNEL32.DLL

Re: cygcheck exit status

2005-07-05 Thread Christopher Faylor
On Tue, Jul 05, 2005 at 07:25:04PM +, Eric Blake wrote: It is annoying that cygcheck exits with status 0, even if it could not find a file: $ cygcheck /bin/lilypond.exe C:/cygwin/bin/lilypond.exe C:/cygwin/bin\cygwin1.dll C:\WINNT\system32\ADVAPI32.DLL C:\WINNT\system32\NTDLL.DLL