setup.exe contributor guidelines

I think I need to make some of the guidelines I'm using for code review clear, to aid contributors in making acceptable patches. These are not set in stone: They are subject to change, via both feedback from you, and as I think of other things that are relevant. I'll setup a file in CVS with this a

max- hows it going?

Max, how are you going with that patch? Would you like to brainstorm in real-time? If so, I'm on irc.freenode.net, nickname 'lifeless'. I'll be there for at least another hour, possibly two. Cheers, Rob -- GPG key available at: . signature.a

RE: [PATCH] Bigger Chooser 2

> On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote: > > > > > > > it's too big for a single commit. I'd like you to start sending in the > > > bits that you can, in a > > > single-patch-does-a-single-conceptual-change style. > > > > > > Those I can review and approve for Max or I to checkin. >

RE: [PATCH] Bigger Chooser 2

On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote: > > Yes. I've never liked 100K patches, even when I do them. > > > > The source patch plus the new source file is only 50k total, at least 31k of > which is solely bigger-chooser (primarily res.rc, proppage.{cc,h}, > propsheet.{cc,h}, Window.

Re: [PATCH] Bigger Chooser 2

This is the first-take review: rectcc.h contains a class RECTPP. I *think* I posted my preference here for file names - that is after the class. So: RECTPP.h would be the correct name. Having said that RECTPP is not any of the ok naming conventions for classes. A quick recap: The GNU standards

Cygwin needs a splint'er

All, I've had this lying around for ages, and I don't know why I didn't think of it before. Splint, as some of you may already know, builds OOTB on Cygwin and just requires a few tweaks to get rid of some warnings. I'm going to package this up for Cygwin, so does anyone have any thoughts or sugges

Re: bash bug report? Minor border case:

Linda, According to , this is off-topic for the list. Please remove from further replies. Igor On Sat, 29 Mar 2003, linda w (cyg) wrote: > Valid filename created by app: > \Documents and Settings\law\My > Documents\win\registry2\regtweaks\

bash bug report? Minor border case:

Valid filename created by app: \Documents and Settings\law\My Documents\win\registry2\regtweaks\Kellys_XP_Tweaks\download.com.com\clear\redx\c.gif-ts=-104976066&edId=3&prtnr=CNET+Networks,+Inc.& oid=3000-2094-10126096&ptId=3000&onId=2094&sId=4&asId=10126096&pId=10126096&asType=Product exactly 255

Proposed package DjVuLibre

I propose adding a package, DjVuLibre, do CYGWIN. I have been building DjVuLibre since creation under Cygwin, and finally decided to offer to maintain an official Cygwin package for distribution. The proposed setup.hints file is: category: Graphics requires: cygwin jpeg sdesc: "Compress and deco

Proposed package DjVuLibre

I propose adding a package, DjVuLibre, do CYGWIN. I have been building DjVuLibre since creation under Cygwin, and finally decided to offer to maintain an official Cygwin package for distribution. The proposed setup.hints file is: category: Graphics requires: cygwin jpeg sdesc: "Compress and deco

RE: [PATCH] Bigger Chooser 2

On Sun, 2003-03-30 at 16:20, Gary R. Van Sickle wrote: > > On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote: > > > > > > Yes. I've never liked 100K patches, even when I do them. > > > > > > > > > > The source patch plus the new source file is only 50k total, at least 31k of > > > which is sole

RE: [PATCH] Bigger Chooser 2

> On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote: > > > > Yes. I've never liked 100K patches, even when I do them. > > > > > > > The source patch plus the new source file is only 50k total, at least 31k of > > which is solely bigger-chooser (primarily res.rc, proppage.{cc,h}, > > propsheet.{