Re: [patch/rebase]: Makefile support for cross-builds and static linking with gcc-4

2011-06-21 Thread Corinna Vinschen
On Jun 20 16:04, Yaakov (Cygwin/X) wrote: On Mon, 2011-06-20 at 17:29 +0200, Corinna Vinschen wrote: This patch changes Makefile to use $(EXEEXT) throughout to better support cross building. You'll still need to override CC/CXX for cross-compiling. It also adds explicit static linking

Re: [patch/rebase]: Makefile support for cross-builds and static linking with gcc-4

2011-06-21 Thread Yaakov (Cygwin/X)
On Tue, 2011-06-21 at 09:40 +0200, Corinna Vinschen wrote: Sure? I tried that first, but it didn't work. The end result still linked against the cygstdc++ and cyggcc_s DLLs. Specifying all three flags was the only way I could convince g++ to link these libs statically. Hmm, it WFM with

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Corinna Vinschen
On Jun 20 20:06, Charles Wilson wrote: On 6/20/2011 2:52 PM, Corinna Vinschen wrote: PATH_MAX = 4K should be enough. I'm not even sure it's really necessary. DLL paths referenced in the PEB can't be longer than MAX_PATH, it seems. But a global static buffer is ok, too. Ack. I've

Re: [patch/rebase]: Makefile support for cross-builds and static linking with gcc-4

2011-06-21 Thread Corinna Vinschen
On Jun 21 03:01, Yaakov (Cygwin/X) wrote: On Tue, 2011-06-21 at 09:40 +0200, Corinna Vinschen wrote: Sure? I tried that first, but it didn't work. The end result still linked against the cygstdc++ and cyggcc_s DLLs. Specifying all three flags was the only way I could convince g++ to link

Re: RFU: mksh-40-2

2011-06-21 Thread Corinna Vinschen
On Jun 20 20:22, Chris Sutcliffe wrote: Please upload mksh-40-2: --- wget -x -nH --cut-dirs=1 \ http://emergedesktop.org/cygwin/mksh/mksh-40-2.tar.bz2 \ http://emergedesktop.org/cygwin/mksh/mksh-40-2-src.tar.bz2 Done. Can I remove the 39c versions? Corinna -- Corinna Vinschen

Re: RFU: mksh-40-2

2011-06-21 Thread Chris Sutcliffe
On 21 June 2011 04:07, Corinna Vinschen wrote: On Jun 20 20:22, Chris Sutcliffe wrote: Please upload mksh-40-2: --- wget -x -nH --cut-dirs=1 \ http://emergedesktop.org/cygwin/mksh/mksh-40-2.tar.bz2  \ http://emergedesktop.org/cygwin/mksh/mksh-40-2-src.tar.bz2 Done.  Can I remove the 39c

Re: RFU: mksh-40-2

2011-06-21 Thread Corinna Vinschen
On Jun 21 05:13, Chris Sutcliffe wrote: On 21 June 2011 04:07, Corinna Vinschen wrote: On Jun 20 20:22, Chris Sutcliffe wrote: Please upload mksh-40-2: --- wget -x -nH --cut-dirs=1 \ http://emergedesktop.org/cygwin/mksh/mksh-40-2.tar.bz2  \

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Chris January
- fprintf (f, Copyright (c) 2009 Charles Wilson, Dave Korn, Jason Tishler\n); + fprintf (f, Copyright (c) 2009, 2011 Charles Wilson, Dave Korn, Jason Tishler\n); May I suggest if you are updating the copyright notice you also add et al. to the list of names (since you are now a contributor

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Corinna Vinschen
On Jun 21 12:09, Chris January wrote: - fprintf (f, Copyright (c) 2009 Charles Wilson, Dave Korn, Jason Tishler\n); + fprintf (f, Copyright (c) 2009, 2011 Charles Wilson, Dave Korn, Jason Tishler\n); May I suggest if you are updating the copyright notice you also add et al. to the list

[patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
Here's another patch to rebase: - Call setlocale at the start of main to accommodate native character conversion. - Adds a -i option to allow to print base address and size of all files given as arguments or via the -T option. The list is sorted by base address. - On Cygwin, check if a

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Jason Tishler
Corinna, On Tue, Jun 21, 2011 at 01:18:35PM +0200, Corinna Vinschen wrote: Jason, this patch still applies cleanly. Is it ok to apply? Yes, it's OK by me. However, Chuck is the author of peflags. Chuck, OK to apply? Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Jason Tishler
Corinna, On Tue, Jun 21, 2011 at 02:25:40PM +0200, Corinna Vinschen wrote: Ok to apply? Yes. Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC ECF4 8EF6

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Charles Wilson
On 6/21/2011 4:03 AM, Corinna Vinschen wrote: I've tested the build on cygwin (native) but not msys (native) or mingw (native). However, it worked in the past, so... Well, whoever is interested in having this working under msys or mingw can send patches, right? Yes. And that would be...me.

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Charles Wilson
On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): +verbose ? old_coff_characteristics : 0, And et.al. here, I suppose. + fprintf (f, Copyright (c) 2009, 2011 Charles Wilson, Dave Korn, Jason Tishler\n); Otherwise, looks fine to

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Charles Wilson
On 6/21/2011 8:25 AM, Corinna Vinschen wrote: - On Cygwin, check if a DLL has been rebased into the address space taken by the Cygwin DLL. If so, rebase again. Ok to apply? No need for Corinna to do the following; I'll handle it. This email is just a reminder-to-self. Need to modify the

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Jason Tishler
Chuck, On Mon, Jun 20, 2011 at 08:06:59PM -0400, Charles Wilson wrote: I've committed all of my changes, ... When I run autoreconf, build-aux is created, but it's empty: $ autoreconf -fvi autoreconf-2.65: Entering directory `.' autoreconf-2.65: configure.ac: not using Gettext autoreconf-2.65:

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
On Jun 21 09:12, Charles Wilson wrote: On 6/21/2011 8:25 AM, Corinna Vinschen wrote: - On Cygwin, check if a DLL has been rebased into the address space taken by the Cygwin DLL. If so, rebase again. Ok to apply? No need for Corinna to do the following; I'll handle it. This email is

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
On Jun 21 08:43, Jason Tishler wrote: Corinna, On Tue, Jun 21, 2011 at 02:25:40PM +0200, Corinna Vinschen wrote: Ok to apply? Yes. Thanks! Patch applied. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader cygwin AT

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Corinna Vinschen
On Jun 21 09:07, Charles Wilson wrote: On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): + verbose ? old_coff_characteristics : 0, What's the issue? To use tabs is an issue? Usually only using spaces is the issue... And

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Corinna Vinschen
On Jun 21 09:27, Jason Tishler wrote: Chuck, On Mon, Jun 20, 2011 at 08:06:59PM -0400, Charles Wilson wrote: I've committed all of my changes, ... When I run autoreconf, build-aux is created, but it's empty: $ autoreconf -fvi autoreconf-2.65: Entering directory `.' autoreconf-2.65:

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Corinna Vinschen
On Jun 21 15:30, Corinna Vinschen wrote: On Jun 21 09:07, Charles Wilson wrote: On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): +verbose ? old_coff_characteristics : 0, What's the issue? To use tabs is an issue?

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Charles Wilson
On 6/21/2011 9:27 AM, Corinna Vinschen wrote: Boy, what a mess. In that case, have a look into my patch to imagehelper/objectfile.cc, function Win32Path. The #ifdef stuff won't work for MSYS. Not that I care... Of course. :-) -- Chuck

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Charles Wilson
On 6/21/2011 9:30 AM, Corinna Vinschen wrote: On Jun 21 09:07, Charles Wilson wrote: On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): + verbose ? old_coff_characteristics : 0, What's the issue? To use tabs is an issue? Usually

Re: [patch/rebase] Improve peflags

2011-06-21 Thread Corinna Vinschen
On Jun 21 09:50, Charles Wilson wrote: On 6/21/2011 9:30 AM, Corinna Vinschen wrote: On Jun 21 09:07, Charles Wilson wrote: On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): + verbose ? old_coff_characteristics : 0, What's

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
On Jun 21 09:48, Charles Wilson wrote: On 6/21/2011 9:27 AM, Corinna Vinschen wrote: Boy, what a mess. In that case, have a look into my patch to imagehelper/objectfile.cc, function Win32Path. The #ifdef stuff won't work for MSYS. Not that I care... Of course. :-) Wouldn't this one

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Jason Tishler
Corinna, On Tue, Jun 21, 2011 at 03:33:12PM +0200, Corinna Vinschen wrote: Any ideas on how to resolve this issue? It's part of the repository. It should be sufficent to do this: $ rm -rf build-aux $ cvs up -d I forgot about the -d option. I guess my conversion to svn is complete.

Re: [patch/rebase]: Makefile support for cross-builds and static linking with gcc-4

2011-06-21 Thread Charles Wilson
On 6/21/2011 4:06 AM, Corinna Vinschen wrote: Btw., did anybody experiment with setting the ASLR flag for DLLs? Chuck's description sounds as if this really might help to reduce collision problems at fork time. If so, the ASLR flag should become default for DLLs. (1) I thought the end

Re: [patch/rebase] Fix build problems in imagehelper

2011-06-21 Thread Charles Wilson
On 6/21/2011 9:33 AM, Corinna Vinschen wrote: (*) autoreconf is unnecessary. No Makefile.am files, no auto headers. And that's why Jason's empty build-aux was not populated. Since automake (and libtool, and gettext) are not used, autoreconf doesn't run them. But, automake is the tool that

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
On Jun 21 10:34, Charles Wilson wrote: On 6/21/2011 10:06 AM, Corinna Vinschen wrote: On Jun 21 09:48, Charles Wilson wrote: On 6/21/2011 9:27 AM, Corinna Vinschen wrote: Boy, what a mess. In that case, have a look into my patch to imagehelper/objectfile.cc, function Win32Path. The

[patch/rebase]: Code cleanup (was Re: [patch/rebase] Improve peflags)

2011-06-21 Thread Corinna Vinschen
On Jun 21 15:37, Corinna Vinschen wrote: On Jun 21 15:30, Corinna Vinschen wrote: On Jun 21 09:07, Charles Wilson wrote: On 6/21/2011 8:39 AM, Jason Tishler wrote: OK to apply? Tab/space issues these lines (twice): + verbose ? old_coff_characteristics : 0,

[patch/rebase] Ignore 64 bit files from x86_64-w64-mingw32 toolchain

2011-06-21 Thread Corinna Vinschen
Here's a simple one. Avoid error messages due to trying to rebase 64 bit images (as long as we can't handle them). This has been reported multiple times on the cygwin list. Index: rebaseall.in === RCS file:

Re: [patch/rebase] Ignore 64 bit files from x86_64-w64-mingw32 toolchain

2011-06-21 Thread JonY
On 6/21/2011 23:05, Corinna Vinschen wrote: Here's a simple one. Avoid error messages due to trying to rebase 64 bit images (as long as we can't handle them). This has been reported multiple times on the cygwin list. Should the regular 32bit mingw (both offerings) be ignored as well?

Re: [patch/rebase]: Code cleanup (was Re: [patch/rebase] Improve peflags)

2011-06-21 Thread Charles Wilson
On 6/21/2011 10:59 AM, Corinna Vinschen wrote: Talking about issues. Shouldn't we add '-Wall -Werror' to the CFLAGS by default? Not a bad idea. I created a patch which enforces these flags, as well as the -static flags to build rebase and peflags. Then I fixed all warnings which occured

Re: [patch/rebase] Ignore 64 bit files from x86_64-w64-mingw32 toolchain

2011-06-21 Thread Corinna Vinschen
On Jun 21 22:49, JonY wrote: On 6/21/2011 23:05, Corinna Vinschen wrote: Here's a simple one. Avoid error messages due to trying to rebase 64 bit images (as long as we can't handle them). This has been reported multiple times on the cygwin list. Should the regular 32bit mingw

Re: [patch/rebase] Ignore 64 bit files from x86_64-w64-mingw32 toolchain

2011-06-21 Thread Jason Tishler
On Tue, Jun 21, 2011 at 05:26:06PM +0200, Corinna Vinschen wrote: On Jun 21 22:49, JonY wrote: On 6/21/2011 23:05, Corinna Vinschen wrote: Here's a simple one. Avoid error messages due to trying to rebase 64 bit images (as long as we can't handle them). This has been reported

Re: [patch/rebase]: Code cleanup (was Re: [patch/rebase] Improve peflags)

2011-06-21 Thread Corinna Vinschen
On Jun 21 11:24, Charles Wilson wrote: On 6/21/2011 10:59 AM, Corinna Vinschen wrote: Talking about issues. Shouldn't we add '-Wall -Werror' to the CFLAGS by default? Not a bad idea. I created a patch which enforces these flags, as well as the -static flags to build rebase and

Re: [patch/rebase] Ignore 64 bit files from x86_64-w64-mingw32 toolchain

2011-06-21 Thread Corinna Vinschen
On Jun 21 11:32, Jason Tishler wrote: On Tue, Jun 21, 2011 at 05:26:06PM +0200, Corinna Vinschen wrote: On Jun 21 22:49, JonY wrote: On 6/21/2011 23:05, Corinna Vinschen wrote: Here's a simple one. Avoid error messages due to trying to rebase 64 bit images (as long as we

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Charles Wilson
On 6/21/2011 10:50 AM, Corinna Vinschen wrote: On Jun 21 10:34, Charles Wilson wrote: On 6/21/2011 10:06 AM, Corinna Vinschen wrote: Wouldn't this one cover all cases? Yes, it appears so. Your proposal assumes that !CYGWIN == native windows, but -- that's already true throughout. Would

Re: [patch/rebase] rebase -i and more

2011-06-21 Thread Corinna Vinschen
On Jun 21 11:45, Charles Wilson wrote: On 6/21/2011 10:50 AM, Corinna Vinschen wrote: On Jun 21 10:34, Charles Wilson wrote: On 6/21/2011 10:06 AM, Corinna Vinschen wrote: Wouldn't this one cover all cases? Yes, it appears so. Your proposal assumes that !CYGWIN == native windows, but