Re: [patch/rebase] Add a rebase database to keep track of DLL addresses

2011-07-05 Thread Eric Blake
On 07/05/2011 01:38 PM, Charles Wilson wrote: > img_info_cmp: what if a or b is NULL? do we care? Ditto for a->name, > b->name -- POSIX doesn't mandate the behavior of strcmp if args are null... > > Also, what encoding do we end up with (on cygwin)? does that affect the > use of strcmp() to compa

Re: [patch/rebase] Add a rebase database to keep track of DLL addresses

2011-07-05 Thread Charles Wilson
On 7/2/2011 4:41 PM, Corinna Vinschen wrote: > On Jul 2 09:15, Corinna Vinschen wrote: >> On Jul 2 01:14, Charles Wilson wrote: >>> I'll take a look next week. Comments inline. > New patch attached with the following changes: > > - I introduced a last minute bug into load_image_info. Fixed. >