Re: [RFC] Removing .la files from x86

2016-08-02 Thread Warren Young
On Aug 2, 2016, at 9:09 PM, Yaakov Selkowitz wrote: > > Any objections? This script would need to consult the same package database cygcheck uses to find out if an installed Cygwin package owns each *.la file it proposes to remove. It should not remove any other *.la file just because it happ

[RFC] Removing .la files from x86

2016-08-02 Thread Yaakov Selkowitz
Libtool .la files are generally a waste of time and space. They slow down linking of other libraries with libtool, and they cause otherwise unnecessary private dependencies to be pulled in by -devel packages. Therefore, the major distros generally remove them from their packages unless they ar

[SECURITY] gd

2016-08-02 Thread Yaakov Selkowitz
Dr. Volker, Several more CVEs have been made public for gd, which also has a new home. Could you please update to 2.2.3 with the following: HOMEPAGE="https://libgd.github.io/"; SRC_URI="https://github.com/libgd/libgd/releases/download/gd-${VERSION}/libgd-${VERSION}.tar.xz"; SRC_DIR="libgd-${V

[PATCH setup 10/10] Reserve paths starting "." for package metadata

2016-08-02 Thread Jon Turney
Reserve pathnames starting "." (i.e. dotfiles in the root directory) for package metadata, so don't extract them. There are no current uses of these pathnames --- install.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/install.cc b/install.cc index f54acdc..8aad3a5 100644 --- a/in

[PATCH setup 07/10] Remove unused fn member from cygpackage

2016-08-02 Thread Jon Turney
This is set, but never used. --- cygpackage.cc | 3 --- cygpackage.h | 8 +++- package_db.cc | 2 +- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/cygpackage.cc b/cygpackage.cc index 4b05cb3..71816f9 100644 --- a/cygpackage.cc +++ b/cygpackage.cc @@ -39,7 +39,6 @@ name (), v

[PATCH setup 08/10] Track if a package was installed by user, or as a dependency

2016-08-02 Thread Jon Turney
Update the installed.db file format to version 3: - Write installed version as a version, rather than as a notional filename. - Also write user_picked flag This extends the semantics of user_pick somewhat: currently it is only used for UI purposes, to record if a package was picked in the current

[PATCH setup 09/10] Add an additional filter view, showing packages which were user picked

2016-08-02 Thread Jon Turney
Add an additional filter view, showing installed packages which were selected for installation by the user, not installed as dependencies. Future work: Why is PickView::views is not an enum? The view button would make more sense as a pop-up menu, allowing a specific filter view to be directly se

[PATCH setup 04/10] Downgrade "Running preremove script" logging to debug

2016-08-02 Thread Jon Turney
This is emitted for every package, regardless of it has any scripts or not. Actual script execution is logged separately. Also a cosmetic fix to remove a doubled space. --- install.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.cc b/install.cc index 2b714bc..f54acd

[PATCH setup 05/10] Properly report progress in PrereqChecker::isMet

2016-08-02 Thread Jon Turney
Properly report progress in PrereqChecker::isMet after additional dependency work is found. --- prereq.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/prereq.cc b/prereq.cc index bdc609e..a5083ed 100644 --- a/prereq.cc +++ b/prereq.cc @@ -238,6 +238,7 @@ PrereqChecker::isMet ()

[PATCH setup 06/10] Remove obsolete installed_from member from packagemeta

2016-08-02 Thread Jon Turney
This just stores a made-up tarfile name read from installed.db, and is never used. --- package_db.cc | 2 +- package_meta.cc | 2 +- package_meta.h | 11 ++- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/package_db.cc b/package_db.cc index 73dfbf6..87da922 100644 ---

[PATCH setup 00/10] Various setup patches

2016-08-02 Thread Jon Turney
Jon Turney (10): Remove stray execute permissions Prevent libtool warning that a getopt++ shared library cannot be built Add lex and yacc generated files to .gitignore Downgrade "Running preremove script" logging to debug Properly report progress in PrereqChecker::isMet Remove obsolete

[PATCH setup 03/10] Add lex and yacc generated files to .gitignore

2016-08-02 Thread Jon Turney
--- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 2186aac..8b81166 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,6 @@ make.out CVS tags autoconf.h.in* +inilex.cc +iniparse.cc +iniparse.hh -- 2.8.3

[PATCH setup 01/10] Remove stray execute permissions

2016-08-02 Thread Jon Turney
--- KeysSetting.cc | 0 KeysSetting.h | 0 crypto.cc | 0 crypto.h | 0 cyg-pubkey.h | 0 cygwin.pub | Bin gpg-packet.cc | 0 gpg-packet.h | 0 tree-minus.bmp | Bin tree-plus.bmp | Bin 10 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 1

[PATCH setup 02/10] Prevent libtool warning that a getopt++ shared library cannot be built

2016-08-02 Thread Jon Turney
libtool: warning: undefined symbols not allowed in i686-w64-mingw32 shared libraries; building static only --- libgetopt++/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libgetopt++/Makefile.am b/libgetopt++/Makefile.am index f820d71..34dc6fd 100644 --- a/libget

Re: [PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

2016-08-02 Thread Jon Turney
On 02/08/2016 04:17, Ronald Ramos wrote: @@ -397,10 +396,10 @@ ChooserPage::OnMessageCmd (int id, HWND hwndctl, UINT code) { case IDC_CHOOSE_CLEAR_SEARCH: { -std::string value; -eset (GetHWND (), IDC_CHOOSE_SEARCH_EDIT, value); -chooser->SetPackageFilter (value); -

Re: [PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

2016-08-02 Thread Jon Turney
On 02/08/2016 11:01, Thomas Wolff wrote: Am 02.08.2016 um 11:22 schrieb Corinna Vinschen: On Aug 1 23:17, Ronald Ramos wrote: Neat! Applied. Personally I would rather see a shorter timeout like, say, 300ms, but I guess we shouldn't take for granted that everybody is typing fast. Even with 50

Re: [PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

2016-08-02 Thread Thomas Wolff
Am 02.08.2016 um 11:22 schrieb Corinna Vinschen: On Aug 1 23:17, Ronald Ramos wrote: commit 357c1e7576586349efb8514dc9d8d03950e225ee Author: Ronald Ramos Date: Mon Aug 1 23:05:44 2016 -0400 * proppage.h (PropertyPage) New member OnTimerMessage (delegates similarly to OnMouseWh

Re: [PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

2016-08-02 Thread Corinna Vinschen
On Aug 1 23:17, Ronald Ramos wrote: > commit 357c1e7576586349efb8514dc9d8d03950e225ee > Author: Ronald Ramos > Date: Mon Aug 1 23:05:44 2016 -0400 > > * proppage.h (PropertyPage) > New member OnTimerMessage (delegates similarly to OnMouseWheel) > > * proppage.cc > (Dia

Re: [PATCH setup] README: Fixed mailing list address (typo)

2016-08-02 Thread Corinna Vinschen
On Aug 1 20:24, Ronald Ramos wrote: > commit 5d7c3beee3317926eb3256dd7a1bed8f55a6952b > Author: Ronald Ramos > Date: Mon Aug 1 20:21:47 2016 -0400 > > * README: Fixed which mailing list this app belongs to > > diff --git a/README b/README > index 9ad78b6..a05b18f 100644 > --- a/README > +