Re: Making a package obsolete

2017-05-16 Thread Ken Brown
On 5/15/2017 12:20 PM, Ken Brown wrote: The relevant code is in pkg_pkg.cygpart around lines 149--163, especially this part: elif (( pkg_count == 1 )) then pkg_contents="*" else pkg_contents= We get here if PKG_CONTENTS is unset or empty.

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-16 Thread Jon Turney
On 04/05/2017 11:11, Jon Turney wrote: On 03/05/2017 18:08, Åke Rehnman wrote: On 2017-05-03 18:37, Jon Turney wrote: * Allow wininet to handle file:// URLs I'm a little bit concerned that there may be current uses which rely on the incorrect parsing we do of file:// URLs to work. Otoh,

[PATCH setup 15/15] Add some progress reporting during preremove and uninstall

2017-05-16 Thread Jon Turney
--- install.cc | 5 + 1 file changed, 5 insertions(+) diff --git a/install.cc b/install.cc index 6e59a80..3721047 100644 --- a/install.cc +++ b/install.cc @@ -812,15 +812,20 @@ do_install_thread (HINSTANCE h, HWND owner) } /* start with uninstalls - remove files that new packages may

[PATCH setup 14/15] Make PackageDepends a type

2017-05-16 Thread Jon Turney
Make PackageDepends a type, rather than repeating it's definition everywhere. --- IniDBBuilderPackage.h | 2 +- Makefile.am | 1 + desktop.cc| 1 - package_db.cc | 2 +- package_depends.h | 21 + package_version.cc| 8

[PATCH setup 13/15] All, rather than just the first (usually current) version should get dependencies

2017-05-16 Thread Jon Turney
It seems that dependencies are only recorded against the first version encountered, which is fortunately usually the current version. If one were to install a different version than that the first time a package is installed, it's dependencies wouldn't be installed. More zany hijinks from the

[PATCH setup 12/15] Stop pretending to support complex dependencies

2017-05-16 Thread Jon Turney
We pretend that we can parse dependencies of the form "A | B". But PrereqChecker will just treat that as "A". This is a hard problem to solve, as we'd need UI to ask, or policy to know if A or B is preferred. So just remove the pretense, simplifying lots of stuff. --- IniDBBuilderPackage.cc |

[PATCH setup 11/15] Remove useless PackageSpecification methods

2017-05-16 Thread Jon Turney
Remove unused PackageSpecification::serialise() Remove dangerous PackageSpecification::operator= which doesn't copy all object state --- PackageSpecification.cc | 13 - PackageSpecification.h | 3 --- 2 files changed, 16 deletions(-) diff --git a/PackageSpecification.cc

[PATCH setup 10/15] Change PackageSpecification::_operator to an enum

2017-05-16 Thread Jon Turney
--- PackageSpecification.cc | 71 ++--- PackageSpecification.h | 46 +++- 2 files changed, 48 insertions(+), 69 deletions(-) diff --git a/PackageSpecification.cc b/PackageSpecification.cc index a0818b3..f59b11b 100644 ---

[PATCH setup 09/15] Initial setting of trust should be TRUST_CURR

2017-05-16 Thread Jon Turney
--- PickView.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PickView.cc b/PickView.cc index b3b1c1a..222bcb8 100644 --- a/PickView.cc +++ b/PickView.cc @@ -491,8 +491,7 @@ PickView::init_headers (HDC dc) headers[last_col].width += total_delta_x; } -

[PATCH setup 08/15] Fix comments and indentation in check_for_cached

2017-05-16 Thread Jon Turney
--- download.cc | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/download.cc b/download.cc index 5cc5e2b..59af2d6 100644 --- a/download.cc +++ b/download.cc @@ -72,41 +72,38 @@ validateCachedPackage (const std::string& fullname, packagesource &

[PATCH setup 04/15] Remove packageversion::sources(), only packageversion::source() is useful

2017-05-16 Thread Jon Turney
The comments seems to indicate this was for supporting a package consisting of multiple archives. We only supported downloading such packages, not describing them in setup.ini or installing them. No such mythical beast has been sighted. --- download.cc| 24 ++--

[PATCH setup 07/15] Simplify class packagesource

2017-05-16 Thread Jon Turney
packagesource::Filename() is unused packagesource::Base() was only used in reporting progress in install. Instead report the package name and package version. (It would be nice to do so consistently in uninstall well, but we don't really know what version we are uninstalling) The default copy

[PATCH setup 01/15] Add Makefile rule to rename build products to form used when uploading

2017-05-16 Thread Jon Turney
--- Makefile.am | 5 + configure.ac | 3 +++ 2 files changed, 8 insertions(+) diff --git a/Makefile.am b/Makefile.am index a947a78..7d5e1e3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -273,6 +273,7 @@ inilint_SOURCES = \ GITVER := $(shell cd $(srcdir) && git describe --match release_\*

[PATCH setup 05/15] Remove unused forward declaration of non-existent class category

2017-05-16 Thread Jon Turney
--- package_meta.h | 1 - 1 file changed, 1 deletion(-) diff --git a/package_meta.h b/package_meta.h index 5c5e718..506d0f2 100644 --- a/package_meta.h +++ b/package_meta.h @@ -18,7 +18,6 @@ class packageversion; class packagemeta; -class category; /* Required to parse this completely */

[PATCH setup 06/15] Remove unneeded virtual from class packagesource's methods

2017-05-16 Thread Jon Turney
This class has no subclasses, and there are no plans for such. Also remove some irrelevant comments which seem to have been cut-and-pasted from packageversion.h --- package_source.h | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git

[PATCH setup 03/15] Rename "Internet Explorer Proxy Settings" to "System Proxy Settings"

2017-05-16 Thread Jon Turney
Nowadays, these settings are set via the settings app, and are used by applications other than IE. Also remove unused IDS_WININET --- res.rc | 3 +-- resource.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/res.rc b/res.rc index 45b4207..96dcf00 100644 --- a/res.rc +++

[PATCH setup 02/15] Don't bother storing prev version

2017-05-16 Thread Jon Turney
There's no means to select it since ec9c1d70, so don't bother remembering which version is the prev version. --- IniDBBuilderPackage.cc | 4 package_meta.cc| 10 ++ package_meta.h | 6 ++ prereq.cc | 2 +- 4 files changed, 5 insertions(+), 17

[PATCH setup 00/15] Various setup patches

2017-05-16 Thread Jon Turney
Still lacking a convenient river to divert to wash out the filth Jon Turney (15): Add Makefile rule to rename build products to form used when uploading Don't bother storing prev version Rename "Internet Explorer Proxy Settings" to "System Proxy Settings" Remove packageversion::sources(),

Re: Haxe package

2017-05-16 Thread Yaakov Selkowitz
On 2017-05-16 00:48, Andy Li wrote: Here is the Haxe package I wanted to create and maintain. Haxe is a programming language that compiles to JS, Java, C#, C++, and many more. More info can be found at https://haxe.org/. The haxe.cygport file I created can be found at: