Re: [[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Yaakov Selkowitz
On 2017-10-27 14:26, Achim Gratz wrote: > Ken Brown writes: >> A future version of setup might allow version numbers of the form >> e:v-r, where is an epoch. Currently setup doesn't parse these >> correctly when reading installed.db. In case ScanFindVisitor is used, >> there is an additional prob

Re: setup with experimental libsolv-based dependency solving

2017-10-27 Thread Ken Brown
On 10/27/2017 2:57 PM, Ken Brown wrote: On 10/25/2017 3:18 PM, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. I've just discovered a serious bug.  When installing from a local directory that either doesn't exist or isn't a valid repositor

Re: [[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Brian Inglis
On 2017-10-27 13:26, Achim Gratz wrote: > Ken Brown writes: >> A future version of setup might allow version numbers of the form >> e:v-r, where is an epoch. Currently setup doesn't parse these >> correctly when reading installed.db. In case ScanFindVisitor is used, >> there is an additional prob

Re: [[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Ken Brown
On 10/27/2017 3:26 PM, Achim Gratz wrote: Ken Brown writes: A future version of setup might allow version numbers of the form e:v-r, where is an epoch. Currently setup doesn't parse these correctly when reading installed.db. In case ScanFindVisitor is used, there is an additional problem in re

Re: [[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Achim Gratz
Ken Brown writes: > A future version of setup might allow version numbers of the form > e:v-r, where is an epoch. Currently setup doesn't parse these > correctly when reading installed.db. In case ScanFindVisitor is used, > there is an additional problem in reading filenames containing colons. >

Re: setup with experimental libsolv-based dependency solving

2017-10-27 Thread Ken Brown
On 10/25/2017 3:18 PM, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. I've just discovered a serious bug. When installing from a local directory that either doesn't exist or isn't a valid repository, setup doesn't correctly read/write th

[[PATCH setup] 3/3] Remove the ScanFindVisitor class

2017-10-27 Thread Ken Brown
This class was used for local installs in which the repository contains no setup.ini file. It didn't correctly handle filenames with colons, and it could become a maintenance burden to continue to support it. There are now good instructions at https://cygwin.com/package-server.html#overlay for cr

[[PATCH setup] 2/3] Bump the installed.db version to 4

2017-10-27 Thread Ken Brown
Starting with the commit 'Remove the function filemanip.cc:base', setup correctly parses version numbers of the form e:v-r in installed.db. Bump the version of installed.db to reflect the fact that older setup doesn't parse filenames containing colons correctly. --- package_db.cc | 19 +++

[[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Ken Brown
A future version of setup might allow version numbers of the form e:v-r, where is an epoch. Currently setup doesn't parse these correctly when reading installed.db. In case ScanFindVisitor is used, there is an additional problem in reading filenames containing colons. The reading is done by Win32

[[PATCH setup] 1/3] Remove the function filemanip.cc:base

2017-10-27 Thread Ken Brown
This was called only on plain filenames, not full pathnames, so it was not needed. Moreover, it wasn't correctly handling filenames containing colons. --- filemanip.cc | 18 +- filemanip.h | 1 - 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/filemanip.cc b/filem

Re: setup and colons in filenames

2017-10-27 Thread Corinna Vinschen
On Oct 27 11:20, Ken Brown wrote: > On 10/27/2017 9:44 AM, Jon Turney wrote: > > I've worked on [1] a bit so it now contains some instructions how to do > > this, rather than the previous state of affairs, which was "genini > > exists, work it out yourself" > > > > [1] https://cygwin.com/package-s

Re: setup and colons in filenames

2017-10-27 Thread Ken Brown
On 10/27/2017 9:44 AM, Jon Turney wrote: I've worked on [1] a bit so it now contains some instructions how to do this, rather than the previous state of affairs, which was "genini exists, work it out yourself" [1] https://cygwin.com/package-server.html#overlay (*) Or better: A user version o

Re: setup and colons in filenames

2017-10-27 Thread Jon Turney
On 26/10/2017 19:25, Achim Gratz wrote: Jon Turney writes: Achim Gratz wrote: Jon Turney writes: This seems a really odd thing to do, as we've no idea about the dependencies of these packages, so installing them is unlikely work well. This particular code path was vetoed from getting thrown

Re: setup and colons in filenames

2017-10-27 Thread Jon Turney
On 27/10/2017 11:40, Achim Gratz wrote: Corinna Vinschen writes: It would be pretty neat if genini could be simplified(*), so a mortal user can just run it with a directory as parameter and it creates a setup.ini file at the top-level of that dir without too much complaining about missing source

Re: setup and colons in filenames

2017-10-27 Thread Achim Gratz
Corinna Vinschen writes: > It would be pretty neat if genini could be simplified(*), so a mortal user > can just run it with a directory as parameter and it creates a setup.ini > file at the top-level of that dir without too much complaining about > missing sources etc. > > (*) Or better: A user ve

Re: setup and colons in filenames

2017-10-27 Thread Corinna Vinschen
On Oct 26 20:25, Achim Gratz wrote: > Jon Turney writes: > > Can we have a link to that discussion, please? > > It's somewhere in that thread from June 2015 related to the changes > between 2.871 and 2.873. Also one of the intermediate versions got > complaints due to that code path not working c