Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Ken Brown
On 1/13/2018 8:52 PM, Brian Inglis wrote: On 2018-01-13 17:00, Ken Brown wrote: On 1/13/2018 5:55 PM, Ken Brown wrote: On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Brian Inglis
On 2018-01-13 17:00, Ken Brown wrote: > On 1/13/2018 5:55 PM, Ken Brown wrote: >> On 1/13/2018 4:29 PM, Brian Inglis wrote: >>> On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the default solutions.  I'm not sure we

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Ken Brown
On 1/13/2018 5:55 PM, Ken Brown wrote: On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the default solutions.  I'm not sure we want to "strongly recommend" the default solution

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Ken Brown
On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the default solutions.  I'm not sure we want to "strongly recommend" the default solution over the other solution(s).  I guess what

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Brian Inglis
On 2018-01-13 12:56, Ken Brown wrote: > On 1/13/2018 9:14 AM, Jon Turney wrote: >> On 09/01/2018 15:49, Ken Brown wrote: >>> On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Ken Brown
On 1/13/2018 9:14 AM, Jon Turney wrote: On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though "Uninstall A" was the first solution, A didn't get

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Achim Gratz
Achim Gratz writes: > Put these in noarch/ and arrange for setup to be able to install both > from noarch/ and $arch/ so that we can also de-duplicate things like > debuginfo and documentation down the road. I forgot to add that this is already possible by injecting extra packages: say you

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Achim Gratz
Jon Turney writes: > * De-duplicate source archives > > Source archives which are identical[2] between x86 and x86_64 will be > moved to paths starting src/ in the release area. You keep acting like using a new src/ hierarchy was already decided upon, yet I don't remember it even getting

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Jon Turney
On 12/01/2018 18:11, Peter A. Castro wrote: On Fri, 12 Jan 2018, Jon Turney wrote: On 11/01/2018 17:53, Peter A. Castro wrote: On Wed, 10 Jan 2018, Jon Turney wrote: * Add depends: to version descriptions This is a version-specific list of required packages (as opposed to requires:, which

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Jon Turney
On 10/01/2018 23:27, David Stacey wrote: On 10/01/18 22:44, Jon Turney wrote: * Add depends: to version descriptions * De-duplicate source archives * Migrate from setup.hint to pvr.hint in release area That all sounds good to me. Regarding the de-duplication of source files: will sources

Re: [PATCH setup v3] Query the user if a corrupt local file is found

2018-01-13 Thread Jon Turney
On 10/01/2018 02:59, Ken Brown wrote: Also reorganize package validation. Move the size-validation code in download.cc and the hash-validation code in install.cc into new member functions of the packagesource class. Add a bool member 'validated' to the class to make sure that the checking is

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Jon Turney
On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though "Uninstall A" was the first solution, A didn't get uninstalled. In case you want to replicate this,