On 22/09/2022 17:56, Achim Gratz wrote:
Achim Gratz writes:
Achim Gratz writes:
I had updated setup to 2.921 recently, so I rolled it back to 2.920 and
this version does the package selection correctly. I haven't yet looked
what commit is responsible, but whatever the cause of the regression is
still in 2.922 as well.
The most likely change responsible for this is the additions in
package_meta.cc in commit c99e4c14911181636892355a4f1855024051ea1d. I
might not be able to check this tomorrow, though I'll try to free up
some time for that.
That was indeed the culprit. I've reverted just these two hunks on top
of release_2.922 and things worked again.
Yes, looking again at that change, the first hunk in package_meta.cc,
changing Install_action doesn't look right.
If I remember correctly action=Install_action, desired=empty package
version (evaluating as a boolean is false) means "install the solver's
preferred version", so converting that to NoChange_action seems wrong.
I'm kind of confused how to reproduce this, or why it decided to install
only some things, rather than nothing.
Christian,
From your reply to
https://cygwin.com/pipermail/cygwin-apps/2022-August/042212.html, it
seems this change is meant to handle the case where 'I' is pressed but
the package isn't accessible? Although I don't seem quite how.
